From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eduardo Bellani <ebellani@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix table variable with commas in ob-sqlite
Date: Wed, 06 Sep 2017 13:19:56 +0200 [thread overview]
Message-ID: <87o9qoaxb7.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87zia8yhel.fsf@brickabode.com> (Eduardo Bellani's message of "Tue, 05 Sep 2017 18:17:22 -0300")
Hello,
Eduardo Bellani <ebellani@gmail.com> writes:
> ob-sqlite.el: Enable table with fields containing commas to be used as
> arguments to sqlite source blocks
>
> * lisp/ob-sqlite.el: Stop interfering with the 'orgtbl-to-csv' default
> formatting.
>
> * testing/lisp/test-ob-sqlite.el:: Adds a test using a table with
> commas in the content of any of its fields as an argument for a
> sqlite source block. Use the 'org-test-with-temp-text' pattern.
>
>
> The problem here was that ob-sqlite was providing a format to the
> 'orgtbl-to-csv' that actually overwrote the default format in that
> function, and in the case where there were commas in the content of the
> table, broke the table as argument mechanism.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2017-09-06 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 21:17 [PATCH] Fix table variable with commas in ob-sqlite Eduardo Bellani
2017-09-06 11:19 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9qoaxb7.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=ebellani@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).