Bug: org-goto buffer not honouring org-cycle-separator-lines [9.1.9 (release_9.1.9-65-g5e4542 @ /home/carlos/local/stow/emacs-26/share/emacs/26.1.50/lisp/org/)]

[Carlos Pita <carlosjosepita@gmail.com>]

Say I set org-cycle-separator-lines to 1. Now in an org buffer that has
nodes separated by one line, I do C-c C-j to open the org-goto
buffer. Then in the org-goto buffer:

1. Every node is suffixed by an ellipsis, even if the only content there
   is an empty line.

2. Nodes are not separated by an empty line anymore.

That is, the nodes are "swallowing" the empty lines between them as
their contents, which is exactly what org-cycle-separator-lines = 1 is
intended to avoid.

---

Emacs  : GNU Emacs 26.1.50 (build 11, x86_64-pc-linux-gnu, GTK+ Version 3.24.1)
 of 2018-09-26
Package: Org mode version 9.1.9 (release_9.1.9-65-g5e4542 @ /home/carlos/local/stow/emacs-26/share/emacs/26.1.50/lisp/org/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-fontify-whole-heading-line t
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-refile-targets '((nil :maxlevel . 5))
 org-agenda-files '("~/notes/gtd.org")
 org-mode-hook '((lambda nil
                  (let
                   ((in-notes (string-prefix-p (expand-file-name "~/notes/") buffer-file-name))
                    (in-inbox (string= buffer-file-name (expand-file-name "~/notes/inbox.org")))
                    (in-goto (string= (buffer-name) "*org-goto*")))
                   (if in-notes
                    (progn (org-indent-mode)
                     (if in-inbox (progn (my-fill-mode -1) (auto-revert-mode))))
                    )
                   (if (or in-inbox in-goto)
                    (progn
                     (let
                      ((--dolist-tail--
                        (quote (org-level-1 org-level-2 org-level-3 org-level-4 org-level-5)))
                       face)
                      (while --dolist-tail-- (setq face (car --dolist-tail--))
                       (face-remap-add-relative face :inherit nil)
                       (setq --dolist-tail-- (cdr --dolist-tail--)))
                      )
                     )
                    )
                   (add-hook (quote completion-at-point-functions)
                    (quote pcomplete-completions-at-point) nil t)
                   )
                  )
                 #[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-show-block-all append local] 5]
                 #[0 "\300\301\302\303\304$\207"
                   [add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
 org-agenda-deadline-faces '((1.001 . error) (1.0 . org-warning) (0.5 . org-upcoming-deadline)
                             (0.0 . org-upcoming-distant-deadline))
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-hide-leading-stars t
 org-babel-load-languages '((emacs-lisp . t) (python . t))
 org-link-abbrev-alist '(("google" . "https://www.google.com/#q=") ("docs" . my-find-in-docs))
 org-export-backends '(ascii beamer html latex md)
 org-babel-python-command "ipython -i --simple-prompt --matplotlib=agg"
 org-fontify-quote-and-verse-blocks t
 org-fontify-done-headline t
 org-occur-hook '(org-first-headline-recenter)
 org-cycle-separator-lines 1
 org-footnote-auto-adjust t
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
 org-babel-tangle-lang-exts '(("python" . "py") ("emacs-lisp" . "el") ("elisp" . "el"))
 org-format-latex-options '(:foreground default :background default :scale 1.3 :html-foreground
                            "Black" :html-background "Transparent" :html-scale 1.0 :matchers
                            ("begin" "$1" "$" "$$" "\\(" "\\["))
 org-refile-use-outline-path t
 org-font-lock-set-keywords-hook '(doom-org-custom-fontification)
 org-confirm-shell-link-function 'yes-or-no-p
 org-stuck-projects '("-someday+LEVEL=2/-DONE" ("TODO") nil "")
 org-link-parameters '(("id" :follow org-id-open)
                       ("rmail" :follow org-rmail-open :store org-rmail-store-link)
                       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
                       ("irc" :follow org-irc-visit :store org-irc-store-link)
                       ("info" :follow org-info-open :export org-info-export :store
                        org-info-store-link)
                       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
                       ("docview" :follow org-docview-open :export org-docview-export :store
                        org-docview-store-link)
                       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
                       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
                        org-bbdb-complete-link :store org-bbdb-store-link)
                       ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs")
                       ("doi" :follow org--open-doi-link) ("elisp" :follow org--open-elisp-link)
                       ("file" :complete org-file-complete-link)
                       ("ftp" :follow (lambda (path) (browse-url (concat "ftp:" path))))
                       ("help" :follow org--open-help-link)
                       ("http" :follow (lambda (path) (browse-url (concat "http:" path))))
                       ("https" :follow (lambda (path) (browse-url (concat "https:" path))))
                       ("mailto" :follow (lambda (path) (browse-url (concat "mailto:" path))))
                       ("news" :follow (lambda (path) (browse-url (concat "news:" path))))
                       ("shell" :follow org--open-shell-link))
 org-capture-templates '(("p" "Protocol Link" entry (file "~/notes/inbox.org")
                          "* %:description\n\n%:link\n\n%i%?" :empty-lines 1)
                         ("L" "Protocol Link" entry (file "~/notes/inbox.org")
                          "* %:description\n\n%:link%?" :empty-lines 1)
                         )
 org-confirm-babel-evaluate nil
 org-preview-latex-image-directory "/tmp/ltximg/"
 )