From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org-capture: Add a custom to control save target file or
 not.
Date: Thu, 13 Dec 2018 17:25:29 +0100
Message-ID: <87o99p4cna.fsf@nicolasgoaziou.fr>
References: <19dc1211.1e75.162b770bd5c.Coremail.tumashu@163.com>
	<87po34y2ya.fsf@nicolasgoaziou.fr>
	<77a63bcf.32cc.162bcc4a5d0.Coremail.tumashu@163.com>
	<877epap70f.fsf@nicolasgoaziou.fr>
	<de3a784.4406.162c388d5ba.Coremail.tumashu@163.com>
	<CAFyQvY2jqsn4JEkdwJhASrZM5rBqbRbz2dC_uqn8eRKDg_ZUTw@mail.gmail.com>
	<875zyro5jz.fsf@gmail.com>
	<CAFyQvY2TKQWGVExB0o50CgcissD3Y3HOsO5L=MS=gYdZPbeY6w@mail.gmail.com>
	<CAFyQvY0ha85xX-v1MWGY9JO9a-B-SS-v=WzVvfEsUsA58jHSKg@mail.gmail.com>
	<87sh1t5ots.fsf@nicolasgoaziou.fr>
	<CAFyQvY1b8-VqkUH6uTnCyKC63E1UUaaePp5sDwmu+_dyz1uWgg@mail.gmail.com>
	<87o9cg6ci3.fsf@nicolasgoaziou.fr> <87sh1szjhf.fsf@gmail.com>
	<3C79C151-715A-4BF7-8CBF-63614A723721@scratch.space>
	<CAFyQvY3k6ozPk5TUyPBhyxCi7WmtiZuzT9wiDfQE60C_S2G9qg@mail.gmail.com>
	<CAFyQvY3Onmh=k7VDqZdZSjL8TDFCEDXGypwPuCF0k9WOeBZ_PA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41311)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gXTny-0005DS-Jl
	for emacs-orgmode@gnu.org; Thu, 13 Dec 2018 11:25:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1gXTnx-0000mr-Os
	for emacs-orgmode@gnu.org; Thu, 13 Dec 2018 11:25:42 -0500
In-Reply-To: <CAFyQvY3Onmh=k7VDqZdZSjL8TDFCEDXGypwPuCF0k9WOeBZ_PA@mail.gmail.com>
	(Kaushal Modi's message of "Thu, 13 Dec 2018 10:24:47 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: van@scratch.space, Eric Abrahamsen <eric@ericabrahamsen.net>, emacs-org list <emacs-orgmode@gnu.org>, Bastien Guerry <bzg@gnu.org>

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> I have formatted 2 patches to address this (attached). If they look fine, I
> can commit them to master.

Thank you.

> +    (unless (org-capture-get :no-save)
> +      ;; Save the target file.
> +      (save-buffer))

The comment does not look terribly useful. I would put the whole
`unless' in a single line.

Barring that nitpicking of mine, LGTM!

Regards,

-- 
Nicolas Goaziou