Regression - problem with links

Regression - problem with links

[Bernt Hansen]

Hi,

I have a habit with a list of links in it which I use to navigate to
places for dealing with the task.

Recently C-c C-o shows the link address instead of description which
makes it hard to use.  This occurs for C-c C-o on the headline of the
task and also in the agenda.

My links are like this:


[[https://somewebsiteaddress.net/path/to/page.do][Timekeeper]]

[[id:eb1085ed-15fe-46a3-8b5e-3971587d1123][OTL 2019]]

and I want to see

[1] Timekeeper
[2] OTL 2019

but instead I get the address like this which is much less useable

[1] https://somewebsiteaddress.net/path/to/page.do
[2] id:eb1085ed-15fe-46a3-8b5e-3971587d1123

I have multiple lists with multiple id: entries so I can't tell which is
which anymore from the headline.  My workaround is to display the task
and do C-c C-o on the task I need to visit.

I am on the latest git master commit as of this morning.

Regards,
Bernt

Re: Regression - problem with links

[Marco Wahl]

Hi,

[...]

> My links are like this:
>
>
> [[https://somewebsiteaddress.net/path/to/page.do][Timekeeper]]
> [[id:eb1085ed-15fe-46a3-8b5e-3971587d1123][OTL 2019]]
>
> and I want to see
>
> [1] Timekeeper
> [2] OTL 2019
>
> but instead I get the address like this which is much less useable
>
> [1] https://somewebsiteaddress.net/path/to/page.do
> [2] id:eb1085ed-15fe-46a3-8b5e-3971587d1123

This sounds like a bug fixed a few days ago.

    https://code.orgmode.org/bzg/org-mode/commit/b1429cdfe043b199bb7be6dc5c97a299954b4e0d

Can you check if the fix is in your copy of Org?


HTH,  Marco

Re: Regression - problem with links

[Eric S Fraga]

On Friday, 15 Mar 2019 at 10:27, Bernt Hansen wrote:
> Recently C-c C-o shows the link address instead of description which
> makes it hard to use.  This occurs for C-c C-o on the headline of the
> task and also in the agenda.

This was noted and then fixed last week.  Maybe you need to update to a more recent version?

-- 
Eric S Fraga via Emacs 27.0.50, Org release_9.2.2-287-gb1429c

Re: Regression - problem with links

[Bernt Hansen]

Marco Wahl <marcowahlsoft@gmail.com> writes:

> Hi,
>
> [...]
>
>> My links are like this:
>>
>>
>> [[https://somewebsiteaddress.net/path/to/page.do][Timekeeper]]
>> [[id:eb1085ed-15fe-46a3-8b5e-3971587d1123][OTL 2019]]
>>
>> and I want to see
>>
>> [1] Timekeeper
>> [2] OTL 2019
>>
>> but instead I get the address like this which is much less useable
>>
>> [1] https://somewebsiteaddress.net/path/to/page.do
>> [2] id:eb1085ed-15fe-46a3-8b5e-3971587d1123
>
> This sounds like a bug fixed a few days ago.
>
>     https://code.orgmode.org/bzg/org-mode/commit/b1429cdfe043b199bb7be6dc5c97a299954b4e0d
>
> Can you check if the fix is in your copy of Org?

I have that commit in my current git version.

Last week I noticed agenda clock reports had file: text before this fix
and reverted back to normal looking clock reports after however the menu
from C-c C-o doesn't display link descriptions for me.

I'll try to isolate which commit breaks this.

Regards,
Bernt

Re: Regression - problem with links

[Bernt Hansen]

Bernt Hansen <bernt@norang.ca> writes:

> Marco Wahl <marcowahlsoft@gmail.com> writes:
>
>> Hi,
>>
>> [...]
>>
>>> My links are like this:
>>>
>>>
>>> [[https://somewebsiteaddress.net/path/to/page.do][Timekeeper]]
>>> [[id:eb1085ed-15fe-46a3-8b5e-3971587d1123][OTL 2019]]
>>>
>>> and I want to see
>>>
>>> [1] Timekeeper
>>> [2] OTL 2019
>>>
>>> but instead I get the address like this which is much less useable
>>>
>>> [1] https://somewebsiteaddress.net/path/to/page.do
>>> [2] id:eb1085ed-15fe-46a3-8b5e-3971587d1123
>>
>> This sounds like a bug fixed a few days ago.
>>
>>     https://code.orgmode.org/bzg/org-mode/commit/b1429cdfe043b199bb7be6dc5c97a299954b4e0d
>>
>> Can you check if the fix is in your copy of Org?
>
> I have that commit in my current git version.
>
> Last week I noticed agenda clock reports had file: text before this fix
> and reverted back to normal looking clock reports after however the menu
> from C-c C-o doesn't display link descriptions for me.
>
> I'll try to isolate which commit breaks this.
>
> Regards,
> Bernt

My current master  is

f0dc3a06d (test-org-clock: Fix one test, 2019-03-15)

This may be another case that isn't covered by the fix.
maint displays links correctly but master does not for me in the menu
when you select a link to jump to with C-c C-o from the heading or from
the agenda.

git bisect identifies the following commit:

2b00d6281606ef295dadbe4ddd929ebdd6716d60 is the first bad commit
commit 2b00d6281606ef295dadbe4ddd929ebdd6716d60
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Sat Mar 9 10:58:41 2019 +0100

    Change bracket link escape syntax

    * contrib/lisp/org-link-edit.el (org-link-edit--link-data):
    * lisp/ob-tangle.el (org-babel-tangle-comment-links): Update
    match-group.
    (org-babel-detangle): Remove unnecessary `org-link-escape' call.
    (org-babel-tangle-jump-to-org): Update match group.
    (org-link-url-hexify):
    (org-link-escape-chars): Remove variables.
    * lisp/ol.el (org-link--decode-compound): Renamed from
      `org-link--unescape-compound'.
    (org-link--decode-single-byte-sequence): Renamed from
    `org-link--unescape-single-byte-sequence'.
    (org-link-make-regexps): Update `org-link-bracket-re' syntax.
    (org-link-encode): New function, renamed from `org-link-escape'.
    (org-link-decode): New function, renamed from `org-link-unescape'.
    (org-link-escape):
    (org-link-unescape): Use new escape syntax.
    (org-link-make-string): Apply new escaping rules.
    (org-link-display-format):
    (org-insert-link): Update match group.
    * lisp/org-agenda.el (org-diary):
    (org-agenda-format-item):
    (org-agenda-to-appt): Update match group.
    * lisp/org-clock.el (org-clocktable-write-default): Update match
    group.
    * lisp/org-element.el (org-element-link-parser): Update match group.
    * lisp/org-mobile.el (org-mobile-escape-olp):
    (org-mobile-locate-entry): Apply function renaming.
    * lisp/org-protocol.el (org-protocol-split-data):
    (org-protocol-parse-parameters): Apply function renaming.
    * lisp/org.el (org-refile): Update match group.
    * testing/README (Interactive testing from within Emacs): Fix
      examples.
    * testing/lisp/test-ol.el (test-ol/encode): Merge old escape tests.
    (test-ol/decode): Merge old unescape tests.
    (test-ol/escape):
    (test-ol/unescape):
    (test-ol/make-string): New tests.
    * testing/lisp/test-org-clock.el (test-org-clock/clocktable/link):
    * testing/lisp/test-org.el (test-org/custom-id):
    (test-org/fuzzy-links):
    * testing/lisp/test-ox.el (test-org-export/resolve-fuzzy-link):
    Update
      tests.

:040000 040000 474dd71a09f6396ef593cf061aa0001968fb5412
976cda41aeecca75da7c5982aeb89a2cde5e5567 M      contrib
:040000 040000 2ab4f30b6deac5cfc4c9e83fc1f2ac013232f8da
d7b6b3c0ff0adda1a557dfe87bffd0d8f17f6659 M      lisp
:040000 040000 133b3e5e20e848a7347ca4c73c517bca4120461d
28f9768c483af5bce6a242889360747be4ac865a M      testing

Regards,
Bernt.

Re: Regression - problem with links

[Marco Wahl]

Bernt Hansen <bernt@norang.ca> writes:

>>>> My links are like this:
>>>>
>>>>
>>>> [[https://somewebsiteaddress.net/path/to/page.do][Timekeeper]]
>>>> [[id:eb1085ed-15fe-46a3-8b5e-3971587d1123][OTL 2019]]
>>>>
>>>> and I want to see
>>>>
>>>> [1] Timekeeper
>>>> [2] OTL 2019
>>>>
>>>> but instead I get the address like this which is much less useable
>>>>
>>>> [1] https://somewebsiteaddress.net/path/to/page.do
>>>> [2] id:eb1085ed-15fe-46a3-8b5e-3971587d1123

>> Last week I noticed agenda clock reports had file: text before this fix
>> and reverted back to normal looking clock reports after however the menu
>> from C-c C-o doesn't display link descriptions for me.

> My current master  is
>
> f0dc3a06d (test-org-clock: Fix one test, 2019-03-15)
>
> This may be another case that isn't covered by the fix.
> maint displays links correctly but master does not for me in the menu
> when you select a link to jump to with C-c C-o from the heading or from
> the agenda.

> 2b00d6281606ef295dadbe4ddd929ebdd6716d60 is the first bad commit

With commit 2b00d6281 I can reproduce the display of e.g.
[[https://duckduckgo.com][ddg]] as "https://duckduckgo.com".

With commit b1429cdfe and also f0dc3a06d the link is displayed as "ddg".

Further C-c C-o, which is bound here to command org-open-at-point, on
the following heading opens the webpage as expected for commit
2b00d6281, b1429cdfe and f0dc3a06d.

#v+
* duckduckgo
[[http://duckduckgo.com][ddg]]
#v-

IOW I can't reproduce your issue AFAICS.

Is it a configuration issue?


Best regards,  Marco

Re: Regression - problem with links

[Bernt Hansen]

Marco Wahl <marcowahlsoft@gmail.com> writes:

> IOW I can't reproduce your issue AFAICS.
>
> Is it a configuration issue?

Possibly.  I will try to produce an ECM for the issue I am seeing.

Regards,
Bernt

Re: Regression - problem with links

[Bernt Hansen]

Bernt Hansen <bernt@norang.ca> writes:

> Marco Wahl <marcowahlsoft@gmail.com> writes:
>
>> IOW I can't reproduce your issue AFAICS.
>>
>> Is it a configuration issue?
>
> Possibly.  I will try to produce an ECM for the issue I am seeing.
>
> Regards,
> Bernt

Here is my ECM:

--- test.org -------------------------------------------------------------------
Regression - problem with links

*Keys To Reproduce*

1) Move to Update Timekeeper and OTL 2019 headling
   C-c C-n

2) Open links
   C-c C-o

Results in maint branch (0007df863 (org-lint: Do not warn about URL setup files, 2019-03-14))
Org mode version 9.2.2 (release_9.2.2-13-g0007df @ c:/D-Drive/bin/org-mode/lisp/)
GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17

#+begin_example
[1]  Link One (https://xxx.yyy.zzz)
[2]  Line Two (https://foo.bar.baz)
[3]  Line Three (https://aaa.bbb)
[4]  Link Four (https://ccc.ddd)
[5]  Link Five by id (id:eb1085ed-15fe-46a3-8b5e-3971587d1123)
[6]  Link Six by id (id:11886507-bb77-49fb-af59-9d5ac43dce0d)
#+end_example

Results in master branch (a70ab164f (org-manual: Small fixes, 2019-03-16))
Org mode version 9.2.2 (release_9.2.2-311-ga70ab1 @ c:/D-Drive/bin/org-mode/lisp/)
GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17

#+begin_example
[1]  https://xxx.yyy.zzz
[2]  https://foo.bar.baz
[3]  https://aaa.bbb
[4]  https://ccc.ddd
[5]  id:eb1085ed-15fe-46a3-8b5e-3971587d1123
[6]  id:11886507-bb77-49fb-af59-9d5ac43dce0d
#+end_example

* TODO Update Timekeeper and OTL 2019

[[https://xxx.yyy.zzz][Link One]]

[[https://foo.bar.baz][Line Two]]

[[https://aaa.bbb][Line Three]]

[[https://ccc.ddd][Link Four]]

[[id:eb1085ed-15fe-46a3-8b5e-3971587d1123][Link Five by id]]

[[id:11886507-bb77-49fb-af59-9d5ac43dce0d][Link Six by id]]


--- minimal.emacs --------------------------------------------------------------
(add-to-list 'load-path "C:/D-Drive/bin/org-mode/lisp/")
(add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
(require 'org)

(global-set-key "\C-cl" 'org-store-link)
(global-set-key "\C-ca" 'org-agenda)
(global-set-key "\C-cb" 'org-iswitchb)
--- test.el --------------------------------------------------------------------
; empty file
--- windows icon properties to start minimal emacs -----------------------------
C:\D-Drive\bin\emacs-25.1\bin\runemacs.exe -q -l ~/minimal.emacs -l ~/test.el ~/test.org

Regards,
Bernt

Re: Regression - problem with links

[Nicolas Goaziou]

Hello,

Bernt Hansen <bernt@norang.ca> writes:

> Here is my ECM:
>
> --- test.org -------------------------------------------------------------------
> Regression - problem with links
>
> *Keys To Reproduce*
>
> 1) Move to Update Timekeeper and OTL 2019 headling
>    C-c C-n
>
> 2) Open links
>    C-c C-o
>
> Results in maint branch (0007df863 (org-lint: Do not warn about URL setup files, 2019-03-14))
> Org mode version 9.2.2 (release_9.2.2-13-g0007df @ c:/D-Drive/bin/org-mode/lisp/)
> GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17
>
> #+begin_example
> [1]  Link One (https://xxx.yyy.zzz)
> [2]  Line Two (https://foo.bar.baz)
> [3]  Line Three (https://aaa.bbb)
> [4]  Link Four (https://ccc.ddd)
> [5]  Link Five by id (id:eb1085ed-15fe-46a3-8b5e-3971587d1123)
> [6]  Link Six by id (id:11886507-bb77-49fb-af59-9d5ac43dce0d)
> #+end_example
>
>
> Results in master branch (a70ab164f (org-manual: Small fixes, 2019-03-16))
> Org mode version 9.2.2 (release_9.2.2-311-ga70ab1 @ c:/D-Drive/bin/org-mode/lisp/)
> GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17
>
> #+begin_example
> [1]  https://xxx.yyy.zzz
> [2]  https://foo.bar.baz
> [3]  https://aaa.bbb
> [4]  https://ccc.ddd
> [5]  id:eb1085ed-15fe-46a3-8b5e-3971587d1123
> [6]  id:11886507-bb77-49fb-af59-9d5ac43dce0d
> #+end_example
>
> * TODO Update Timekeeper and OTL 2019
>
> [[https://xxx.yyy.zzz][Link One]]
>
> [[https://foo.bar.baz][Line Two]]
>
> [[https://aaa.bbb][Line Three]]
>
> [[https://ccc.ddd][Link Four]]
>
> [[id:eb1085ed-15fe-46a3-8b5e-3971587d1123][Link Five by id]]
>
> [[id:11886507-bb77-49fb-af59-9d5ac43dce0d][Link Six by id]]

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Re: Regression - problem with links

[Bernt Hansen]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Bernt Hansen <bernt@norang.ca> writes:
>
>> Here is my ECM:
>
> Fixed. Thank you.
>
> Regards,

Confirmed.  Thanks for the lightning quick response!

I have another issue I will send separately.

Regards,
Bernt