From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GF5DACdhll73cQAA0tVLHw (envelope-from ) for ; Wed, 15 Apr 2020 01:19:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id EBHCAyphll71CgAA1q6Kng (envelope-from ) for ; Wed, 15 Apr 2020 01:19:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F29A7941C41 for ; Wed, 15 Apr 2020 01:19:35 +0000 (UTC) Received: from localhost ([::1]:41094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOWiD-0000JL-GA for larch@yhetil.org; Tue, 14 Apr 2020 21:19:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33529) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOWcP-00020w-FQ for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 21:13:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOWcI-0002C8-VU for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 21:13:33 -0400 Received: from [183.249.128.92] (port=9381 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jOWcI-000285-H1 for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 21:13:26 -0400 Received: by dark.localdomain (Postfix, from userid 1000) id 775CC242F68; Wed, 15 Apr 2020 09:13:18 +0800 (HKT) References: <87ftdact0g.fsf@gmail.com> <87eesu2ekz.fsf@nicolasgoaziou.fr> <87d08c9i7j.fsf@gmail.com> <87ftd7agwl.fsf@localhost> <877dyj9wkc.fsf@gmail.com> <87k12j491l.fsf@localhost> <87wo6jw3yi.fsf@nicolasgoaziou.fr> <87eesqmylz.fsf@gmail.com> <877dyi1b22.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.3.8; emacs 28.0.50 From: stardiviner To: Nicolas Goaziou Subject: Re: [SOLVED] Re: [PATCH] Show hidden drawers when org-cycle on headlines In-reply-to: <877dyi1b22.fsf@nicolasgoaziou.fr> Date: Wed, 15 Apr 2020 09:13:18 +0800 Message-ID: <87o8rteekx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 183.249.128.92 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: emacs-orgmode@gnu.org, Ihor Radchenko Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: 1.59 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [1.59 / 13.00]; HAS_REPLYTO(0.00)[numbchild@gmail.com]; GENERIC_REPUTATION(0.00)[-0.57561597474834]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; R_MISSING_CHARSET(2.50)[]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.27), country: US(-0.01), ip: 209.51.188.17(-0.58)]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[numbchild@gmail.com,emacs-orgmode-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; HAS_LIST_UNSUB(-0.01)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gnu.org,gmail.com]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : SPF not aligned (relaxed), No valid DKIM,none] X-TUID: gitaRJbNn7mz =2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Nicolas Goaziou writes: > Hello, > > stardiviner writes: > >> I agree. As I described in my given example "org-contacts", which includ= e person >> info in properties drawer. That's why I want to expand when I press "Tab= " on >> expanding headline. If I see a contact's info with "C-u C-u C-u Tab" is = not >> convenient. > > You can rebind it. > >> Is it possible to change "org-cycle-hide-drawers" to "org-cycle-toggle-d= rawers". >> Make it more extendable. Because that function only changed one argument= of >> "org-flag-drawer". If so some user like me will be easy to toggle hide/s= how >> drawers. (Of course, I don't want to add redundant code in my Emacs init= .) If >> this is fine, I will re-edit my patch. Remove defcustom option, and hook= on >> cycle. Only keep changes in "org-cycle-hide-drawers". > > I think something is wrong with `org-cycle-hide-drawers' at the moment. > This function was initially meant to be added to `org-cycle-hook' to > re-hide drawers. It should only re-hide properties drawers. In any case, > it is not needed to expand this function, it should be trimmed down to > only take care of property drawers. > > What is needed, though, it a tooling similar to block visibility > functions, i.e., `org-hide-block-toggle', `org-hide-block-hall', and, > maybe, `org-hide-block-toggle-maybe'. Regular drawers should get the > same treatment as blocks. > > If you look at `org-cycle' code, there is a comment > > ;; Drawers: delegate to `org-flag-drawer'. > > This part should be extracted into a new function. This sounds reasonable. (I deleted my patch on my local fork, I think your = solution is better.) =2D --=20 [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 =20=20=20=20=20=20 =2D----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl6WX64UHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsMKJggAzKm3lD0NTcG4eak7khuzw5bbt9W6 MNi8kkK61LWaPfW+BgCGxJz+RAYnKnPca7JDZ15xEwcVc1/UIFZ4bFTmeH25/yjp 49KsTVR4E8mgueAgm+Js1uNTj2GUXhvBpiu8RjPe6578GHzopLUbBgvTgPtZVswa A9Mr3ecu3lFMja3KfjoB73w3sa6UncwQ3zqhiV6zqVFAcrO02YYfgLAFhmYjKQ5h b5hkdxliZsL6H6kgLG7TQFwu1S1vpgGZNaZvz6sS9h3PO3UwglbCGxWo8EFsYHiz +YFJMw3FcGxdXygp9l+ypG1Zhpwr7arZE8Zuq4ypduxmjWkUyOG7O6dbdA=3D=3D =3DhaRH =2D----END PGP SIGNATURE-----