From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6KI6JgbC114LKAAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 15:30:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aFQrIgbC114BZQAA1q6Kng (envelope-from ) for ; Wed, 03 Jun 2020 15:30:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0F0B2940B2B for ; Wed, 3 Jun 2020 15:30:14 +0000 (UTC) Received: from localhost ([::1]:41886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgVLH-0007Jr-Rg for larch@yhetil.org; Wed, 03 Jun 2020 11:30:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgVKx-0007Jh-Di for emacs-orgmode@gnu.org; Wed, 03 Jun 2020 11:29:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43433) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgVKw-000215-QK; Wed, 03 Jun 2020 11:29:50 -0400 Received: from lns-bzn-40-82-251-163-54.adsl.proxad.net ([82.251.163.54]:42126 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jgVKw-0004h7-F7; Wed, 03 Jun 2020 11:29:50 -0400 Received: by guerry (Postfix, from userid 1000) id C131C1A60817; Wed, 3 Jun 2020 17:29:47 +0200 (CEST) From: Bastien To: Mario Frasca Subject: Re: `with` as a list. Organization: GNU References: <87h7vxuq8i.fsf@kyleam.com> <1a448b21-cdf9-467d-e707-471bb8c01781@anche.no> <874krvvdr3.fsf@kyleam.com> <87sgfftt30.fsf@kyleam.com> <87zh9kxjw5.fsf@bzg.fr> <15c8b193-6bf5-5248-c557-d28c0c25f123@anche.no> Date: Wed, 03 Jun 2020 17:29:47 +0200 In-Reply-To: <15c8b193-6bf5-5248-c557-d28c0c25f123@anche.no> (Mario Frasca's message of "Wed, 3 Jun 2020 10:18:13 -0500") Message-ID: <87o8q0rwus.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: ihqZ3UVu2Y+e Mario Frasca writes: > I'm sure you do understand what I mean, and I guess you know what > would be the correctly formatted version.=C2=A0 can you show me?=C2=A0=20 Yes. You mentioned earlier that you missed this section: https://orgmode.org/worg/org-contribute.html#commit-messages Let me quote the text from this section: A commit message should be constructed in the following way: Line 1 of the commit message should always be a short description of the overall change. Line 1 does not get a dot at the end and does not start with a star. Generally, it starts with the filename that has been changed, followed by a colon. Line 2 is an empty line. In line 3, the ChangeLog entry should start. A ChangeLog entry looks like this: * org-timer.el (org-timer-cancel-timer, org-timer-stop): Enhance message. (org-timer-set-timer): Use the number of minutes in the Effort property as the default timer value. Three prefix arguments will ignore the Effort value property. The few lines above is what we called the "changelog". It should be the first part of the commit message -- after which you can add more free-form context and explanations, if needed. When you are on a function/variable that you updated in the modified version of your code, you can create a changelog entry by hitting the `C-x 4 a' keybinding. This will open a new buffer, quote the function or variable, and let you write a short sentence (starting with an uppercase letter and ending with the ".", as a regular sentence.) See these examples: https://code.orgmode.org/bzg/org-mode/commit/b908367b03 https://code.orgmode.org/bzg/org-mode/commit/65fdf2be16 https://code.orgmode.org/bzg/org-mode/commit/f5997d5956 > next time I'll do better, but as of now, I obviously do not > understand what you want, and why.=C2=A0 I hope it is a bit more clear now. > I was busy amending my other patches, and preparing a few more, but > let's save time on both sides, and I'll give up for the time being. You did the hardest part, which is to fix things, I hope you will be=20 able to update the formatting of the commit messages. As for the "why", this is because Org follows the same conventions than Emacs when it comes to commit messages (partly because Org is part of Emacs.) Thanks in advance for when you'll feel motivated again! --=20 Bastien