emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Leo Vivier <leo.vivier+dev@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-element.el: Fix properties being upcased by parser
Date: Mon, 08 Jun 2020 21:43:36 +0200	[thread overview]
Message-ID: <87o8pt5onr.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87d0693gam.fsf@hidden> (Leo Vivier's message of "Mon, 08 Jun 2020 14:14:57 +0200")

Leo Vivier <leo.vivier+dev@gmail.com> writes:

> I understand, but I think the function is also used to modify
> file-parameters like `#+title`.  If you run `org-element-parse-buffer`
> on a buffer with the following content:
> --------------------------------[START]--------------------------------
> #+title: Foo
> ---------------------------------[END]---------------------------------
> Here’s what you get:
> --------------------------------[START]--------------------------------
> (org-data
>  nil
>  (section
>   (:begin 1
>    :end 14
>    :contents-begin 1
>    :contents-end 14
>    :post-blank 0
>    :post-affiliated 1
>    :parent #0)
>   (keyword
>    (:key "TITLE"   ; <----------

Keywords are stored in a normalized form. In this case, this is
uppercase, for reasons. I don't see an issue here. The docstring could
specify it, tho.

> Ultimately, it’s not changing anything for the users, but I did find it
> a little counterintuitive.

IMO, this is not worth changing. Besides, I'm quite sure it will break
some code elsewhere. Why bother?

  reply	other threads:[~2020-06-08 19:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 10:32 [PATCH] org-element.el: Fix properties being upcased by parser Leo Vivier
2020-06-08 11:59 ` Nicolas Goaziou
2020-06-08 12:14   ` Leo Vivier
2020-06-08 19:43     ` Nicolas Goaziou [this message]
2020-06-08 19:46       ` Leo Vivier
2020-06-08 20:36         ` Nicolas Goaziou
2020-06-12  4:48           ` Leo Vivier
2020-06-13 15:32             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8pt5onr.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=leo.vivier+dev@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).