emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Gustavo Barros <gusbrs.2016@gmail.com>
To: Kevin Liu <kevin@nivekuil.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Repeating task hourly
Date: Wed, 29 Jul 2020 13:29:20 -0300	[thread overview]
Message-ID: <87o8nyffog.fsf@gmail.com> (raw)
In-Reply-To: <877dum5nwx.fsf@nivekuil.com>


On Wed, 29 Jul 2020 at 12:41, Kevin Liu <kevin@nivekuil.com> wrote:

> The graph works for hourly repeaters in exactly the same way as it 
> works
> in all other cases.  It illustrates whether the task was done on a 
> given
> day.

But what will happen is that the task will be both "done" and "due" on 
the same day.  Which face shall org-habit use?  Which symbol?  The task 
will be shown in the agenda, all right, whether the consistency graph is 
meaningful is another matter.

> As Kyle mentioned, I don't think authorial intent counts for a whole 
> lot
> here since the code was last touched in 2009, years before hourly
> repeaters were added.

I'm not so sure.  Take a look at commit be2806d281 "Fixes to the 
consistency graph in org-habit", by John Wiegley, in 2009-10-22.

There the following error check was then introduced:

    (unless (> sr-days 0)
      (error "Habit's scheduled repeat period is less than 1d"))

Considering `sr-days' was then let-bound with:

    (scheduled-repeat (org-get-repeat "SCHEDULED"))
    (sr-days (org-habit-duration-to-days scheduled-repeat))

And that `org-habit-duration-to-days' performs its conversion of the 
repeaters to days with `floor', I'd say it is pretty deliberate.  If 
this was before the introduction of hourly repeaters, I'd take this to 
be even more meaningful, not less.

Best,
Gustavo.


  reply	other threads:[~2020-07-29 16:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 11:30 Repeating task hourly Kevin Liu
2020-07-27 11:40 ` Kevin Liu
2020-07-29  2:29   ` Kyle Meyer
2020-07-29 11:06     ` Gustavo Barros
     [not found]       ` <87a6zi5qgu.fsf@nivekuil.com>
2020-07-29 15:15         ` Gustavo Barros
2020-07-29 15:41           ` Kevin Liu
2020-07-29 16:29             ` Gustavo Barros [this message]
2020-07-30 15:25               ` Kevin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8nyffog.fsf@gmail.com \
    --to=gusbrs.2016@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin@nivekuil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).