emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Allen Li <darkfeline@felesatra.moe>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-set-tags-command deletes inherited tags [9.3.7 (9.3.7-18-g093b47-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20200810/)]
Date: Wed, 19 Aug 2020 00:43:28 -0400	[thread overview]
Message-ID: <87o8n7w8i7.fsf@kyleam.com> (raw)
In-Reply-To: <80a6yry3sg.fsf@felesatra.moe>

Thanks for the patch.

Allen Li writes:

> Example Org file:
> * Parent :foo:bar:baz:
> ** Child :foo:bar:spam:
> Invoking org-set-tags-command with point on Child prepopulates the
> minibuffer prompt with only the tags :spam:
> This is because org-get-tags doesn't distinguish between inherited only
> tags and inherited tags which are also explicitly set on a heading, so
> org-set-tags-command treats :foo:bar: as inherited only rather than also
> set locally on the heading.
> This is undesirable because having tags set directly on a heading has
> different semantics even if they are also inherited (e.g., the TAGS
> special property, or when headings will be refiled to a different
> location later).

I agree, that's undesirable and likely unintended.

> Subject: [PATCH] org.el: Don't exclude local tags that are also inherited
> * lisp/org.el (org-set-tags-command): Don't exclude local tags even if inherited.
> ---
>  lisp/org.el | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

It'd be good to add something along the lines of your example as a case
in test-org/set-tags-command.

> diff --git a/lisp/org.el b/lisp/org.el
> index fb95590fc..49d7d24f2 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -11880,9 +11880,7 @@ in Lisp code use `org-set-tags' instead."
>  				  (org-global-tags-completion-table
>  				   (org-agenda-files)))
>  			     (or org-current-tag-alist (org-get-buffer-tags)))))
> -	       (current-tags
> -		(cl-remove-if (lambda (tag) (get-text-property 0 'inherited tag))
> -			      all-tags))
> +	       (current-tags (org-get-tags nil t))
>  	       (inherited-tags
>  		(cl-remove-if-not (lambda (tag) (get-text-property 0 'inherited tag))
>  				  all-tags))

That looks good as far as fixing the misbehavior you report.  I wonder
though whether there's a deeper org-get-tags issue here worth
considering.  Its documentation says

    ... the returned list of tags contains tags in this order: file
    tags, tags inherited from parent headlines, local tags.

But it's not specified what happens when a tag is both local and
inherited.  The current implementation drops the local tag variant
through its delete-dups call:

     (append (org-remove-uninherited-tags itags) ltags))

I would have expected the local tag to get priority here.  If that were
the case (e.g., something like below), that would also solve the issue
you describe.


-- >8 --
diff --git a/lisp/org.el b/lisp/org.el
index fb95590fc..3dac42b7b 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12310,8 +12310,10 @@ (defun org-get-tags (&optional pos local)
             (setq itags (append org-file-tags itags))
-            (delete-dups
-             (append (org-remove-uninherited-tags itags) ltags))))))))
+            (nreverse
+             (delete-dups
+              (nreverse (nconc (org-remove-uninherited-tags itags)
+                               ltags))))))))))
 (defun org-get-buffer-tags ()
   "Get a table of all tags used in the buffer, for completion."

  reply	other threads:[~2020-08-19  4:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 22:42 Bug: org-set-tags-command deletes inherited tags [9.3.7 (9.3.7-18-g093b47-elpaplus @ /home/ionasal/.emacs.d/elpa/org-plus-contrib-20200810/)] Allen Li
2020-08-19  4:43 ` Kyle Meyer [this message]
2020-08-21  8:39   ` Allen Li
2020-08-22  9:03     ` Allen Li
2020-08-24  2:43       ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8n7w8i7.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=darkfeline@felesatra.moe \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).