From: Ihor Radchenko <yantar92@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org, Timothy <tecosaur@gmail.com>
Subject: Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]
Date: Sat, 01 May 2021 21:57:37 +0800 [thread overview]
Message-ID: <87o8du5zfy.fsf@localhost> (raw)
In-Reply-To: <87h7job5ch.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
Bastien <bzg@gnu.org> writes:
> could you provide a patch for these two warnings for the maint branch?
>> In end of data:
>> ob-gnuplot.el:299:1:Warning: the function ‘file-local-name’ is not known to be
This does not appear on maint. Only on master. The patch for master attached.
>> In org-display-inline-images:
>> org.el:16554:57:Warning: reference to free variable ‘image-map’
Kyle already dealt with it.
Best,
Ihor
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-org-version-of-file-local-name-for-compatibility.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]
From d57d51007392f41645b78a28e8ef14132b42c324 Mon Sep 17 00:00:00 2001
Message-Id: <d57d51007392f41645b78a28e8ef14132b42c324.1619877335.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Sat, 1 May 2021 21:54:13 +0800
Subject: [PATCH] Use org version of file-local-name for compatibility with
Emacs 25
---
lisp/ob-gnuplot.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/ob-gnuplot.el b/lisp/ob-gnuplot.el
index c0a9ff13a..a9b8e65e5 100644
--- a/lisp/ob-gnuplot.el
+++ b/lisp/ob-gnuplot.el
@@ -101,7 +101,7 @@ (defun org-babel-gnuplot-process-vars (params)
org-babel-temporary-directory
"/gnuplot/"
(file-remote-p val 'host)
- (file-local-name val))))
+ (org-babel-local-file-name val))))
(if (and (file-exists-p local-name) ;; only download file if remote is newer
(file-newer-than-file-p local-name val))
local-name
--
2.26.3
next prev parent reply other threads:[~2021-05-01 13:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 14:29 Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)] Ihor Radchenko
2021-04-28 14:48 ` Timothy
2021-04-28 15:31 ` Ihor Radchenko
2021-04-28 15:47 ` Timothy
2021-04-30 7:26 ` Bastien
2021-05-01 13:57 ` Ihor Radchenko [this message]
2021-05-01 14:33 ` Bastien
2021-04-28 21:21 ` Robert Horn
2021-04-29 9:10 ` Colin Baxter
2021-04-29 14:46 ` Robert Horn
2021-04-29 15:36 ` Colin Baxter
2021-04-29 15:51 ` Timothy
2021-04-29 16:04 ` Colin Baxter
2021-04-29 19:42 ` Tim Cross
2021-04-30 7:25 ` Bastien
2021-09-28 5:33 ` Bastien
2021-09-28 17:06 ` Bug: Org mode fails to compile using Emacs 24.5-r10 Max Nikulin
2021-09-28 20:36 ` Samuel Wales
2021-09-28 23:57 ` Tim Cross
2021-09-29 6:59 ` Bastien
2021-09-29 6:58 ` Bastien
2021-09-28 23:34 ` Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)] Tim Cross
2021-09-29 6:45 ` Bastien
2021-05-01 5:08 ` Kyle Meyer
2021-05-01 13:49 ` Ihor Radchenko
2021-05-01 14:35 ` Kyle Meyer
2021-05-01 20:13 ` Kyle Meyer
2021-05-01 20:27 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8du5zfy.fsf@localhost \
--to=yantar92@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=tecosaur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).