From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cPMbJjVF2mAHAAEAgWs5BA (envelope-from ) for ; Mon, 28 Jun 2021 23:55:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gCXKITVF2mDxKAAA1q6Kng (envelope-from ) for ; Mon, 28 Jun 2021 21:55:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F2A5212A8F for ; Mon, 28 Jun 2021 23:55:00 +0200 (CEST) Received: from localhost ([::1]:59228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxzDY-0000ri-1J for larch@yhetil.org; Mon, 28 Jun 2021 17:55:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxzDB-0000rV-SQ for emacs-orgmode@gnu.org; Mon, 28 Jun 2021 17:54:37 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:43998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxzDA-00068B-6k for emacs-orgmode@gnu.org; Mon, 28 Jun 2021 17:54:37 -0400 Received: by mail-wm1-x32c.google.com with SMTP id p8-20020a7bcc880000b02901dbb595a9f1so988868wma.2 for ; Mon, 28 Jun 2021 14:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:mime-version; bh=m+sb8wnw29t13Ts+TQ1zoZGLPeqxZP7O33KVCRTvbwI=; b=VAUe8PgRVlvI6R3IYFfBiYETihHq6oGIYZiUSbZx8chVnSe/iD5zI0ArEnrDr6Tf6H S3JFDY5liGYT3NL7vZSFS0eIy/mVwRqZLBNVqKuY78/d1r+lXONgBKnHogdg/W0/VKLk qM634N5Wr2PiWx/FQKDACJcvBVFfKLWH1JUCLVsaBIAIJFwfhVKQ9ZVRCjLszPhVRdcC 3ALyL4z9TmJN6IWcOV9hhQW9jK4aP1oJQ099gMMLpKMF/krA+x8KF/hIOrUG8iY3Id+M ObmQ2KlA/iNWwSmxEmopG813vO2jGZOENjYHL36tWCvdaF7rZkp4GDvmcOacAr+4Ffrj 3Yrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :mime-version; bh=m+sb8wnw29t13Ts+TQ1zoZGLPeqxZP7O33KVCRTvbwI=; b=AnKO3R6T610pdS0wgAAWtrsx7evMTM61lC2WpyCUlXPw+AMdDs6sBtqAbS/aqqVmxE L1gGsa9J3K/LGBJl+2DSIbu4kqs8NTveibp/Q4mSJYSGpqp5N2+OD/5YQbNVNJPUYvvA YGeDWot1nub+xWgX5eIy6xtAUllU6UHUs/RA2/BGJJLT/iPKpE1dIPc6FyUJjXx7zpHI 9x9PfdDtY2qNg4WfHiWqbyokh7Cmqcq/uNQen5NcvSc4+W7SAlEeiTx8F/1Q/6H2gOCz pJhkySIX8Vd6TROwnCAm4otY/VrDw0n//uNvDfC0mJTDzi+BI7rK8oNasU8dHRU80b7u SpnA== X-Gm-Message-State: AOAM533Ypob576ClyMaF+WnlGYui8h0MlRBb73th0fOvKzAgd5nND5Du KstNDT0fQVdjy1wwYGXKl6w= X-Google-Smtp-Source: ABdhPJyHro+hEWHDfmg3QAd5ULF1Sv04f18HG3aLy7FTKkEDAUHj1UmI0UhsF4rNSWDI14CViCMlng== X-Received: by 2002:a05:600c:190a:: with SMTP id j10mr28800313wmq.44.1624917274189; Mon, 28 Jun 2021 14:54:34 -0700 (PDT) Received: from freegnu (82-64-129-7.subs.proxad.net. [82.64.129.7]) by smtp.gmail.com with ESMTPSA id m7sm16714130wrv.35.2021.06.28.14.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 14:54:33 -0700 (PDT) From: Jeremie Juste To: Jack Kamm Subject: Re: [PATCH] ob-R output file with graphics parameter References: <8735t8nqlf.fsf@gmail.com> <87pmwbty75.fsf@yandex.com> <871r8n1ban.fsf@gmail.com> Date: Mon, 28 Jun 2021 23:54:32 +0200 Message-ID: <87o8bpbqp3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=jeremiejuste@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Baxter , "Berry, Charles" , Org Mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624917301; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=m+sb8wnw29t13Ts+TQ1zoZGLPeqxZP7O33KVCRTvbwI=; b=ScpDNh9y5FZeWQ2HJB+HIIx5J80x8zSOIUsBcKI0pq1DwCo8My82Etow04TBtSJF3V6RRU 5xkPTgG1mAQ732VAhiykDjkp3qs6yNmadWPFgVQRIJr3RRbQheJtBJeYWzuR4vYfmYHP4f r0J8QbY0FygcVxYoHuEyHXqBIk95Ps7UpwjXoQsp7Q6QnLeCiAB4b2FhCXS/2ZHZw7v1G4 38EaIfjW7k/3aNVnveNVwBgg7F1bjbWUV9jLMs7ye7PCKMkKDdaqTEPCmScVdYAC62VP8d IRViqkKmcYUuga0IHR90EyDsFoA2lrEo8SfbIP28t67SMcQxdYtYrPrO2Tu/HQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624917301; a=rsa-sha256; cv=none; b=E37dD2ifiXflRBDs/0F+rjklPuKWQOvEHI9vknZYbdU8Fs2ZntOsavR33BIOhauSHpgLRU cm/AvHWQL6erI3kGCt8ey2Jyn5luzi8CgXJN4WL+mrYmgBuatyG/rBPiriNRO0n34ql/0e vhYTcY7AJsC14iFdiIqZMQbOvk0YIphm3pmh9XgutK5xXhz/T+t7VGIFG2ja5lRJCxzZo2 6ybJse9f5BGZLQp7QoXpBpbpBIMVBw02rY+Sat0pZAE2Dr/IH3ieRXoXzq7pdAVpfGoEP+ Rtx7IvcjXRjQDwzbCLCSUJo2mNhWa+Ay0FNivxtAFD4uChbDRGXZwXpwBRZJwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=VAUe8PgR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=VAUe8PgR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: F2A5212A8F X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: y3R+R+NBBQWN Hello, Sorry for the delayed reply. On Sunday, 27 Jun 2021 at 10:12, Jack Kamm wrote: @Colin, thanks for your feedback. I have to confess that I didn't know about the second file parameter at all until I provided the patch. I just discovered main branch works with the second :file specification, by chance just before your mail. I have been led into the wrong direction trying to get back the old specification for graphics link. #+BEGIN_SRC R :results output graphics :file test.pdf plot(1) #+end_src The documentation about this part is poor and I must have missed these dicussions on the mailing list. So all this time I lived without the graphics link. ;-|. Now that I am back on track, I will check how well the current version works particularly for remote connection. If it does the patch will be redundant. > However, I tested Jeremie's example on latest org master and it also > worked fine for me, also on remote sessions. @Jack thanks for your feedback. I'll improve my style. > > The requirement for a second file parameter was added in Org 9.3 to > support the use case in this thread: > > https://orgmode.org/list/3ac2f42a-8ff2-1464-fa36-451e2ef0eacd@pressure.to/ > > But this syntax is annoyingly verbose for ob-R users, and also broke > lots of ob-R examples prior to Org 9.3. > > A simple fix might be to have the "graphics" flag implicitly add the > "file" flag as well. But we would need to first check that this doesn't > break other use cases. I do agree with this solution. If the current specification works, we could make it easy for ob-R user by implicitly adding a file flag. But as far as I understand, the change will have to be made in ob-core.el. > >> Subject: [PATCH 1/4] ob-R.el: Remove redundant argument to function > > I think it would be better to squash these changes into a single commit. > Thanks again for the feedback. Best regards, -- Jeremie Juste