From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uDzJLZY3ZmHzcAEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 03:34:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GKl5KZY3ZmGXXQAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 01:34:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E740D784 for ; Wed, 13 Oct 2021 03:34:13 +0200 (CEST) Received: from localhost ([::1]:40988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maT9n-00059l-9X for larch@yhetil.org; Tue, 12 Oct 2021 21:34:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maT9O-00059F-T6 for emacs-orgmode@gnu.org; Tue, 12 Oct 2021 21:33:46 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:56226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maT9N-0003qW-71 for emacs-orgmode@gnu.org; Tue, 12 Oct 2021 21:33:46 -0400 Received: by mail-pj1-x102f.google.com with SMTP id om14so944774pjb.5 for ; Tue, 12 Oct 2021 18:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=DdRb9GS9tVcbYvFzMf4IcTL9ioF7umf6/InU+p9bCUU=; b=emd19SQI8zQh0QYZaTQ/Q2LcVmHMWwPtBa+4rpSwXm3sw63QbAH90l8zuxgkBcr80/ Nkt/eUy3IazroofPzo/lzKW8aIbP7Pq+o16HzLj83HJzuO24ikPn4MFIL4J+ogHiKxly AZNHqlw+BiOnQFwOX/TES6Tm4EMDfw33oW+j8rVADMF+EUFOgk+Lj2Mv/ikPK3icsQY8 RWtpurmGdPQxrUA6Ehw74DdffPuZYTP59tD9qNRaF5WY9kTOFFTpCivZdJ9eAUasMQwq qmSxf47pchmBtW/rViYtyYkvcEHIUEK/jgfZtwBmyD+m+hnCrHbScWjX3oRxNEJiMEmV lj3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=DdRb9GS9tVcbYvFzMf4IcTL9ioF7umf6/InU+p9bCUU=; b=e1ZWTYhz/Se64BcRp2B4e1T/0aKdEdquSbEkNTl2NkGtW4GxGgkxSFCW/zHEiG+Oaj EKPp7Ydeuz5kuBlJjPnAe7hVYPRdcMUxYIgycXrJp0hw7GFr6pdOeQmiQbs9dkuKWGkz MS+9q0DvFbFrfP3N41rewrVFsxtyTY6HQUESBZFU+1lT66kPlbxnBKo4ZqY0nE7fz+xy 4GjZilfm7tuTaflOaTNgH2p8GgRja/p1dT2Zg/etQu43hIsLj1T6oI0A9xxt8oQAKd3v 2H8uvNtIeGNJhWWPWpLLr1dbWTWRt5jK1ZNheOSfLYFTsIz2a++yomOfHhAF59KtUPLz iPkQ== X-Gm-Message-State: AOAM532Tk0MiyXh1dmiHgtE82jxUkJYltQiPHurY8N37asZX7bR37yZj 6tUwq6V1kGnLSFErazO3R5c= X-Google-Smtp-Source: ABdhPJyPW9UtWgORWDAEGXGQPLhek9e2pESsUNjeLocCBlyK3Z64jXE38BgjoD850eraObfP4xE3kQ== X-Received: by 2002:a17:90b:1105:: with SMTP id gi5mr10316088pjb.100.1634088823717; Tue, 12 Oct 2021 18:33:43 -0700 (PDT) Received: from localhost ([103.125.234.161]) by smtp.gmail.com with ESMTPSA id p30sm186500pgn.60.2021.10.12.18.33.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 18:33:43 -0700 (PDT) From: Ihor Radchenko To: Marco Wahl Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken In-Reply-To: <87czoaug5x.fsf@gmail.com> References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> <878rz3ddet.fsf@gmail.com> <87czoaug5x.fsf@gmail.com> Date: Wed, 13 Oct 2021 09:35:03 +0800 Message-ID: <87o87tso54.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=yantar92@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Nikulin , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634088854; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DdRb9GS9tVcbYvFzMf4IcTL9ioF7umf6/InU+p9bCUU=; b=Cwx9nXqfNc5lWJzZUEPswcdWOvj+NrfgzQyH5+wo09ipx+3viPcy2473S2P3S6vGcfOHO5 ocyXOyCyVP781Ui1rTNg7hUNBhGG0y9zmzW/GkJaVbDLp3AvyIu6ibcFrc08tDwfZmYtqH w40/IkOmbrnyakkwefxRXgG73JwjESalEtEXq/d6If0Q+dOk0mVo13ulSagBkTWXhdn3HA LeLMwq4+sYjczr5B7HcXmqM327YAVdYbiTY73CjLREXoOWj6qS0iXb1+uq5mZ1aeT4OTXC jG22aqH9bJX5vsC07QOfJmHjAtV05jyC/bi7scrljBvwVV04/LRHTj5I6qwldQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634088854; a=rsa-sha256; cv=none; b=X/xGLZpO1hd9y90eFliRf9YPZlZXVFOmGtJxY5EC+xHtnKx0jmbqHusLCPixHsJ7XQxrOi 1p9JJ7zUieN+qT7UvlYvSqJ9buHx+hEi6p1PmYsjqORBCfdx5t949Ess7kmIpCB6fy+oxA gtX7zYpe1iZ5psnNlC+FR06yfT/sAaeFzESKTa7s1b94PFmpft6gDrwB05zt9H2oOHXhjv WkCS/fSzxAtgcLIcDBq403+1jCtK/MRn81xfYRZmoW+ArQJFS1F0U4xN8EIK9i6N794VUf wu4tj5x3b3mep+rtOviNqprlg4olHl5xj9jCSp97gPhEr5aqx5u3ojfPPoUVPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=emd19SQI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.01 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=emd19SQI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E740D784 X-Spam-Score: -2.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: U2tLGwTxGCsX Marco Wahl writes: > My feeling is that the "protection" is good intention but brings more > harm than good. I think it's not a good idea to enforce a certain > window setting. I guess the knowing user has an easier path to fine > tune the org-goto user interface when there is less "protection". I fully agree. That was the motivation behind removing dislpay-buffer-alist in 399481bad1. It is indeed not a good idea to overwrite user customisations. They can be deliberate. For example, see https://orgmode.org/list/87h7ij12t8.fsf@localhost Max Nikulin writes: > However current version of macro does not protect against > > (setq display-buffer-base-action > '((display-buffer-reuse-window display-buffer-pop-up-frame) > (reusable-frames . 0))) > > The example is taken from (info "(elisp) Choosing Window Options"). I > have no idea if such customization can be considered as shooting a foot. display-buffer-base-action, if customised by user, can later be fine-tuned using display-buffer-alist. If necessary, the user can easily add org-goto popup as an exception. At least, it is my understanding from reading docs. However, pop-up-frames and pop-up-windows are different beasts. They cannot be fine-tuned by the user to not affect org-goto. AFAIK, the only way for the user to overcome the problem would be advicing org-goto. > Summary: The org-goto interface today is somewhat broken. I vote for > taking the occasion and kicking out the macro org-no-popups entirely. > This way the org-goto interface is functional AFAICS. If problems occur > on that path we'll take care and action. > > Do you agree? My second version of the patch also fixes org-goto interface :) On the other hand, kicking org-no-popups macro completely may be an option. pop-up-windows and pop-up-frames are obsolete and should not be used anymore. Also, a compromise could be changing org-no-popups to just (let (pop-up-frames) ...) WDYT? Best, Ihor