From: Marco Wahl <marcowahlsoft@gmail.com>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix parallel build failure for Texinfo manual
Date: Tue, 21 Dec 2021 21:34:42 +0100 [thread overview]
Message-ID: <87o859bst9.fsf@gmail.com> (raw)
In-Reply-To: <spsoqh$5dr$1@ciao.gmane.io> (Max Nikulin's message of "Tue, 21 Dec 2021 21:37:03 +0700")
Max Nikulin <manikulin@gmail.com> writes:
> On 21/12/2021 19:48, Marco Wahl wrote:
>>
>> From my point of view using singuar targets for org.texi and
>> orgguide.texi is the clearest path to go.
>
> It matter of taste. I do not like code duplication.
>
>> I already committed a fix along these lines. (Hopefully it's okay.)
>
> Thank you for the fix.
>
>> Please let me know if I missed something.
>
> I do not see any really serious issues. However there are room for
> improvements
>
> %: %.texi org-version.inc
> $(MAKEINFO) --no-split $< -o $@.info
>
> likely should be
>
> %.info: %.texi org-version.inc
> $(MAKEINFO) --no-split $< -o $@
>
> Org files have
>
> #+setupfile: doc-setup.org
>
> but there is no dependency on doc-setup.org in the Makefile
>
> I would prefer to see names of output files specified in the Makefile
> rather than in org files:
>
> #+export_file_name: orgguide.texi
>
> Ideally it should be a function with input org file and output texi file
> names as arguments. Currently it is a bit puzzling while reading the
> Makefile and .el, it is unclear why name of output files are different.
>
> Since nobody complained before, such issues are not urgent.
I think so too.
If someone finds the muse to deal with any of these issues she might
give it a go, please.
prev parent reply other threads:[~2021-12-21 20:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 16:44 [PATCH] Fix parallel build failure for Texinfo manual Ulrich Müller
2021-12-20 21:39 ` Marco Wahl
2021-12-21 7:29 ` Ulrich Mueller
2021-12-21 11:21 ` Marco Wahl
2021-12-21 12:17 ` Max Nikulin
2021-12-21 12:48 ` Marco Wahl
2021-12-21 14:37 ` Max Nikulin
2021-12-21 20:34 ` Marco Wahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o859bst9.fsf@gmail.com \
--to=marcowahlsoft@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).