From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mG6/OSkZ32IaQgAAbAwnHQ (envelope-from ) for ; Tue, 26 Jul 2022 00:28:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CAjaOCkZ32LrWwAAG6o9tA (envelope-from ) for ; Tue, 26 Jul 2022 00:28:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 367FD2E5FE for ; Tue, 26 Jul 2022 00:28:57 +0200 (CEST) Received: from localhost ([::1]:45538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oG6ZM-0007nH-AW for larch@yhetil.org; Mon, 25 Jul 2022 18:28:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG4Kq-0004bM-PA for emacs-orgmode@gnu.org; Mon, 25 Jul 2022 16:05:50 -0400 Received: from out1.migadu.com ([91.121.223.63]:47141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG4Kn-0005eP-Ph for emacs-orgmode@gnu.org; Mon, 25 Jul 2022 16:05:47 -0400 References: <20220719231520.100206-1-joseph@breatheoutbreathe.in> <87bktduydf.fsf@localhost> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1658779541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LaiacQOcxJ/tzaA2FKvuafY2cbcMb3NRrr94BBREreE=; b=m3aKh+xkaLfJTcvZpKsQlqOYS017ncDapE20MD/76DUovScfDRHajoU5SLl5qxGaDe6+Zf p75mnYd7BoWrau/bJEgwXEMnV5r4c94zwy9V6Qek9GEqup8SQBo5peTVOOCUmsypSxmuOX hk/qutXSCctN1eSJLUNHDl+JPUQLf80= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/ob-plantuml.el: Insert results in buffer Date: Mon, 25 Jul 2022 12:52:53 -0700 In-reply-to: <87bktduydf.fsf@localhost> Message-ID: <87o7xdot4d.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=91.121.223.63; envelope-from=joseph@breatheoutbreathe.in; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 25 Jul 2022 18:27:39 -0400 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658788137; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LaiacQOcxJ/tzaA2FKvuafY2cbcMb3NRrr94BBREreE=; b=KzENBlvYvev8NSbCzRUTkuoxxAHrlaYQ2YgFjLKG1gOjeISQSjjynWSWhjVdvrhH+Z6lOG B/AZ5rPFsCgt9o0DaQhE7W+iaUGaW6wiRzpwBSMK7kwpMNwOELBRB7NFgRdhfFDzhQjxBn RWu8mPhY1b8fUiwZStRhSbrddAsqTHH8pdwyY/URAYwwXibA+VclFPyGY6vg/FDQRie8fn iV9w1wh5fcIb6rm40MTlInbN0SftVwFa0zqb5xCEnloL882932pHUuXunYeN8gke2s51ln LQjiuLrnorUctHTE9Lyku9OE6P7vs1hBY0jtWBo+G4o82FuqeGYBc0Dirm/3oA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658788137; a=rsa-sha256; cv=none; b=lA0hu74xDa2QptUqsRiVrAFjJ+i9PcHvV6h7GYB6l+D/fGmroAr7hlA8EaKfmhIH5JIShh nnY6yWg/0+cT33GZYaRzZd9d7Hx28WkaNQ7wDFfEWETgRt2wQxf4TEvLxCzewnLFtHF7VU WjrmKt6JVWa2JFX05ucj5d9Yvsb2veGb4UTAqPb7a8KZhG/q6T2AxedILB2xF4bB2I4vh0 tgF4wdorHK9mhX5vMrMdvNLXHO6HQN5zvKWaGDangoOkgjEBmjuhtO0duYu1zwf1XNxumt cwV84tTchHfTgtTwxvwGdndCtkXFnu+iMosimkLLkkxbvtisDTpNNalCpxvXhg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=breatheoutbreathe.in header.s=key1 header.b=m3aKh+xk; dmarc=pass (policy=quarantine) header.from=breatheoutbreathe.in; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -9.23 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=breatheoutbreathe.in header.s=key1 header.b=m3aKh+xk; dmarc=pass (policy=quarantine) header.from=breatheoutbreathe.in; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 367FD2E5FE X-Spam-Score: -9.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: bhJHHaJstE9T Thank you for your feedback, Ihor! > Most importantly, the patch does not change the default value of > org-babel-default-header-args:plantuml. :results header arg is set to > "file" by default. Yes, I noticed this issue also. > The solution will be simply removing the default :results setting. I think you're suggesting something like this: (defvar org-babel-default-header-args:plantuml '((:exports . "results")) "Default arguments for evaluating a plantuml source block.") With this change, if you *do* add a :file arg, like in the following example, then no output will be produced: #+begin_src plantuml :file "this.png" Bob->Alice : Hello1! #+end_src #+RESULTS: which is also wrong. What would the code look like if we wanted to change the org-babel-default-header-args:plantuml variable inside the org-babel-execute:plantuml function based on the value of the params arg? Or perhaps you have a different solution? Once we straighten this issue out, I am happy to resubmit the updated patch with your suggested style changes. Warmly, Joseph