emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: "András Simonyi" <andras.simonyi@gmail.com>
Cc: emacs-orgmode list <emacs-orgmode@gnu.org>
Subject: Re: [RFC PATCH] oc-csl: Add support for title, locators and bibentry styles
Date: Tue, 09 Aug 2022 20:03:35 +0800	[thread overview]
Message-ID: <87o7wt4oa0.fsf@localhost> (raw)
In-Reply-To: <CAOWRwxBBqH8K02A_3euik=ntjJxyBWNU=+3n=TuEwNUzxhC2MQ@mail.gmail.com>

András Simonyi <andras.simonyi@gmail.com> writes:

> Dear All,
>
> On Sun, 7 Aug 2022 at 11:45, Ihor Radchenko <yantar92@gmail.com> wrote:
>
>> LGTM in general, but please add a proper commit message.
> [...]
>> Also, it would be useful to explain a bit what bibentry stands for.
>
> thanks, I've attached a new patch implementing these recommendations.

Thanks!
Applied onto main via c7d484130 with minor amendments adding "." at the
end of comment sentences.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c7d484130c19c0a1fe172a8d76b9cfc296d2ed54


-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92


  reply	other threads:[~2022-08-09 12:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 11:14 [RFC PATCH] oc-csl: Add support for title, locators and bibentry styles András Simonyi
2022-08-02 12:08 ` Bruce D'Arcus
2022-08-07  9:46 ` Ihor Radchenko
2022-08-08 17:01   ` András Simonyi
2022-08-09 12:03     ` Ihor Radchenko [this message]
2022-08-09 15:38 ` Rudolf Adamkovič
2022-08-13 12:30   ` András Simonyi
2022-08-13 14:01     ` Bruce D'Arcus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7wt4oa0.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=andras.simonyi@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).