From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oHl7LvcEQWOXLAAAbAwnHQ (envelope-from ) for ; Sat, 08 Oct 2022 07:04:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aE12LvcEQWNSaAAAauVa8A (envelope-from ) for ; Sat, 08 Oct 2022 07:04:55 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D85BFD09 for ; Sat, 8 Oct 2022 07:04:55 +0200 (CEST) Received: from localhost ([::1]:54226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oh218-00058k-PB for larch@yhetil.org; Sat, 08 Oct 2022 01:04:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oh1zr-00043K-0Y for emacs-orgmode@gnu.org; Sat, 08 Oct 2022 01:03:35 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:39690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oh1zp-0000FU-94 for emacs-orgmode@gnu.org; Sat, 08 Oct 2022 01:03:34 -0400 Received: by mail-pl1-x634.google.com with SMTP id f23so6205720plr.6 for ; Fri, 07 Oct 2022 22:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZkT66WJZyal7sizz44XH4fftfkMLC4Xrf2tkuX+vNaY=; b=GFWql5XoOCLcuXKl8su1jV2jZUXe6fB/T9Opw9Hqk6jbEdp3GTmtoj7xaSB/syYARk pdfJa53j3w0VybZAqsLD0d7StvfGoQHKEVipCnGJwhWGbKvQ1odWIpYwFrqGKgZmbr7i VkhUsYrvKWyw9+FB2/r0TEK7Aehu5PmhcjOcsJ43ZkeuTPv/RlX0Mfhd83m6IB9ZCLRE nrEoJW4rjo+XrE9dVl96GIQVhYSpf6+3BiILA681chD6hYzNNU/Dj07FNBOOErjvWBzd IRxICzS2Xla3eR5pIk4Lge2mY4pOLKfKDQTtaRE6Oh8n7y+JPIMf+tBJ7nNZS7panwFw 4nkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZkT66WJZyal7sizz44XH4fftfkMLC4Xrf2tkuX+vNaY=; b=VJDE4p6gHa21h/rRhU8BUw4Xoxddf9YC0w1Lud7bqWBdbrUU30vgWq1dMgvYteDumr cAoi1AQLLKgpCnw9kcLvEx36KA9lev/eUk/pn2bHVZrRPDNBIvP+VEoI62bqqezudCCA lBb+6ZywpB1FV5kI7fr9bFCb6KHthat3TtXjcp5wbc4sANURLdA0mh6mkVaEUGVhLNRH b7laZEIJn08yrR94n7gTrICtUEaC/E4prOgxqbnOXx1BuUphQ62KrnZXOlHsso3uoiSf U4Kc2ftNctYD/ovrKPmCNUo1KDVKgku5VTlAsozfg88bGz3T11VV3Pp1RYFn/Jg8yMr7 dAgg== X-Gm-Message-State: ACrzQf0zssdO+EfDTftzQzKocF2JfbyPg8EY9C48u5eMC+s6+TDV+A4u 9j0LfLOMua7sMx7tVPyBAH0= X-Google-Smtp-Source: AMsMyM7GTrv5doTpCdK46JlHuMoEWtEHL3f6DxA053e38v6UOvOKWGWS0xnhYHEn5OuOlRiKuROyKA== X-Received: by 2002:a17:90a:a788:b0:20a:20f5:4f15 with SMTP id f8-20020a17090aa78800b0020a20f54f15mr19975908pjq.91.1665205411581; Fri, 07 Oct 2022 22:03:31 -0700 (PDT) Received: from localhost ([1.83.155.53]) by smtp.gmail.com with ESMTPSA id x6-20020a628606000000b005601e974993sm2528603pfd.25.2022.10.07.22.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 22:03:30 -0700 (PDT) From: Ihor Radchenko To: Kyle Meyer Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [BUG] Re: 98e168b48 Add compatibility wrapper for string-clean-whitespace (Emacs 26 compatibility) [9.6-pre (release_9.5.5-920-g057193 @ /home/yantar92/.emacs.d/straight/build/org/)] In-Reply-To: <87wn9baby0.fsf@kyleam.com> References: <8735c01aho.fsf@localhost> <87wn9baby0.fsf@kyleam.com> Date: Sat, 08 Oct 2022 13:04:22 +0800 Message-ID: <87o7umlxd5.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=yantar92@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" Authentication-Results: aspmx1.migadu.com; none X-Migadu-Scanner: scn1.migadu.com X-TUID: TfbbiSFWBZZa Kyle Meyer writes: >> It is available in Emacs-26, however (require 'subr-x) should be added. >> >> There is `org-trim' and despite it is less generic, likely it can be >> used if subr-x is avoided for some reason. > > Ihor, sorry for overlooking that. As Max mentions, indeed string-trim > used to be in subr-x. It's been available since Emacs 24 and was > relocated with Emacs 28's a4ececf004e (Move string-trim functions to > subr.el, 2021-03-24). > > I won't be at my computer much today or tomorrow, but, when I get a > chance, I'll plan to add something like > > (eval-when-compile (require 'subr-x)) ; Emacs < 28 I am a bit confused about usage of subr-x in Org. I do recall Nicolas repeatedly voicing against usage of subr-x staff: https://orgmode.org/list/87wo4en8qk.fsf@nicolasgoaziou.fr >>> 2. we don't use "subr-x.el" in the code base. In particular, it would be >>> nice to replace `when-let' with `when' + `let'. This change costs >>> only one loc. However, he did not mention the reasoning behind this, except a single massage I was able to find: https://orgmode.org/list/8737t0b2c9.fsf@nicolasgoaziou.fr >>> ... you are not using `if-let' anywhere if this patch. Besides, we still >>> cannot use subr-x, since it is a 24.4 library, and, AFAIR, we didn't >>> drop support for 24.3 yet. If supporting Emacs 24 is the only blocker for subr-x, it should be safe to use it. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at