From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ACjaIPtZRmPzegAAbAwnHQ (envelope-from ) for ; Wed, 12 Oct 2022 08:08:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2J0FIPtZRmPCFAAAG6o9tA (envelope-from ) for ; Wed, 12 Oct 2022 08:08:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 410563E581 for ; Wed, 12 Oct 2022 08:08:59 +0200 (CEST) Received: from localhost ([::1]:40964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiUv6-0006ys-Sh for larch@yhetil.org; Wed, 12 Oct 2022 02:08:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiUqm-0006xb-GI for emacs-orgmode@gnu.org; Wed, 12 Oct 2022 02:04:24 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:33421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiUqk-0007N1-5h for emacs-orgmode@gnu.org; Wed, 12 Oct 2022 02:04:15 -0400 Received: by mail-pl1-x631.google.com with SMTP id 10so15393173pli.0 for ; Tue, 11 Oct 2022 23:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=IkgPHR17TzxZoBXCBUPjpOsqVya8e4sRpRIugAzmQ+Y=; b=Pvz1O77OC/7POaJ9v+U49P8R6ekUM3QrRWg27nvk7oH+p1CKH9xa6OMMr8kTQ56bH9 Lr6vaGNi2WaaSOUqIp9wKdElaRuXwE+xEgq05/NSBQvQeu0CFpVytTJvxvW+oIEVhMig /kMAlMRKTBdm+QxrcqnIDJoVrW2UI9yUbwDXxCtRus0gm1Yv0LcOgqMF447aXWFvksRO GLr5fkf8LcqaWYQuT5OtZEk/usXxhbEt+KktPnZe3bRb4rEoge0INGmX5KMPaArVUloT 2yzyrCZy0HFIeMisNmItF1bk0RYMdIhj4w538zv9jZXXJjzJ3oJCNh0FRtZqCI1OqOmX SeFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IkgPHR17TzxZoBXCBUPjpOsqVya8e4sRpRIugAzmQ+Y=; b=w4IwwzXMAoD4ja4ZwSbcOuGkRzB/ctY+uqavP6tiDJ89bO3gU24l/q5GidnWPRK5l2 +32GB8xPItLOlmzXx74PLi4h6sDWmnKNrNpRnlYqNfbTmIDUWZUxDLzWQBN8xMtzjHZe XWcsdMnJP73WowvavMdHtNlIJ62X5foGXq1j5HaF2hddJSuZOtuHsZqIXD9qk9cDONQC 6kuCzTYe/ZM5O7qdMK/zvJd2qG3M1RTTbMJGBklUExPzWMDbVjxRc5dhMxKk268HXq7o A1ypIwMAo9Vxa19J7cy5Lr1dVWFLEKqeRuMno9gGoSOLiHh3gsqTxSYJJRTkfG/GDxWt /vwQ== X-Gm-Message-State: ACrzQf0eALQKCA4WOHkOWeff3DLgsGc79Pw25bM1WwS28kOLkpiF9Izy qq3MIL/IFJPiCJByLaCHnog= X-Google-Smtp-Source: AMsMyM7nl50TJXmeTXyYfi/aRREId5mmP7+0HNxX/eyiFFLaNWmF4hQPEmKMbCDV2Fa+EFkq5Gjpcg== X-Received: by 2002:a17:90b:f18:b0:20a:9d2b:b75a with SMTP id br24-20020a17090b0f1800b0020a9d2bb75amr3221662pjb.95.1665554652687; Tue, 11 Oct 2022 23:04:12 -0700 (PDT) Received: from localhost ([2409:8970:af2:32f:6c23:3ad5:f37d:541b]) by smtp.gmail.com with ESMTPSA id z26-20020a62d11a000000b0053e5daf1a25sm10137843pfg.45.2022.10.11.23.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 23:04:11 -0700 (PDT) From: Ihor Radchenko To: numbchild@gmail.com Cc: Chris Clark , emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix void variable error `cider-buffer-ns` when specifying :backend header argument In-Reply-To: <63460e17.050a0220.1ff7f.4bdeSMTPIN_ADDED_BROKEN@mx.google.com> References: <875ygtqw77.fsf@localhost> <87fsfvul02.fsf@localhost> <63460e17.050a0220.1ff7f.4bdeSMTPIN_ADDED_BROKEN@mx.google.com> Date: Wed, 12 Oct 2022 14:04:56 +0800 Message-ID: <87o7uhshkn.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=yantar92@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665554939; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IkgPHR17TzxZoBXCBUPjpOsqVya8e4sRpRIugAzmQ+Y=; b=r6SqWnS0olQR90GlqVMN9+UbpBnd8hGIV8U+3LbkNt/ioqTLRRthjdvWnXZIQi79BzO/vA roZ9mZDcPZaALyFt5Zn8f14HmEXz7Rpqu5BJ90VWUqTjkpcuQsh6Njy0RuiD8iAz7IltO+ h3mAkdSc3KpQCksSahhy5mUOhXTGUEDM7uJ/6fmsfVRvw2W4UTTeAhx3gibYNv5wB8zoyp 4fvX8fXeySJRi7Aue+hc619g3yWfvwMUKXsUvudxjT/9miyC7dHSDN8GFMZJqyHHV2aH12 vHs0Thy1EwVb26IUFyiLZX93za4iC/gYr/w3b5JQkhYVDwxgPmnZnDHysL/d9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665554939; a=rsa-sha256; cv=none; b=l5q9kG36GAD99TZW0mK0qe7QLdtR7hBIBZsJ3WkHTXaRxWSk201fsteR8KLClPelRJGm6K R3V2AbWPeAva+qxVynzfwQhEUaVNPuLKX4djrD/c1guRBPN0TqD4C9RMbcs0V4CKLIqjLa 7MlY/oggdh9UI35Ys2/khKzxr855lC/HMn0KE4yPmy/v+epd+tUaUcg9FY2ulS0AswiM61 X21a4C70C6mzAmBxTMxA+Mz5cf2MLOSF0s4u+gAeUj6g+KnuaYdVvNJMRarp3Iok+oDBJ8 j7nTNCcRk8EVEgtwBZWTMg2kAGwpRlgiviTlJBLAgDiqIVL3N0HujTDKxP9V1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Pvz1O77O; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.40 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Pvz1O77O; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 410563E581 X-Spam-Score: -8.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZGsfIugpNaZv "Christopher M. Miles" writes: > After updated to latest commit, I found error, > > Reproduce: > > When I specified the `:backend` header argument: > > #+begin_src clojure :backend babashka > (+ 2 4) > #+end_src > > I got error: > > #+begin_example > void variable: cider-buffer-ns > #+end_example Thanks for reporting! > Here is the patch fix upper issue. > > (let* ((vars (org-babel--get-vars params)) > + (backend-override (cdr (assq :backend params))) > (ns (or (cdr (assq :ns params)) > - (if (eq org-babel-clojure-backend 'cider) > + (if (and (not backend-override) > + (eq org-babel-clojure-backend 'cider)) > (or cider-buffer-ns > (let ((repl-buf (cider-current-connection))) > (and repl-buf (buffer-local-value What if backend-override is 'cider? I suggest to let-bind (org-babel-clojure-backend (cond (backend-override (intern backend-override)) (org-babel-clojure-backend org-babel-clojure-backend) (t (user-error "You need to customize `org-babel-clojure-backend' or set the `:backend' header argument")))) Just like in `org-babel-execute:clojure'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at