From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ELmlGJlruWNiVgEAbAwnHQ (envelope-from ) for ; Sat, 07 Jan 2023 13:54:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cJC+GJlruWM29gAA9RJhRA (envelope-from ) for ; Sat, 07 Jan 2023 13:54:49 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2AB8C178BE for ; Sat, 7 Jan 2023 13:54:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pE8iU-0005iE-Qr; Sat, 07 Jan 2023 07:54:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE8iS-0005em-LJ for emacs-orgmode@gnu.org; Sat, 07 Jan 2023 07:54:28 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE8iQ-0003F8-GA for emacs-orgmode@gnu.org; Sat, 07 Jan 2023 07:54:28 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C60122402E9 for ; Sat, 7 Jan 2023 13:54:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673096063; bh=oFPcTl6gc5TIQ8nYStjTLVB4QmFRfKjN8QrCmPWDYu0=; h=From:To:Cc:Subject:Date:From; b=FhVnuLpgLTfXwdOXEaRPf3uS8xyU4rxOPY/ASWwMVG74lJO3lxSbd9hgzat7Vj3Da NSvhjT9xm9yq+tj+WP9xSjh6rSVWuS9GTHSTePEZEyKgt26Ua5ERmFH7P+4jugY6AE tc8qCT+EJ8AJxgDOl4ffepOaA+/fJuPaRWqBlfto8p37RWnajIE5269AEb8GsHx5E7 M0rc4S+pYK8ELCJGSlmQ63X9wJCZIxipJsUQlH3/H6fxi+RtBoDz89cGkuYPozX20y 5KjXhwN2LOGzUaRyXnUKI8zrB8DTzmk4k2IEOWRX/ORYTl56V4SP9dXTwN0k5/9Uf7 bm2y+eof0LRpA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Nq0XD58NFz6tnc; Sat, 7 Jan 2023 13:54:20 +0100 (CET) From: Ihor Radchenko To: Ilya Chernyshov Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-datetree.el: Allow datetrees with TODO, priority, tags In-Reply-To: <87pmbsrfak.fsf@gmail.com> References: <87zgaxfgi3.fsf@localhost> <87pmbsrfak.fsf@gmail.com> Date: Sat, 07 Jan 2023 12:54:53 +0000 Message-ID: <87o7rald2a.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673096089; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=H5HuJIER44Tk6MN2+iQMNnqGoWHdDYri8Tdi5uERBec=; b=I0xsuEU60FUgF9ihmUK0ULDxPtgF7edMEuB0ivN/5G7lEiJR7lXn9xI5nlW8BmSNsbJRzN eU64t8TiqggGb3Uz7sTC8mIlRGwaaX2BHZUgQcsMuXozRG6pPUpxnFDKVMPPjaQqjQ0caO sgG8OXe0GnYJRA0APXsYOyIqgAZUdSWNaW5odZ+nCqLqNxFpAF/Pqwkmg0z+zWFx/9CMq9 nSKEkNNh2hug7LBm99v3L6Ivubgx1k2eAyIkL0sGgG+0YOYSDuwjOWNQcv52DB/eEG5dOW fLXjL73hq7Ui98vJzuDP5F1Lv0eilLs8sqbreLXgayQXaDaDYJldViWjfcigKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=FhVnuLpg; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673096089; a=rsa-sha256; cv=none; b=Zdgv2edW9Mbajd4MwWMCoP9+sTBnThpkyR9EGucZeC2t0NtgbHlRRacbHPn4uMJi0v99IG a/EBomWXVWFnZytQZkHwqYBbX8tE6Hw6wJ2ahioaOX1rZ+yzgr+6FLLVNI+92WUlDg7lJM n014J2I/x/ZfXwSTC2x5oTxOR/M7WuSVZnVDnEAxjdIA+mt5lzOUuSkzeDUkhASgAViAGI xUwr5m1z9EGT+KGQz1ZYmDM/izVHLSrpsm34qKVCtUMP9b9FOTIPiErF7jRd6jxQI6hXWg l8Zba2NlxCUc4C6Cr/e51noyWcUYfTSTqIZhnklDUh4m/Ap6O9oM4uraZY9N/Q== X-Spam-Score: -4.50 X-Migadu-Queue-Id: 2AB8C178BE Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=FhVnuLpg; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.50 X-TUID: Svugj4uG6ohk Ilya Chernyshov writes: > (defun org-datetree--find-create > @@ -169,18 +167,19 @@ component. If INSERT is non-nil and there is no match then it is > inserted into the buffer." > (when (or month day) > (org-narrow-to-subtree)) > - (let ((re (format regex-template year month day)) > + (let ((re (format org-complex-heading-regexp-format > + (format regex-template year month day))) These changes make the docstring for `org-datetree--find-create' incorrect: (defun org-datetree--find-create (regex-template year &optional month day insert) "Find the datetree matched by REGEX-TEMPLATE for YEAR, MONTH, or DAY. REGEX-TEMPLATE is passed to `format' with YEAR, MONTH, and DAY as arguments. Match group 1 is compared against the specified date component. If INSERT is non-nil and there is no match then it is inserted into the buffer." Please update the docstring to reflect the new behaviour. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at