From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SNXLDDUtPWTSfwEASxT56A (envelope-from ) for ; Mon, 17 Apr 2023 13:27:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GMC7DDUtPWR7vwAA9RJhRA (envelope-from ) for ; Mon, 17 Apr 2023 13:27:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5A55ED79 for ; Mon, 17 Apr 2023 13:27:48 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poN0P-0003PM-0P; Mon, 17 Apr 2023 07:26:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poN0M-0003Ow-Q9 for emacs-orgmode@gnu.org; Mon, 17 Apr 2023 07:26:42 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poN0K-0005Z0-PK for emacs-orgmode@gnu.org; Mon, 17 Apr 2023 07:26:42 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4184B240135 for ; Mon, 17 Apr 2023 13:26:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681730798; bh=LUIt52aSmMDNaBvOIvFJaq2Ss0gkGAb5ezX06iTDjLs=; h=From:To:Cc:Subject:Date:From; b=RdIWawrhonw5wDOj36HH98YvAJc1j2M8AgIBEopRXeI70uA1Y2cMTaeuUyOkTPd+a EKm1OTt+oqKbLgq+IgKoo+r0s8k/WYxoGoaDsVU1pEukfkUdVi94pum8yzY+ZML4ZB gO+dk9wAYACt/SfEaPv0hFyQoz8+nY+oe0Qn7MMgU5sJK6KxT/ZauoXmkfO4h35mr2 tptokDYWi4XVf0f4ggdgEywxQcV7cIPvZWx8twiWHR7LMra8C9bcTp4UW2Ahl9L/rf 3zZyMfr9vtobViUgLuGMqWiKJvfOE8M9g/ivZKP8SV4nBI4e61WMzPInc6lnsUs6KS 4kHqTDVX7Cqyg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q0Prs5tt2z6txQ; Mon, 17 Apr 2023 13:26:37 +0200 (CEST) From: Ihor Radchenko To: fernseed@fernseed.me Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-id.el: Add new relative timestamp feature for `ts' `org-id-method' In-Reply-To: <20230416164841.18665-1-fernseed@fernseed.me> References: <20230416164841.18665-1-fernseed@fernseed.me> Date: Mon, 17 Apr 2023 11:29:14 +0000 Message-ID: <87o7nmlpbp.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681730868; a=rsa-sha256; cv=none; b=Uji/n0snfCs137W7SVK8WBx2cSTk+BK5uUVd+ovNiI31BeXdoR3aNS2ZiHDSbmDWJQTW+h vxCOpjHNCb22YZXljj7pg2MWU+sITWoOQq4JJdtIaiaxDl2yjS4p51PzjQAbYIbO4beCVw QhAVd1ukj0pYK5spcOXKvcnTDUmw42T7WT03OF7c3b+zj+m+q5KXy/ZRwFjtzpNeV/Zap3 ggVd2+ZIBozGy3im3FKp1kG0r+/RW3x02gROELmZ80Iwi0e4X/jBjifZEFGkqDNsr/kfGU 94ykINJClR695QQLDMBhnir1YYxX3osl/eTOJgIWGzskMgx62HbzA5tGiJMVqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=RdIWawrh; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681730868; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qxp8lT6ZWZwV4wFcv72e/qO2PFbodySpiiRTp/DcLAA=; b=sgCfkdvPw8eS3IamIaucWF4IHISUhDdQea01ItlJMvR22b3vk5SoNuK4CLUm2oaRdwWVP3 vgBQk2GOFmGKbfxaWy3XZ/kTTp8KYJo3EcwESQGgedOMqQJR8j8J/CuGb6O1dfyYysZZsh npxmqMwzsu7Hevwr091Ca3oro0wqq/1wKfuyeuQmrviey9f0K/l5a1wz5MAR4wr6FWo8BW fHgaDSma5ExrzRP9p1y7z+UCCAVuiAPdOiORVv+VHGHRwVi3ratbLN0V30BPJL6XZhH2O2 dWNCoVXPFEDcuKQWbHW78ETXhuMvEENTffL01ihU6ER9nGXMLA1kDSw7mFbzhg== X-Migadu-Queue-Id: D5A55ED79 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=RdIWawrh; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -11.60 X-Spam-Score: -11.60 X-TUID: bETFOniTZeNp fernseed@fernseed.me writes: > * etc/ORG-NEWS (New relative timestamp feature now available for the > ~ts~ ~org-id-method~): Document the new feature. > --- > This patch introduces a new feature for the `ts` method specified by > `org-id-method' that allows for the creation IDs with relative > timestamps. This is my first patch for Emacs/Org mode. I have just > started the FSF copyright assignment process. Thanks for the patch! Several high-level comments: 1. Instead of manually searching for keywords, please use `org-collect-keywords' 2. It will make sense to allow properties, not just keywords, to be the source of time. 3. Currently, `org-id-new' can be called outside Org mode buffers. With your new ID method, `org-id-new' may fail with error in non-Org buffers. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at