From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uIa4EtWZ+GSEWAAAauVa8A:P1 (envelope-from ) for ; Wed, 06 Sep 2023 17:25:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uIa4EtWZ+GSEWAAAauVa8A (envelope-from ) for ; Wed, 06 Sep 2023 17:25:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D8D553222F for ; Wed, 6 Sep 2023 17:25:08 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=whxvd.name header.s=MBO0001 header.b=W5xNxQMV; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694013908; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=g1FS0cah8DcgdC/jtJ5wlSNgG9WLP6BowAm+srTWYPY=; b=IrYNvZm3Ia8QMvFXH7Y75a1sbY1aq35OIY860SNa9IMDlKy41oLn90G0HIorV54L0EoetS KSF0rwdmLPd5Iqpuyw7Eudo76CS2tsKV8F1OLrDI8CkUU9spljy1UEGkZ3e6t1d6yQd9FE EG2uAzN9uEKzpoal3Q155ZoLuG9bn/95ekQb3L5jPXTWy/aXFbYVOZtghP7tinXuZjcGXc COVYQ7rlqr09YP5jqA3Xe+kRrsJ8TsHFwZdASeeDB/wzyAOuwqmtuMVC3eTYpjw+aCCJn9 c66R4CvwwS9qtNOWuv00tGzLZJkYCJeNVTYXCBRNw7orn3TD0wtUQJReRN/l2w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694013908; a=rsa-sha256; cv=none; b=iVuzktqUQEJL+mnvUHgCCSGX/uCYYFqOgAyoh8rKzfFf2brtX0ieSDCoCh3sLna42HLlNg QA8CmuN7G0R2SMUAyqZgE/MQh7YwXUTI0smrJJV/dTOpmkK4o7yP/+kzPSvBTIFiCn3svU VyU+cQB8pLE3rdO3cyXOqITvXRURJ+tvHnucMy52KR4o+I1dlWmQgQtmYCxAHbMC6EduiT NMfnEl0TnttJ6IdAQQe8qxhHATJDEjycIqsX8LYuR14BHNeQesP2383QhWtu7ypiI/MNaS yiUX5OAqvcOwdTE/QdVW6HEUAK5qL/X/EFepASLdkdiGZvkq/Wp5KwOeUCqE5g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=whxvd.name header.s=MBO0001 header.b=W5xNxQMV; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qduO4-0004Bn-Nj; Wed, 06 Sep 2023 11:24:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qduO2-0004BQ-NN for emacs-orgmode@gnu.org; Wed, 06 Sep 2023 11:24:11 -0400 Received: from mout-p-102.mailbox.org ([80.241.56.152]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qduO0-0006Ls-1M; Wed, 06 Sep 2023 11:24:10 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4RgmPG4WtMz9t54; Wed, 6 Sep 2023 17:24:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=whxvd.name; s=MBO0001; t=1694013842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1FS0cah8DcgdC/jtJ5wlSNgG9WLP6BowAm+srTWYPY=; b=W5xNxQMVhgROEP3VeiIiQfv2h5wxs9LkM1C5LRxiNMIf4TvAZVpi7itz5PwX2qJYpCYJ/g GsXxj9Wi7PNSbFQ38Lf46pTrcLkJSZx7R+3z4N6fy6ZPJo51XhKrbWrlHWC6sO08i1Wjjo imoW7HuKSzS107hkeLVJIStNxwoSEU4agi5Fi737nTTUvj+tVK+6loFAtXd8vXa9aPlGjR BW0A+ldASm/8rhlEnyid/9jJDxC0sPDQH/lYg5h3WJ14dAQSzaQ26GcG8jAVsDRItDwuLQ 4HzHcN8DTtut7RdFL7m80a/mrShsnYLM4naw48azpfhs0/50j23SaunZqSA/pg== References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <87ledju2j7.fsf@localhost> From: Sebastian Miele To: Ihor Radchenko Cc: Eli Zaretskii , 65734@debbugs.gnu.org, emacs-orgmode@gnu.org Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Wed, 06 Sep 2023 17:04:48 +0200 In-reply-to: <87ledju2j7.fsf@localhost> Message-ID: <87o7if72b2.fsf@whxvd.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=80.241.56.152; envelope-from=iota@whxvd.name; helo=mout-p-102.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -9.05 X-Migadu-Queue-Id: D8D553222F X-Migadu-Spam-Score: -9.05 X-TUID: BXvta5AREAi5 > From: Ihor Radchenko > Date: Wed, 2023-09-06 08:30 +0000 > > Eli Zaretskii writes: > >>> It would also make sense to group the two edits together via >>> `combine-after-change-calls', although a more universal way to know that >>> certain edits are a part of the same known command (even when called >>> non-interactively) would be useful. >> >> The command kills in two parts for a good reason, which is explained >> in the comments to the code. So making a single group will not work, >> I think, at least not in all situations. > > I think there is misunderstanding. `combine-after-change-calls' will not > affect the two-step modification of the kill ring, if we put it around > `kill-whole-line'. Or do I miss something? I tried to wrap the problematic portion of `kill-whole-line' into `combine-after-change-calls'. It seems to have no effect. The after-change function `org-fold-core--fix-folded-region' still gets called twice, not fixing the bug. I did not dig deeper, because the stuff that makes `combine-after-change-calls' work at least partially goes in C and seems to be scattered over several places. The Emacs Lisp manual states that `combine-after-change-calls' "arranges to call the after-change functions just once for a series of several changes=E2=80=94if that seems safe." So this case does not seem safe. Apa= rt from that, there is no stated guarantee for when it would seem it safe. I conclude that, although this path looked possibly elegant at first, and I wanted to give it a try, this cannot work out.