From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id WLcrMym7nmWfJAEAkFu2QA (envelope-from ) for ; Wed, 10 Jan 2024 16:43:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id SDSOLCm7nmVpowAAe85BDQ (envelope-from ) for ; Wed, 10 Jan 2024 16:43:37 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ey2ycU9r; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704901417; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Y/A8MHPfA0jXSdcuCWHIgbO+ozCFqDBS9OOTZyTWhWQ=; b=UEsU7na5s0jhhr7Bzsk8A/hSqmf7ZePuzy7lcUeWl/t1yG0oVxOcAuBSWUi/jMa11MRilo 0J/I+L9FYvldbr42pE6oGZ19MWW7EhUG9jNHKLyOKe3whCNOo5VxExwJu8ybpNgZOCPILX ydIyfS8efZ9oYcONmNHR1im5eXY1AvC4wmFW7LsUaosuq45YAuxz8XYHhDIAIdZB0W+z/S 3r9z9u4W/d4uz7Is/VmPdy1JX5JAr5m8dm7xUCvKN0PVng/zYuLY4Yq4kDpUQvQuGZKsnD 3r5rGI/nJJRmJszCUjX62usm4To2BbyC3OAAsIQJ/GxKbClKDW7V6IlMe2yBtw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704901417; a=rsa-sha256; cv=none; b=YmSnzg1jR06hzBuxq4VHSE8TZcKO8HJ7RdRB1Pv9PHGGjnsrN9MSw2WVTQhLwtUvYTsprt XHt+NXUnGerSm2nG+pgjOYd+XlxBE4gUQw4nVHP/zDI7MYpvL4TTsdfT1cji030ZIlS1Hj YQniWwqEX61N2MK9ejPz+k6Ziw0IZCRL2ZZkZoM2NEXkb0PlLFqYuhIUWLi6hsenqhGrTx Lxe5O8Hk2adBvx+Z42uT+nuQn2JbV/bgBn2G2+DMKqf1FIXODKgfn5nbEJIUtBkrnT6ykZ PVvzbNTZGCJwejVxXNu5HQmPFSYb2jRBCI44FLdwqQDvUJmuvLitwNGCctHxYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ey2ycU9r; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 557441775B for ; Wed, 10 Jan 2024 16:43:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNajE-0004a1-Sv; Wed, 10 Jan 2024 10:42:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNajD-0004ZX-7D for emacs-orgmode@gnu.org; Wed, 10 Jan 2024 10:42:51 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNajB-0007vM-2T for emacs-orgmode@gnu.org; Wed, 10 Jan 2024 10:42:50 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 65370240027 for ; Wed, 10 Jan 2024 16:42:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704901366; bh=LJCKuOijuMo+SwfCEt+2PLccC1HP5qf7DPiO0DFuyy0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=Ey2ycU9rqHJ9myXNJS7qNvxNJUYjpELXs6u8LXYaKZtyI/OzT4TwzyLATh80pFBHk +Yh9Cb0HCGC+dY7DIPtSv5Gf/iy5eYD2veR8n7fF1ASmF2OwujGUfU889Mh3Vm1ZG3 qiSZfkOF/ZzmN9dqeHib+cFlAMRxsMVqsXSI7wsybmOIA8X6eo8pk1FHRkJSvKZHd5 oBxipk7CBdoUcuPWBq5bRtAOgGOcmKhbm/sxYNXFp8DxNCO0/lwBUEaXdjIKRNGGIH 9A8oZQtBz/nsDDMU+Kti89rhJ4hdmmVgVDstIum+dsYAAOJLIdo50vnxikPPdqCO4U 4SLmRhJq5ZDJQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T9Brj3GZpz9rxB; Wed, 10 Jan 2024 16:42:44 +0100 (CET) From: Ihor Radchenko To: Psionic K Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Unindentation fixup for code blocks In-Reply-To: References: <877ckhqso8.fsf@localhost> Date: Wed, 10 Jan 2024 15:45:56 +0000 Message-ID: <87o7dtkx8r.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.80 X-Spam-Score: -8.80 X-Migadu-Queue-Id: 557441775B X-Migadu-Scanner: mx12.migadu.com X-TUID: IZ3Tt75N6KkW Psionic K writes: >> Would you also be able to create a reproducer, so that we can replicate > the problem and write a test? > > Yeah, I just have to make some indentation text invisible. Where > should such a test live? Where is your documentation on running a > test? The tests live in tests/lisp folder. See https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/testing/README >> It looks like you did not send the patch with git send-emai. > Nope. Magit patch create. Attaching another patch. Thanks! This patch does apply. I am not yet sure if I like this patch or the previous one more. I am thinking about combining them and implementing something like `org-move-to-text-column'. >> This math is not accurate when tabs are present. > > You want to short circuit this kind of conversation. I was not > actually aware of any tabs versus spaces aware functions to build on > top of since I always use spaces. Had I not already found another way > to correct the behavior, this would have been a dead-end I would have > had to round trip. I am not sure what you mean. > I'm presuming tests don't get their own changelog entries. Is that correct? Tests are a part of Org codebase. They do have their own changelog entries inside commit messages that introduce such tests. For example, see https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d0d838b02e44a40adca14d6eae39fd4c364730da -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at