From: Ihor Radchenko <yantar92@posteo.net>
To: Psionic K <psionik@positron.solutions>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Unindentation fixup for code blocks
Date: Wed, 10 Jan 2024 15:45:56 +0000 [thread overview]
Message-ID: <87o7dtkx8r.fsf@localhost> (raw)
In-Reply-To: <CADQMGATV7JFOih+XNd-ytFwi9kfmfNQ6RT0vAS+rTT8g8GJNBQ@mail.gmail.com>
Psionic K <psionik@positron.solutions> writes:
>> Would you also be able to create a reproducer, so that we can replicate
> the problem and write a test?
>
> Yeah, I just have to make some indentation text invisible. Where
> should such a test live? Where is your documentation on running a
> test?
The tests live in tests/lisp folder.
See https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/testing/README
>> It looks like you did not send the patch with git send-emai.
> Nope. Magit patch create. Attaching another patch.
Thanks! This patch does apply.
I am not yet sure if I like this patch or the previous one more. I am
thinking about combining them and implementing something like
`org-move-to-text-column'.
>> This math is not accurate when tabs are present.
>
> You want to short circuit this kind of conversation. I was not
> actually aware of any tabs versus spaces aware functions to build on
> top of since I always use spaces. Had I not already found another way
> to correct the behavior, this would have been a dead-end I would have
> had to round trip.
I am not sure what you mean.
> I'm presuming tests don't get their own changelog entries. Is that correct?
Tests are a part of Org codebase. They do have their own changelog
entries inside commit messages that introduce such tests. For example,
see https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d0d838b02e44a40adca14d6eae39fd4c364730da
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-01-10 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 9:20 [PATCH] Unindentation fixup for code blocks Psionic K
2024-01-10 12:28 ` Ihor Radchenko
2024-01-10 13:55 ` Psionic K
2024-01-10 15:45 ` Ihor Radchenko [this message]
2024-01-21 12:04 ` Ihor Radchenko
2024-03-12 12:26 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7dtkx8r.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=psionik@positron.solutions \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).