From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id qCkPBiMoHmbbXwEAqHPOHw:P1 (envelope-from ) for ; Tue, 16 Apr 2024 09:26:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qCkPBiMoHmbbXwEAqHPOHw (envelope-from ) for ; Tue, 16 Apr 2024 09:26:27 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UuoNibsl; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713252387; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature: openpgp:openpgp; bh=Cmvyf+NCQm6R118bKSMAZflZe5co7eQfwf7pOgU2dxA=; b=SLic2Ho41HX2t/7uKWZEwer387+LUdAOhlJmCdCvROYiwHIOQfOKD4zIGUO6QFhIeqkJp9 exMNypGfS/bUmWU1LSP/ILbDbv3d0L2mBvOvhutkMM6HdRBlqv2OC7JEiD0jskH2VH17KN 0ygfwPapNcV3M2xCQF+qIro8nCgN+dM3PdbNsLMgqEYZFwIJFGdbU6aDnL8slM55lhjzvf 9B5uvJj4QgP8LDQz10mk3HLMIgHnIGLQR1OfbKwShxOscANEJd9HWreEqJlaqftdbvW1Wh hgK0ZllqA4HSAs4mFJMi/JbTKoilTjUgGKQcwEY9e5UF2flb4tAb2QSlG311OQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713252387; a=rsa-sha256; cv=none; b=HBUxCOZDNpQmqjEi9DvMkha9Ilb3fH/xcwCzyXPZu0VV28DwvUkMHMZk4nTnB/E9KrFj1n 1iFO4X2aEOF/Q1yiPdZzX19GiX0lo6/zG9qR+f6ETnTLG0bF1kK6R13TO8pXWvndye7Xa+ 7qwT7BnKB2Frl5c3fcSlB6Pf9u80hZ8Ni1NEXtmNqwIhcruE7vVP/7t6H8PQ2gbf9BWftg AxhxEgF+of5WC82+i1y6wFhgDw/g5Mg1rISEU1HlFGaCqHithO9j04ecskDWHRi3amy1dM jYqd1H79mYi0PNzKLDrqQFIWt2yjXeBfjNvZ82V+w5lcvmHauyc5at2G+9t3vQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=UuoNibsl; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF5A710C90 for ; Tue, 16 Apr 2024 09:26:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwdBW-0002nB-Qy; Tue, 16 Apr 2024 03:24:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwdBU-0002mm-IC for emacs-orgmode@gnu.org; Tue, 16 Apr 2024 03:24:52 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwdBP-00054t-0v for emacs-orgmode@gnu.org; Tue, 16 Apr 2024 03:24:50 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3305D240103 for ; Tue, 16 Apr 2024 09:24:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1713252284; bh=zWqsfp69k5XVv0exZhCus70iDVxwSttAo8tNczDRyCE=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=UuoNibsl2FJkpDJiCg6Z7LYUdCr+lJX58iNTdwYg214AaNtsth1wKdwh+UHza6GW+ PN2O7Es+7h/7QtrCKoYriVwNZvMvCB2yjidYdWXUFbQP8Gpd23tMhz4ByMB6fgetg1 kTx1UphCND9YXaVz9m+eIIwgJez8s2ySI0btyvAnQYg98seeWcU6M66cTtH7mYkxQr g1dWsdPPOlShbHzFZz/2S/v0bKt0nA3p41Vx4kt2uZLx4aQhnPEFUhG/LiI1NtyL5y PTaC/K4ggvYj/H5xyIjP1rjBBiumrd8sWrR2013TsXwy86CiQefgzU4ARiSUjnR9qI oNXin6J9KA9GA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VJbCH0lSQz6tvy; Tue, 16 Apr 2024 09:24:42 +0200 (CEST) From: Philip Kaludercic To: =?utf-8?Q?S=C5=82awomir?= Grochowski Cc: Eli Zaretskii , yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org Subject: Re: [DISCUSSION] "quick-help" popup for org-columns (column view) In-Reply-To: <87wmoy94wc.fsf@gmail.com> (=?utf-8?Q?=22S=C5=82awomir?= Grochowski"'s message of "Mon, 15 Apr 2024 14:39:15 +0200") References: <87a5oayblv.fsf@gmail.com> <87jzlxro68.fsf@localhost> <87zfu6b4w3.fsf@gmail.com> <86jzl91zrd.fsf@gnu.org> <87frvwl2wv.fsf@gmail.com> <87plv02rez.fsf@posteo.net> <87cyqzllbx.fsf@gmail.com> <87o7ahmxnj.fsf@posteo.net> <87msq12blu.fsf@gmail.com> <87cyqwmmkb.fsf@posteo.net> <87v84l3bfx.fsf@posteo.net> <87wmoy94wc.fsf@gmail.com> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Tue, 16 Apr 2024 07:24:42 +0000 Message-ID: <87o7a9lqh1.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -9.78 X-Spam-Score: -9.78 X-Migadu-Queue-Id: CF5A710C90 X-Migadu-Scanner: mx13.migadu.com X-TUID: VGlbzShmNLDL S=C5=82awomir Grochowski writes: > Philip Kaludercic writes: >> I have pushed the changes to master. > > Thank you Philip for your help. It works. > > But there is one more small thing.=20 > A message that is displayed in the minibuffer.=20 > It contains two pieces of information: > > (1) command name > Right now it's hardcoded.=20 > We need to change the it from `help-quick-toggle' to > `org-columns-help-quick-toggle'. > How to do it?=20 > Add another variable like `help-quick-use-map'? > Maybe 'help-quick-command-name'? Instead of using substitute-command-keys, we could just use this-command, but that assumes that help-quick can always be toggled by the command that invokes it. > (2) keybinding to the command name > Just to modify message string. Add '\\'. > To use other keymap. > Change is in the diff below.=20 I don't see how this would work in general, at the very least it breaks the regular usage. Furthermore, I am not convinced we have to change anything here, since C-h C-q (the default binding for `help-quick-toggle') should also hide the buffer if one uses your command, or am I mistaken? > > diff --git a/lisp/help.el b/lisp/help.el > index d4e39f04e53..35412b9d2fe 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -263,7 +263,9 @@ help-quick > ;; ... and shrink it immediately. > (fit-window-to-buffer)) > (message > - (substitute-command-keys "Toggle display of quick-help buffer using= \\[help-quick-toggle].")))) > + (substitute-command-keys "Toggle display of quick-help buffer using= \\ \\[org-columns-help-quick-toggle].")))) > + > + >=20=20 > (defun help-quick-toggle () > "Toggle display of a window showing popular commands and their binding= s. > --=20 > > 2.30.2 > > > Regards, --=20 Philip Kaludercic on peregrine