From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KMS+CYjz72bsBQEA62LTzQ:P1 (envelope-from ) for ; Sun, 22 Sep 2024 10:38:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KMS+CYjz72bsBQEA62LTzQ (envelope-from ) for ; Sun, 22 Sep 2024 12:38:00 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=L8y7QxD6; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727001480; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rKwUSJjiR2KR+wVVVO8sGtbluBhsBLAjtDym+IiiS4g=; b=JZHy0TLbW/QTEASaLP/kE+XXkcsSjpkT7fHAwhH3jQrYxenAsQOIwTsuUxJQCPwKotjLOZ cUmGlQHOtEazrCvm74Fv4zIOe6P04WK6yFyUUgzXGyzw0XejFCxg7ea7Vd0UUNUmsNOSVx uXqQQEitsXAp5lcQ46HcilQ9bNPDXm+C8sf0xdMFlI00n7NueAdd42W458rZmA0SaENfqB 68VwrjkFtTMUqCZA+uyjhaLQrcb5XXfxbAAqebV+00/WG+as8TGzhJBIp9qWFaDieELBUd BUWu0sma2KZ7IMEODDx96GOoD5z/Huo6K0R29VJ/L+fAmzug7DLm+bGPfkkMnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=L8y7QxD6; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727001480; a=rsa-sha256; cv=none; b=LdNIXqQyRefxvOgqU9hIhL8XS8vcTooEeCCxIg6y5e6KnQEJCIeC+Ki3lqoiGQXNMxP3/2 q3g5izVowERsnpWpNSH1X3+Aqm57OzCIFLTgFnRSY+D3IC1haIIGW5cf0iszWwZ/scKTBE 4Ud0vDOE2UaArvqWqqgGR6OxyQZHEW77kp+K62U+MGaoSdJr8uGq8I+bbjCNx/pLkuNdHI 72n195ozV7IiHn4UsjEO1jR9+qrWtPKNt1i6hpExZgUScwkO87eHj146lcP4pmfs2wsn3L T93QcAfdUrQw9Q2/q/ay12660keCxfInSnSWJbrZbGMoTApCYVPz32PMvsgnXQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB9BD7FF50 for ; Sun, 22 Sep 2024 12:37:59 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssJxf-0001Eo-GA; Sun, 22 Sep 2024 06:37:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssJxd-0001Eb-V7 for emacs-orgmode@gnu.org; Sun, 22 Sep 2024 06:37:02 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssJxc-00020L-4z for emacs-orgmode@gnu.org; Sun, 22 Sep 2024 06:37:01 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 24FB8240027 for ; Sun, 22 Sep 2024 12:36:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1727001418; bh=8Z2wbNkpL455egvJZQ2/uD8ds91GELKRYJ4kxzgwbfQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=L8y7QxD6dMMmXz2zQf8vNx232RQ2KTImLMVJtLOrt+4JiPswAhFg+jJyz9ZpGKUnq 09ijMq02kJqBQUl5M8O3IpJn3RXG9Gi+ZLPhY1yRFni4w8ncXItod9hAXYBMvAO7N8 0e8KzPnDnz8u0URf2CW4/cbZmqa5+76yFIwfUhRXz0c7kb8m3mVPABNm9JcuX6wLB3 L/joxNusQv3qaG5k1ABrlmfEWmYbkwx6Z3kIrLJtKBtyGyzS+Vlm4MyeUz415kl1FX q0THsiZuAudQ5a6xoVAU4p20eOfuAkouQB0M+WjQYe55OlMernT1NyTv+7i13/mvEJ fXhybId57eQ8A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XBMxj3YqRz6twL; Sun, 22 Sep 2024 12:36:57 +0200 (CEST) From: Ihor Radchenko To: Rodrigo Morales Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] fix org-babel-view-src-block-info In-Reply-To: <87h6a8lek0.fsf@morales.pe> References: <87h6a8lek0.fsf@morales.pe> Date: Sun, 22 Sep 2024 10:38:33 +0000 Message-ID: <87o74gq8gm.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.31 X-Spam-Score: -5.31 X-Migadu-Queue-Id: DB9BD7FF50 X-Migadu-Scanner: mx10.migadu.com X-TUID: viIoVwxoymtX Rodrigo Morales writes: > This is one of the first patches that I sent to the Org Mode > project. Please let me know if I have done something wrong, so > that I don't make the same mistake in the future. > > From 4453277ee0d9aa6318008a21c4f3f9b16d29c901 Mon Sep 17 00:00:00 2001 > From: Rodrigo Morales > Date: Sat, 21 Sep 2024 19:04:55 -0500 > Subject: [PATCH] lisp/ob-core.el: fix org-babel-view-src-block-info Thanks! Applied, onto bugfix. I changed the commit message a little, clarifying the purpose of the patch (rather than generic "fix"), adding a proper changelog entry (see https://orgmode.org/worg/org-contribute.html#commit-messages), quoting symbols as `symbols', and adding double space between sentences. I also added TINYCHANGE cookie as I do not see your name in our records of contributors with copyright assignment. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d8fc26aefa Note that we had another patch from Rodrigo Morales in 2021: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e0535fa2d8215ba9a9f96058807648df72e2d99d Is it yours? (it is under different email) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at