From: Ihor Radchenko <yantar92@posteo.net>
To: Rodrigo Morales <rodrigo-mailing-lists@morales.pe>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] fix org-babel-view-src-block-info
Date: Sun, 22 Sep 2024 10:38:33 +0000 [thread overview]
Message-ID: <87o74gq8gm.fsf@localhost> (raw)
In-Reply-To: <87h6a8lek0.fsf@morales.pe>
Rodrigo Morales <rodrigo-mailing-lists@morales.pe> writes:
> This is one of the first patches that I sent to the Org Mode
> project. Please let me know if I have done something wrong, so
> that I don't make the same mistake in the future.
>
> From 4453277ee0d9aa6318008a21c4f3f9b16d29c901 Mon Sep 17 00:00:00 2001
> From: Rodrigo Morales <rodrigo@morales.pe>
> Date: Sat, 21 Sep 2024 19:04:55 -0500
> Subject: [PATCH] lisp/ob-core.el: fix org-babel-view-src-block-info
Thanks!
Applied, onto bugfix.
I changed the commit message a little, clarifying the purpose of the
patch (rather than generic "fix"), adding a proper changelog entry (see
https://orgmode.org/worg/org-contribute.html#commit-messages), quoting
symbols as `symbols', and adding double space between sentences.
I also added TINYCHANGE cookie as I do not see your name in our records
of contributors with copyright assignment.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d8fc26aefa
Note that we had another patch from Rodrigo Morales in 2021:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e0535fa2d8215ba9a9f96058807648df72e2d99d
Is it yours? (it is under different email)
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-09-22 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 0:25 [PATCH] fix org-babel-view-src-block-info Rodrigo Morales
2024-09-22 10:38 ` Ihor Radchenko [this message]
2024-09-23 1:24 ` Rodrigo Morales
2024-09-23 18:01 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o74gq8gm.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=rodrigo-mailing-lists@morales.pe \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).