From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Egli Subject: Re: [PATCH 1/5] Add some minimal infrastructure to handle export to both tj2 and tj3 Date: Thu, 17 Mar 2011 11:39:30 +0100 Message-ID: <87mxkum3od.fsf@sbs.ch> References: <1300273502-12977-1-git-send-email-christian.egli@alumni.ethz.ch> <1300273502-12977-2-git-send-email-christian.egli@alumni.ethz.ch> <871v26qg0t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from [140.186.70.92] (port=40211 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0AcL-0006KG-HF for emacs-orgmode@gnu.org; Thu, 17 Mar 2011 06:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0AcK-00012r-G3 for emacs-orgmode@gnu.org; Thu, 17 Mar 2011 06:39:45 -0400 Received: from lo.gmane.org ([80.91.229.12]:52584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0AcK-00012X-4O for emacs-orgmode@gnu.org; Thu, 17 Mar 2011 06:39:44 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q0AcH-0004vj-Gs for emacs-orgmode@gnu.org; Thu, 17 Mar 2011 11:39:41 +0100 Received: from gateway01.sbszh.ch ([217.162.18.85]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 17 Mar 2011 11:39:41 +0100 Received: from christian.egli by gateway01.sbszh.ch with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 17 Mar 2011 11:39:41 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bastien writes: > Christian Egli writes: > >> +(defun org-taskjuggler-targeting-tj3-p () >> + "Return true if we are targeting TaskJuggler III." >> + (< org-export-taskjuggler-target-version 3.0)) > > I'm dubious on this one. > > Shouldn't it be > > #+begin_src emacs-lisp > (defun org-taskjuggler-targeting-tj3-p () > "Return true if we are targeting TaskJuggler III." > (> org-export-taskjuggler-target-version 3.0)) > #+end > > ? Basically org-export-taskjuggler-target-version can be 2.4 or 3.0. So org-taskjuggler-targeting-tj3-p should return true if org-export-taskjuggler-target-version is 3.0 or higher and false otherwise. So, let's see what the *scratch* buffer has to say about this #+begin_src emacs-lisp (setq org-export-taskjuggler-target-version 2.4) 2.4 (defun org-taskjuggler-targeting-tj3-p () "Return true if we are targeting TaskJuggler III." (> org-export-taskjuggler-target-version 3.0)) org-taskjuggler-targeting-tj3-p (org-taskjuggler-targeting-tj3-p) nil (setq org-export-taskjuggler-target-version 3.0) 3.0 (org-taskjuggler-targeting-tj3-p) nil (setq org-export-taskjuggler-target-version 3.1) 3.1 (org-taskjuggler-targeting-tj3-p) t #+end Ah, you're right. There is a problem :-\. The correct version should be #+begin_src emacs-lisp (defun org-taskjuggler-targeting-tj3-p () "Return true if we are targeting TaskJuggler III." (>= org-export-taskjuggler-target-version 3.0)) #+end Let's test this in *scratch* #+begin_src emacs-lisp (setq org-export-taskjuggler-target-version 2.4) 2.4 (defun org-taskjuggler-targeting-tj3-p () "Return true if we are targeting TaskJuggler III." (>= org-export-taskjuggler-target-version 3.0)) org-taskjuggler-targeting-tj3-p (org-taskjuggler-targeting-tj3-p) nil (setq org-export-taskjuggler-target-version 3.0) 3.0 (org-taskjuggler-targeting-tj3-p) t (setq org-export-taskjuggler-target-version 3.1) 3.1 (org-taskjuggler-targeting-tj3-p) t #+end How do we proceed? Do I resubmit the patch? Thanks Christian -- Christian Egli Swiss Library for the Blind, Visually Impaired and Print Disabled Grubenstrasse 12, CH-8045 Zürich, Switzerland