From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Bug: void-variable filter-buffer-substring-functions [7.5 (release_7.5.384.g94b32)] Date: Thu, 16 Jun 2011 10:56:17 -0400 Message-ID: <87mxhhhlke.fsf@norang.ca> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:37455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXDzf-000210-8Q for emacs-orgmode@gnu.org; Thu, 16 Jun 2011 10:56:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXDzX-00011f-MZ for emacs-orgmode@gnu.org; Thu, 16 Jun 2011 10:56:27 -0400 Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:41925 helo=mho-02-ewr.mailhop.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXDzX-00011Z-Fr for emacs-orgmode@gnu.org; Thu, 16 Jun 2011 10:56:19 -0400 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: schulte.eric@gmail.com Cc: emacs-orgmode@gnu.org Hi Eric, Commit 66e8a4b (Globally replace buffer-substring-filters with filter-buffer-substring-functions., 2011-06-14) breaks clock reports with the following backtrace below when org-indent-mode is enabled. The key sequence to reproduce this error with the minimal emacs setup below is as follows: | Key | Description | |---------+-----------------------| | C-c a a | Go to the agenda | | R | Show the clock report | Reverting this commit fixes this for me. Regards, Bernt /tmp/test.el --8<---------------cut here---------------start------------->8--- (setq org-startup-indented t) --8<---------------cut here---------------end--------------->8--- ~/bin/minimal-emacs --8<---------------cut here---------------start------------->8--- #!/bin/sh TESTEL=3D TESTFILE=3D/tmp/test.el if test -e $TESTFILE then TESTEL=3D"-l /tmp/test.el" fi emacs -q -l ~/minimal.emacs $TESTEL $1 --8<---------------cut here---------------end--------------->8--- ~/minimal.emacs --8<---------------cut here---------------start------------->8--- (add-to-list 'load-path (expand-file-name "~/git/org-mode/lisp")) (add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-m= ode)) (require 'org-install) (global-set-key "\C-cl" 'org-store-link) (global-set-key "\C-ca" 'org-agenda) (global-set-key "\C-cb" 'org-iswitchb) --8<---------------cut here---------------end--------------->8--- Debug Backtrace --8<---------------cut here---------------start------------->8--- Debugger entered--Lisp error: (void-variable filter-buffer-substring-functi= ons) add-to-list(filter-buffer-substring-functions org-indent-remove-propertie= s-from-string) (cond ((org-bound-and-true-p org-inhibit-startup) (setq org-indent-mode n= il)) ((and org-indent-mode ...) (message "org-indent-mode does not work in = XEmacs - refusing to turn it on") (setq org-indent-mode nil)) ((and org-ind= ent-mode ...) (message "org-indent-mode can crash Emacs 23.1 - refusing to = turn it on!") (ding) (sit-for 1) (setq org-indent-mode nil)) (org-indent-mo= de (org-set-local ... nil) (or org-indent-strings ...) (when org-indent-mod= e-turns-off-org-adapt-indentation ...) (when org-indent-mode-turns-on-hidin= g-stars ... ...) (make-local-variable ...) (add-to-list ... ...) (org-add-h= ook ... ... nil ...) (org-add-hook ... ... nil ...) (org-add-hook ... ... n= il ...) (and font-lock-mode ...)) (t (save-excursion ...))) (let ((last-message ...)) (setq org-indent-mode (cond ... ... ...)) (cond= (... ...) (... ... ...) (... ... ... ... ...) (org-indent-mode ... ... ...= ... ... ... ... ... ... ...) (t ...)) (run-hooks (quote org-indent-mode-ho= ok) (if org-indent-mode ... ...)) (if (called-interactively-p ...) (progn n= il ...))) org-indent-mode(1) (progn (require (quote org-indent)) (org-indent-mode 1)) (if org-startup-indented (progn (require ...) (org-indent-mode 1))) (when org-startup-indented (require (quote org-indent)) (org-indent-mode = 1)) (if org-inhibit-startup nil (when org-startup-align-all-tables (let ... .= .. ...)) (when org-startup-with-inline-images (org-display-inline-images)) = (when org-startup-indented (require ...) (org-indent-mode 1)) (unless org-i= nhibit-startup-visibility-stuff (org-set-startup-visibility))) (unless org-inhibit-startup (when org-startup-align-all-tables (let ... .= .. ...)) (when org-startup-with-inline-images (org-display-inline-images)) = (when org-startup-indented (require ...) (org-indent-mode 1)) (unless org-i= nhibit-startup-visibility-stuff (org-set-startup-visibility))) (let ((delay-mode-hooks t)) (outline-mode) (setq major-mode (quote org-mo= de)) (setq mode-name "Org") (progn (if ... ...) (unless ... ...) (let ... .= ..)) (use-local-map org-mode-map) (set-syntax-table org-mode-syntax-table) = (setq local-abbrev-table org-mode-abbrev-table) (if (featurep ...) (when ..= . ... ... ...) (define-key org-mode-map [menu-bar headings] ...) (define-ke= y org-mode-map [menu-bar hide] ...) (define-key org-mode-map [menu-bar show= ] ...)) (org-load-modules-maybe) (easy-menu-add org-org-menu) (easy-menu-ad= d org-tbl-menu) (org-install-agenda-files-menu) (if org-descriptive-links (= add-to-invisibility-spec ...)) (add-to-invisibility-spec (quote ...)) (add-= to-invisibility-spec (quote ...)) (when (featurep ...) (org-set-local ... t= )) (org-set-local (quote outline-regexp) org-outline-regexp) (org-set-local= (quote outline-level) (quote org-outline-level)) (when (and org-ellipsis .= .. ... ...) (unless org-display-table ...) (set-display-table-slot org-disp= lay-table 4 ...) (setq buffer-display-table org-display-table)) (org-set-re= gexps-and-options) (when (and org-tag-faces ...) (org-set-tag-faces ... org= -tag-faces)) (org-set-local (quote calc-embedded-open-mode) "# ") (modify-s= yntax-entry 64 "w") (if org-startup-truncated (setq truncate-lines t)) (org= -set-local (quote font-lock-unfontify-region-function) (quote org-unfontify= -region)) (org-set-local (quote org-table-may-need-update) t) (org-add-hook= (quote before-change-functions) (quote org-before-change-function) nil (qu= ote local)) (org-add-hook (quote kill-buffer-hook) (quote org-check-running= -clock) nil (quote local)) (org-set-autofill-regexps) (setq indent-line-fun= ction (quote org-indent-line-function)) (org-update-radio-target-regexp) (o= rg-set-local (quote beginning-of-defun-function) (quote org-beginning-of-de= fun)) (org-set-local (quote end-of-defun-function) (quote org-end-of-defun)= ) (org-set-local (quote next-error-function) (quote org-occur-next-match)) = (if org-enforce-todo-dependencies (add-hook ... ...) (remove-hook ... ...))= (if org-enforce-todo-checkbox-dependencies (add-hook ... ...) (remove-hook= ... ...)) (org-set-local (quote comment-start) "#") (org-set-local (quote = comment-padding) " ") (org-set-local (quote align-mode-rules-list) (quote .= ..)) (org-set-local (quote imenu-create-index-function) (quote org-imenu-ge= t-tree)) (if (or ... ...) (org-add-hook ... ... ... ...) (org-set-local ...= ...)) (and org-startup-with-beamer-mode (org-beamer-mode 1)) (set (make-lo= cal-variable ...) (quote org-pcomplete-initial)) (set (make-local-variable = ...) (quote org-command-at-point)) (set (make-local-variable ...) (quote ig= nore)) (set (make-local-variable ...) (quote org-parse-arguments)) (set (ma= ke-local-variable ...) "") (if (and org-insert-mode-line-in-empty-file ... = ...) (insert "# -*- mode: org -*-\n\n")) ...) (progn (make-local-variable (quote delay-mode-hooks)) (let (...) (outline= -mode) (setq major-mode ...) (setq mode-name "Org") (progn ... ... ...) (us= e-local-map org-mode-map) (set-syntax-table org-mode-syntax-table) (setq lo= cal-abbrev-table org-mode-abbrev-table) (if ... ... ... ... ...) (org-load-= modules-maybe) (easy-menu-add org-org-menu) (easy-menu-add org-tbl-menu) (o= rg-install-agenda-files-menu) (if org-descriptive-links ...) (add-to-invisi= bility-spec ...) (add-to-invisibility-spec ...) (when ... ...) (org-set-loc= al ... org-outline-regexp) (org-set-local ... ...) (when ... ... ... ...) (= org-set-regexps-and-options) (when ... ...) (org-set-local ... "# ") (modif= y-syntax-entry 64 "w") (if org-startup-truncated ...) (org-set-local ... ..= .) (org-set-local ... t) (org-add-hook ... ... nil ...) (org-add-hook ... .= .. nil ...) (org-set-autofill-regexps) (setq indent-line-function ...) (org= -update-radio-target-regexp) (org-set-local ... ...) (org-set-local ... ...= ) (org-set-local ... ...) (if org-enforce-todo-dependencies ... ...) (if or= g-enforce-todo-checkbox-dependencies ... ...) (org-set-local ... "#") (org-= set-local ... " ") (org-set-local ... ...) (org-set-local ... ...) (if ... = ... ...) (and org-startup-with-beamer-mode ...) (set ... ...) (set ... ...)= (set ... ...) (set ... ...) (set ... "") (if ... ...) ...)) (delay-mode-hooks (outline-mode) (setq major-mode (quote org-mode)) (setq= mode-name "Org") (progn (if ... ...) (unless ... ...) (let ... ...)) (use-= local-map org-mode-map) (set-syntax-table org-mode-syntax-table) (setq loca= l-abbrev-table org-mode-abbrev-table) (if (featurep ...) (when ... ... ... = ...) (define-key org-mode-map [menu-bar headings] ...) (define-key org-mode= -map [menu-bar hide] ...) (define-key org-mode-map [menu-bar show] ...)) (o= rg-load-modules-maybe) (easy-menu-add org-org-menu) (easy-menu-add org-tbl-= menu) (org-install-agenda-files-menu) (if org-descriptive-links (add-to-inv= isibility-spec ...)) (add-to-invisibility-spec (quote ...)) (add-to-invisib= ility-spec (quote ...)) (when (featurep ...) (org-set-local ... t)) (org-se= t-local (quote outline-regexp) org-outline-regexp) (org-set-local (quote ou= tline-level) (quote org-outline-level)) (when (and org-ellipsis ... ... ...= ) (unless org-display-table ...) (set-display-table-slot org-display-table = 4 ...) (setq buffer-display-table org-display-table)) (org-set-regexps-and-= options) (when (and org-tag-faces ...) (org-set-tag-faces ... org-tag-faces= )) (org-set-local (quote calc-embedded-open-mode) "# ") (modify-syntax-entr= y 64 "w") (if org-startup-truncated (setq truncate-lines t)) (org-set-local= (quote font-lock-unfontify-region-function) (quote org-unfontify-region)) = (org-set-local (quote org-table-may-need-update) t) (org-add-hook (quote be= fore-change-functions) (quote org-before-change-function) nil (quote local)= ) (org-add-hook (quote kill-buffer-hook) (quote org-check-running-clock) ni= l (quote local)) (org-set-autofill-regexps) (setq indent-line-function (quo= te org-indent-line-function)) (org-update-radio-target-regexp) (org-set-loc= al (quote beginning-of-defun-function) (quote org-beginning-of-defun)) (org= -set-local (quote end-of-defun-function) (quote org-end-of-defun)) (org-set= -local (quote next-error-function) (quote org-occur-next-match)) (if org-en= force-todo-dependencies (add-hook ... ...) (remove-hook ... ...)) (if org-e= nforce-todo-checkbox-dependencies (add-hook ... ...) (remove-hook ... ...))= (org-set-local (quote comment-start) "#") (org-set-local (quote comment-pa= dding) " ") (org-set-local (quote align-mode-rules-list) (quote ...)) (org-= set-local (quote imenu-create-index-function) (quote org-imenu-get-tree)) (= if (or ... ...) (org-add-hook ... ... ... ...) (org-set-local ... ...)) (an= d org-startup-with-beamer-mode (org-beamer-mode 1)) (set (make-local-variab= le ...) (quote org-pcomplete-initial)) (set (make-local-variable ...) (quot= e org-command-at-point)) (set (make-local-variable ...) (quote ignore)) (se= t (make-local-variable ...) (quote org-parse-arguments)) (set (make-local-v= ariable ...) "") (if (and org-insert-mode-line-in-empty-file ... ...) (inse= rt "# -*- mode: org -*-\n\n")) (unless org-inhibit-startup (when org-sta= rtup-align-all-tables ...) (when org-startup-with-inline-images ...) (when = org-startup-indented ... ...) (unless org-inhibit-startup-visibility-stuff = ...))) org-mode() (progn (org-mode) (org-create-dblock props) (org-update-dblock) (font-loc= k-fontify-buffer) (forward-line 2) (buffer-substring (point) (progn ... ...= ))) (unwind-protect (progn (org-mode) (org-create-dblock props) (org-update-d= block) (font-lock-fontify-buffer) (forward-line 2) (buffer-substring ... ..= .)) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn ... = ... ... ... ... ...) (and ... ...))) (with-current-buffer temp-buffer (unwind-protect (progn ... ... ... ... .= .. ...) (and ... ...))) (let ((temp-buffer ...)) (with-current-buffer temp-buffer (unwind-protect= ... ...))) (with-temp-buffer (org-mode) (org-create-dblock props) (org-update-dblock= ) (font-lock-fontify-buffer) (forward-line 2) (buffer-substring (point) (pr= ogn ... ...))) org-get-clocktable(:link t :maxlevel 2 :tstart 734301 :tend 734308 :scope= agenda) apply(org-get-clocktable (:link t :maxlevel 2 :tstart 734301 :tend 734308= :scope agenda)) (setq tbl (apply (quote org-get-clocktable) p)) (let ((org-agenda-files ...) (p ...) tbl) (setq p (org-plist-delete p :bl= ock)) (setq p (plist-put p :tstart clocktable-start)) (setq p (plist-put p = :tend clocktable-end)) (setq p (plist-put p :scope ...)) (when (and ... ...= ) (setq p ...)) (setq tbl (apply ... p)) (insert tbl)) (progn (let (... ... tbl) (setq p ...) (setq p ...) (setq p ...) (setq p = ...) (when ... ...) (setq tbl ...) (insert tbl))) (if (and org-agenda-clockreport-mode clocktable-start) (progn (let ... ..= . ... ... ... ... ... ...))) (when (and org-agenda-clockreport-mode clocktable-start) (let (... ... tb= l) (setq p ...) (setq p ...) (setq p ...) (setq p ...) (when ... ...) (setq= tbl ...) (insert tbl))) (let* ((span ...) (today ...) (sd ...) (ndays ...) (org-agenda-start-on-w= eekday ...) (thefiles ...) (files thefiles) (start ...) (day-numbers ...) (= day-cnt 0) (inhibit-redisplay ...) s e rtn rtnall file date d start-pos end= -pos todayp clocktable-start clocktable-end filter) (setq org-agenda-redo-c= ommand (list ... ... start-day ...)) (dotimes (n ...) (push ... day-numbers= )) (setq day-numbers (nreverse day-numbers)) (setq clocktable-start (car da= y-numbers) clocktable-end (1+ ...)) (org-prepare-agenda "Day/Week") (org-se= t-local (quote org-starting-day) (car day-numbers)) (org-set-local (quote o= rg-include-all-loc) include-all) (org-set-local (quote org-agenda-current-s= pan) (org-agenda-ndays-to-span span)) (unless org-agenda-compact-blocks (le= t* ... ... ...) (add-text-properties s ... ...) (org-agenda-mark-header-lin= e s)) (while (setq d ...) (setq date ... s ...) (if ... ... ...) (setq file= s thefiles rtnall nil) (while ... ...) (if org-agenda-include-diary ...) (i= f ... ...)) (when (and org-agenda-clockreport-mode clocktable-start) (let .= .. ... ... ... ... ... ... ...)) (goto-char (point-min)) (or org-agenda-mul= ti (org-fit-agenda-window)) (unless (and ... ...) (goto-char ...) (recenter= -1) (if ... ...)) (goto-char (or start-pos 1)) (add-text-properties (point= -min) (point-max) (quote ...)) (if (eq org-agenda-show-log ...) (org-agenda= -show-clocking-issues)) (org-finalize-agenda) (setq buffer-read-only t) (me= ssage "")) org-agenda-list(nil nil week) eval((org-agenda-list (quote nil) nil (quote week))) (let nil (eval org-agenda-redo-command)) eval((let nil (eval org-agenda-redo-command))) org-let(nil (eval org-agenda-redo-command)) (let* ((org-agenda-keep-modes t) (filter org-agenda-filter) (preset ...) = (org-agenda-filter-while-redo ...) (cols org-agenda-columns-active) (line .= ..) (window-line ...) (lprops ...)) (put (quote org-agenda-filter) :preset-= filter nil) (and cols (org-columns-quit)) (message "Rebuilding agenda buffe= r...") (org-let lprops (quote ...)) (setq org-agenda-undo-list nil org-agen= da-pending-undo-list nil) (message "Rebuilding agenda buffer...done") (put = (quote org-agenda-filter) :preset-filter preset) (and (or filter preset) (o= rg-agenda-filter-apply filter)) (and cols (called-interactively-p ...) (org= -agenda-columns)) (org-goto-line line) (recenter window-line)) org-agenda-redo() org-agenda-clockreport-mode(nil) call-interactively(org-agenda-clockreport-mode nil nil) --8<---------------cut here---------------end--------------->8--- Emacs : GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of 2010-12-11 on raven, modified by Debian Package: Org-mode version 7.5 (release_7.5.384.g94b32)