From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)] Date: Sat, 25 Feb 2012 16:55:43 +0100 Message-ID: <87mx86x5z4.wl%dmaus@ictsoc.de> References: <87pqd3us27.wl%dmaus@ictsoc.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Sat_Feb_25_16:55:39_2012-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:43371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1JyT-0001Yj-5t for emacs-orgmode@gnu.org; Sat, 25 Feb 2012 10:55:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1JyN-0008Ea-QC for emacs-orgmode@gnu.org; Sat, 25 Feb 2012 10:55:53 -0500 Received: from app1a.xlhost.de ([213.202.242.161]:41365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1JyN-0008E4-KA for emacs-orgmode@gnu.org; Sat, 25 Feb 2012 10:55:47 -0500 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Dave Abrahams Cc: David Maus , emacs-orgmode@gnu.org --pgp-sign-Multipart_Sat_Feb_25_16:55:39_2012-1 Content-Type: text/plain; charset=US-ASCII At Sat, 25 Feb 2012 08:34:22 -0500, Dave Abrahams wrote: > > > on Sat Feb 25 2012, David Maus wrote: > > > Hi Dave, > > > > At Fri, 17 Feb 2012 22:48:13 -1000, > > Dave Abrahams wrote: > >> > >> [1 ] > >> > >> > >> Remember to cover the basics, that is, what you expected to happen and > >> what in fact did happen. You don't know how to make a good report? See > >> > >> http://orgmode.org/manual/Feedback.html#Feedback > >> > >> Your bug report will be posted to the Org-mode mailing list. > >> ------------------------------------------------------------------------ > >> > >> This function was misbehaving in a number of ways. The enclosed patch > >> represents the changes necessary to make it work properly, accumulated > >> over several weeks of testing. Sorry if the description is a bit vague. > > > > Thanks for the patch. I implemented the first to modifications (handle > > org-last-indirect-buffer being nil and window-live-p > > indirect-window). Your patch contained three modifications to `org-agenda-tree-to-indirect-buffer': 1. handle the case where there was no indirect buffer yet, i.e. (eq org-last-indirect-buffer nil) => applied 2. handle the case where the window of the last indirect buffer is no longer live => applied 3. set the subtree visibility according to the VISIBILITY property after the indirect buffer was created => no applied The third modification does not fix a bug, but is a useful feature. This should be implemented in `org-tree-to-indirect-buffer' and I'm going to do exactly this. Better? Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de --pgp-sign-Multipart_Sat_Feb_25_16:55:39_2012-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAk9JBH8ACgkQDMLgk1Evc4ULRAD8CZZy40JzA4TFyElB9kBFzsRH jS812jU0RHYMEcPx2+QA+gKt3keIlgPlMgSt8p44R1RqCekUPPYOPTf6kC79jEaa =ld1W -----END PGP SIGNATURE----- --pgp-sign-Multipart_Sat_Feb_25_16:55:39_2012-1--