Re: Bug: [patch] Fixes behavior of org-agenda-tree-to-indirect-buffer [7.8.02 (release_7.7.796.gc512)]

[David Maus <dmaus@ictsoc.de>]

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

At Sat, 25 Feb 2012 08:34:22 -0500,
Dave Abrahams wrote:
>
>
> on Sat Feb 25 2012, David Maus <dmaus-AT-ictsoc.de> wrote:
>
> > Hi Dave,
> >
> > At Fri, 17 Feb 2012 22:48:13 -1000,
> > Dave Abrahams wrote:
> >>
> >> [1  <text/plain (7bit)>]
> >>
> >>
> >> Remember to cover the basics, that is, what you expected to happen and
> >> what in fact did happen.  You don't know how to make a good report?  See
> >>
> >>      http://orgmode.org/manual/Feedback.html#Feedback
> >>
> >> Your bug report will be posted to the Org-mode mailing list.
> >> ------------------------------------------------------------------------
> >>
> >> This function was misbehaving in a number of ways.  The enclosed patch
> >> represents the changes necessary to make it work properly, accumulated
> >> over several weeks of testing.  Sorry if the description is a bit vague.
> >
> > Thanks for the patch. I implemented the first to modifications (handle
> > org-last-indirect-buffer being nil and window-live-p
> > indirect-window).

Your patch contained three modifications to `org-agenda-tree-to-indirect-buffer':

 1. handle the case where there was no indirect buffer yet, i.e.
    (eq org-last-indirect-buffer nil)

    => applied

 2. handle the case where the window of the last indirect buffer is no
    longer live

    => applied

 3. set the subtree visibility according to the VISIBILITY property
    after the indirect buffer was created

    => no applied

The third modification does not fix a bug, but is a useful
feature. This should be implemented in `org-tree-to-indirect-buffer'
and I'm going to do exactly this.

Better?

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]