From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [RFC] Change some defcustoms into defcont Date: Mon, 21 Oct 2013 10:56:02 +0200 Message-ID: <87mwm33sv1.fsf@gmail.com> References: <871u3g5nwx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYBHZ-00022V-2Z for emacs-orgmode@gnu.org; Mon, 21 Oct 2013 04:56:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYBHQ-0007yP-Mx for emacs-orgmode@gnu.org; Mon, 21 Oct 2013 04:56:13 -0400 Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:48228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYBHQ-0007yA-G7 for emacs-orgmode@gnu.org; Mon, 21 Oct 2013 04:56:04 -0400 Received: by mail-wg0-f44.google.com with SMTP id n12so6195349wgh.23 for ; Mon, 21 Oct 2013 01:56:03 -0700 (PDT) In-Reply-To: (Carsten Dominik's message of "Sun, 20 Oct 2013 20:23:37 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: Org Mode List Hello, Carsten Dominik writes: > I think this change breaks user setups. I don't know how many > people do change these keywords, but I know some do, if > only for localization purposes. I myself have modified the > archive keyword in some cases, if I use this feature for a > different purpose. I don't think it breaks their setup, since you can do: (setq org-deadline-string "SOMETHING:") Of course, if they change it with `custom-set-variables', they will have to change it. > You probably want to do this to make Org syntax less fragile. Correct. > However, I think it can also be achieved by leaving these as defcustom > and discouraging changes in the docstring with a standard sentence > about about deprecation. That's exactly the point of the defconst: you can still modify the variable, but it sends a strong message to the user. Also, it's not about deprecation: code base should still rely on these variables. > Your most important argument to me seems about efficiency of cashing. > We can fix this by providing :set methods for the customize entries > that will trigger global cache erasing, so that you do not need to > programmatically check this all the time. I know, and I still have to do it for variables like `org-todo-keywords', which are meant to be modified. My main concern is about core Org syntax. Regards, -- Nicolas Goaziou