From mboxrd@z Thu Jan  1 00:00:00 1970
From: Achim Gratz <Stromeko@nexgo.de>
Subject: Re: [PATCH] Fixed bug in org-entry-get-with-inheritance
Date: Mon, 17 Mar 2014 20:49:24 +0100
Message-ID: <87mwgoppvf.fsf@Rainer.invalid>
References: <lfbote$vv9$1@ger.gmane.org> <87bnx9qbcq.fsf@bzg.ath.cx>
	<87vbvcptqt.fsf@Rainer.invalid> <87ob14d4o7.fsf@bzg.ath.cx>
	<87r460pr8d.fsf@Rainer.invalid> <87ha6wd3hg.fsf@bzg.ath.cx>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1WPdXe-00033u-4U
	for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:49:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1WPdXY-0006df-Dv
	for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:49:46 -0400
Received: from plane.gmane.org ([80.91.229.3]:33145)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1WPdXY-0006db-7f
	for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 15:49:40 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1WPdXV-00020c-Jv
	for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 20:49:37 +0100
Received: from pd9eb1a5e.dip0.t-ipconnect.de ([217.235.26.94])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Mon, 17 Mar 2014 20:49:37 +0100
Received: from Stromeko by pd9eb1a5e.dip0.t-ipconnect.de with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Mon, 17 Mar 2014 20:49:37 +0100
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Bastien writes:
> Achim Gratz <Stromeko@nexgo.de> writes:
>
>>> Can you tell a bit more about what's wrong with the test?
>>
>> There is nothing wrong with those tests.
>
> I meant: can you tell me how the tests fail?

They don't produce the result they are supposed to produce.

> I'm interested in the answer.

make BTEST_RE='\\(header-arg-defaults\\|property-accumulation\\)' test-dirty

>>> If the patch is good and the tests are outdated, I'd rather
>>> fix the tests than revert the patch to re-revert it again.
>>
>> No, the patch is bad, otherwise it wouldn't break the tests.
>
> Sorry, I don't buy this.

I'm not selling anything.

> Or maybe explain me why the patch is wrong.

It breaks property inheritance and accumulation.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada