From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Abrahamsen Subject: Re: [RFC] Rewrite indentation functions Date: Sun, 04 May 2014 11:39:26 +0800 Message-ID: <87mweyb4b5.fsf@ericabrahamsen.net> References: <87oazjnf55.fsf@gmail.com> <87d2fwhh95.fsf@ericabrahamsen.net> <87fvksoctz.fsf@gmail.com> <87oazffgne.fsf@ericabrahamsen.net> <8738grw8nn.fsf@ericabrahamsen.net> <87tx97ozhr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgnE2-0007bA-Bg for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:36:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgnDw-0007MR-6m for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:36:26 -0400 Received: from plane.gmane.org ([80.91.229.3]:39917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgnDw-0007ML-0b for emacs-orgmode@gnu.org; Sat, 03 May 2014 23:36:20 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WgnDt-0002vA-Tb for emacs-orgmode@gnu.org; Sun, 04 May 2014 05:36:17 +0200 Received: from 111.197.167.19 ([111.197.167.19]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 04 May 2014 05:36:17 +0200 Received: from eric by 111.197.167.19 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 04 May 2014 05:36:17 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > Hello, > > Eric Abrahamsen writes: > >>> Right now I'm seeing breakage with `org-set-property' -- this only >>> happens on the indentation patches branch. Adding an EXPORT_AUTHOR >>> property with that command, value of "asdfadsf", gives me this: >>> >>> * Test Heading >>> :PROPERTIES: >>> >>> :EXPORT_AUTHOR: asdfasdfnil nil >>> >>> Extra blank nil, spurious "nils", and no :END: One last thing! In the course of this I also noticed that, in a buffer that contains a broken property drawer, you can't set properties on *any* other heading. When `org-buffer-property-keys' goes looking for valid keys used elsewhere in the current buffer, it calls `org-get-property-block' on the broken drawer, and errors when that function returns nil. I tried changing the call to (org-get-property-block nil nil t), and that seems to solve it: at least the broken drawer is repaired, and I can successfully set properties. Dunno if that's the right way to handle it, though. Eric