From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] lisp/ob-sql.el: add support for :dbport parameter
Date: Tue, 07 Apr 2015 22:27:33 +0200
Message-ID: <87mw2jptu2.fsf@nicolasgoaziou.fr>
References: <m28ue5ov11.fsf@mbp.Dlink> <87zj6kpilk.fsf@nicolasgoaziou.fr>
	<m26197q1ri.fsf@mbp.Dlink>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Yfa4i-0002Zt-48
	for emacs-orgmode@gnu.org; Tue, 07 Apr 2015 16:26:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Yfa4d-0005q5-QI
	for emacs-orgmode@gnu.org; Tue, 07 Apr 2015 16:26:20 -0400
Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:50225)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Yfa4d-0005pq-KS
	for emacs-orgmode@gnu.org; Tue, 07 Apr 2015 16:26:15 -0400
In-Reply-To: <m26197q1ri.fsf@mbp.Dlink> ("Saulius
	\=\?utf-8\?Q\?Menkevi\=C4\=8Di\?\=
	\=\?utf-8\?Q\?us\=22's\?\= message of
	"Tue, 07 Apr 2015 20:36:17 +0300")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Saulius =?utf-8?Q?Menkevi=C4=8Dius?= <saulius.menkevicius@gmail.com>
Cc: emacs-orgmode@gnu.org

Saulius Menkevi=C4=8Dius <saulius.menkevicius@gmail.com> writes:

> Apparently it is not a string. I don't know the internal machinery for
> #+header parameters in org-mode/babel, but apparently number-to-string
> is required, otherwise I get the "progn: Wrong type argument: sequencep,
> 33060" error. Where 33060 is my port number from the :dbport param.

OK. I slightly changed this line.

>> Nitpick: `assoc' -> `assq'
>
> Ok. I did not know much of elisp to decide on which one to. This was
> copy-paste code from previous line, sorry.

The previous lines should use `assq', but that's not very important.

> Updated patch is attached to this mail.

Applied. Thank you.


Regards,