From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serge Kosyrev <_deepfire@feelingofgreen.ru> Subject: Re: Changes to contrib Date: Mon, 09 Nov 2015 23:44:26 +0300 Message-ID: <87mvumnbrp.fsf@feelingofgreen.ru> References: <87vb9cdauy.fsf@andromedae.feelingofgreen.ru> <87bnb4y527.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <_deepfire@feelingofgreen.ru>) id 1Zvtt1-0006VS-Oz for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 16:22:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <_deepfire@feelingofgreen.ru>) id 1Zvtsy-0007up-JA for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 16:21:59 -0500 Received: from [80.92.100.69] (port=45579 helo=mail.feelingofgreen.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <_deepfire@feelingofgreen.ru>) id 1Zvtsy-0007ul-Bg for emacs-orgmode@gnu.org; Mon, 09 Nov 2015 16:21:56 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Rasmus writes: > Kosyrev Serge <_deepfire@feelingofgreen.ru> writes: [..] >> I don't know what is the proper way to submit patches for the contrib/ >> directory, so I made a branch on github: >> >> https://github.com/deepfire/org-mode/commits/ox-taskjuggler-fixes >> >> Please, do tell how you would like to proceed from there. > > Please see > > http://orgmode.org/worg/org-contribute.html > > TL;DR: git format-patch. > > Do you have signed FSF papers? No, didn't. > I don't know if there's any desire to move ox-taskjuggler.el to core, > nor whether it would be possible (since I don=E2=80=99t know if "tj" and > Baptiste have signed FSF papers). I'm not sure how wise it would be to raise barriers for contribution, given the current state of the thing.. > Some quick comments from skimming your code (note, I have no idea what a > taskjuggler is): > > I don=E2=80=99t know what you refer to explicitly. But that should be fi= xed, I > guess. I'm sorry, what should be? > I think you add some more taskjuggle keywords/properties for > example. [...] > Also, you introduce a dependency on subr-x, which may or may not be an > issue since it=E2=80=99s in contrib. I'm sorry, I'm not sure what do you mean? I looked at subr-x.el, and I didn't find any reference to any of those functions.. > org-export-map-special-nodes and org-element-multivalued-property are not > proper names, as they will supposedly only be used in ox-taskjuggler. Well, the functions themselves are supposed to be generic. There are two ways to name a function, in my mind: - by intended application - by what it does ..it's just that I chose the second.. in the futile hope that someone, sometime will move/use them. : -) If you deem it not to be an appropriate course of thought, I will change the name, sure. --=20 =D1=81 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8e=D0=BC / respectfully, =D0=9A=D0=BE=D1=81=D1=8B=D1=80=D0=B5=D0=B2 =D0=A1=D0=B5=D1=80=D0=B3=D0=B5= =D0=B9