From: Matt Lundin <mdl@imapmail.org>
To: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [BUG] error with org-refile and ido-completion-help
Date: Tue, 31 May 2016 16:49:38 -0500 [thread overview]
Message-ID: <87mvn5aohd.fsf@fastmail.fm> (raw)
In-Reply-To: <87shwyko6o.fsf@saiph.selenimh> (Nicolas Goaziou's message of "Tue, 31 May 2016 21:44:15 +0200")
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>> A git bisect revealed that the change was introduced in 2015 with the
>> following commit:
>>
>> ,----
>> | commit 50ba0a5ed609f3600f2590f3ba22b8ab3ff3331c
>> | Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> | Date: Sun Jun 7 00:38:58 2015 +0200
>> |
>> | Fix 1a7364177046b8a57ade0aeb9f52bacfc0b8b088
>> |
>> | * lisp/org.el (org-icompleting-read): Let `completing-read' or
>> | equivalent sort out type of completion.
>> | (org-olpath-completing-read): Revert partially
>> | 1a7364177046b8a57ade0aeb9f52bacfc0b8b088.
>> `----
>>
>> It looks like this commit removed some functionality from the now
>> obsolete org-icompleting-read that made sure that the items in the
>> completion list passed to the completing read function were strings.
>
> Actually, this is a bug in "ido.el", since `ido-completing-read' is not
> a drop-in replacement for `completing-read'. The latter accepts lists
> of strings, but also alist, obarrays and hash tables. The former accepts
> only list of strings.
>
> I suggest to report the bug to "ido.el" maintainers since they probably
> want to preserve compatibility between the completion functions.
OK. Thanks. I see that a bug report has been on the emacs list since
2013:
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15430
For the time being, it's easy enough to write a custom wrapper around
ido-completing-read, so I think I'll do that.
It's worth nothing that the author of patch that originally added the
completing-read-function variable did not anticipate that
ido-completing-read would be a simple drop-in for completing-read:
http://thread.gmane.org/gmane.emacs.devel/134000
For a long time (since at least 2009), org-mode had built-in support for
ido-mode completion when refiling. So this does seem to be a deprecation
of longstanding org-mode functionality.
I'll see if we can add something to the docstrings to alert of the need
to write a wrapper around ido-completing-read.
Matt
next prev parent reply other threads:[~2016-05-31 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 21:40 [BUG] error with org-refile and ido-completion-help Matt Lundin
2016-05-31 19:44 ` Nicolas Goaziou
2016-05-31 21:49 ` Matt Lundin [this message]
2016-06-01 17:08 ` Matt Lundin
2016-06-01 17:32 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvn5aohd.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).