emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Carlo Nucera <meditans@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH]: Fix latex image bug in org-mime-org-buffer-htmlize
Date: Tue, 14 Jun 2016 14:25:50 +0200	[thread overview]
Message-ID: <87mvmo0xf5.fsf@saiph.selenimh> (raw)
In-Reply-To: <CALaN21OuTZ_JMwXP66-H7Uzm=MTHg5cLCAArLJaHv--E_XXuzg@mail.gmail.com> (Carlo Nucera's message of "Sat, 11 Jun 2016 01:32:47 +0200")

Hello,

Carlo Nucera <meditans@gmail.com> writes:

> attached is a patch that should fix a bug in the function
> org-mime-org-buffer-htmlize (thanks to punchagan on irc!).
>
> When exporting an org buffer with a latex snippet including the org
> option tex: dvipng the images were always created in /tmp/ltxpng/, but
> the reported link in the htmlized buffer was the local ./ltxpng folder;
> so, unless the org file to htmlize was actually in /tmp, the user got an
> error saying that the image could not be found.
>
> This was caused by the two different ways in which the function
> org-mime-replace-images is used inside of org-mime-org-buffer-htmlize
> and org-mime-htmlize.
>
> To correct the problem, the function org-mime-replace-images doesn't
> take anymore the current-file parameter (that was only used to get its
> directory) and instead always creates a temporary directory using
> temporary-file-directory.

I amended the commit message so as to include references to the
functions being modified, and applied the patch. Thank you.

Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2016-06-14 12:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 23:32 [PATCH]: Fix latex image bug in org-mime-org-buffer-htmlize Carlo Nucera
2016-06-14 12:25 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvmo0xf5.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=meditans@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).