From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: "Emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [BUG] Dynamic scoping of project-plist in preparation-function
Date: Wed, 22 Jun 2016 15:34:17 +0200 [thread overview]
Message-ID: <87mvmd8i06.fsf@saiph.selenimh> (raw)
In-Reply-To: <87wplhiwnn.fsf@systemreboot.net> (Arun Isaac's message of "Wed, 22 Jun 2016 11:37:40 +0530")
Hello,
Arun Isaac <arunisaac@systemreboot.net> writes:
>> 2. Require preparation functions to accept one parameter, the project
>> plist.
>
> I think adding project-plist as a parameter to preparation functions is
> definitely more elegant.
Done in 5cd793c.
> But, I also came across this old thread where it was noted that making
> project-plist a proper parameter, instead of it being dynamically scoped
> into the preparation function, would break a lot of code.
Bad code deserves to be broken anyway.
More seriously, the fix is trivial, so I don't think this is an issue.
Thank you for the feedback.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2016-06-22 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 18:16 [BUG] Dynamic scoping of project-plist in preparation-function Arun Isaac
2016-06-21 20:15 ` Nicolas Goaziou
2016-06-22 6:07 ` Arun Isaac
2016-06-22 13:34 ` Nicolas Goaziou [this message]
2016-06-22 14:37 ` Arun Isaac
2016-06-22 16:37 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvmd8i06.fsf@saiph.selenimh \
--to=mail@nicolasgoaziou.fr \
--cc=arunisaac@systemreboot.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).