From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: ob-lua
Date: Mon, 22 Aug 2016 11:28:45 +0200
Message-ID: <87mvk5w3si.fsf@saiph.selenimh>
References: <87bn0of273.fsf@dell-desktop.WORKGROUP>
	<87h9af1la2.fsf@saiph.selenimh>
	<87eg5ik9t7.fsf@dell-desktop.WORKGROUP>
	<878tvq1nbx.fsf@saiph.selenimh>
	<87a8g5edep.fsf@dell-desktop.WORKGROUP>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36442)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bblXE-0001yb-Ng
	for emacs-orgmode@gnu.org; Mon, 22 Aug 2016 05:28:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bblXC-0006LZ-Kg
	for emacs-orgmode@gnu.org; Mon, 22 Aug 2016 05:28:47 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:46679)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bblXC-0006LE-Ev
	for emacs-orgmode@gnu.org; Mon, 22 Aug 2016 05:28:46 -0400
In-Reply-To: <87a8g5edep.fsf@dell-desktop.WORKGROUP> (Thibault Marin's message
	of "Sun, 21 Aug 2016 21:38:22 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Thibault Marin <thibault.marin@gmx.com>
Cc: Dieter Schoen <dieter@schoen.or.at>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

Hello,

Thibault Marin <thibault.marin@gmx.com> writes:

> The attached patch (using git format-patch) is adding test-ob-lua.el and
> ob-lua.el.  My contribution to ob-lua.el is only a tiny patch on top of
> Dieter's ob-lua.el but it appears as a new file in the patch, since
> ob-lua.el is not currently in the repository.

That is not a problem. We can make this appear as two patches.

> I am still a bit confused about this (make test complains about a
> missing dependency for ob-lua, maybe because it is in contrib/lisp?),
> but I can run the test using the command line emacs --batch command
> described in testing/README, and it does not require any change to
> org-test.el, so I'll run tests this way from now on.

The point is to add it to core Org, not to contrib/, isn't it?

> Please let me know if some other changes are needed.  Thanks for the
> guidance.

It looks good. Thank you.

I noticed stardiviner (Cc'ed) also provides "ob-lua" on MELPA, although
Dieter's predates it.

Stardiviner, what is the status of your library wrt to the one provided
in this thread ? Is the latter a superset of yours, or are there some
features that could be merged/improved with your code?


Regards,

-- 
Nicolas Goaziou