Re: Patch on org-agenda-cmp-user-defined not called

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Li Zhuo <fantanstic@gmail.com> writes:

> Subject: [PATCH] fix `org-agenda-cmp-user-defined` not called when user has
>  defined it
>
> ---
>  lisp/org-agenda.el | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 652fada..3a0248e 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -7007,10 +7007,9 @@ their type."
>  	 (alpha-down      (if alpha-up (- alpha-up) nil))
>  	 (need-user-cmp   (org-em 'user-defined-up 'user-defined-down ss))
>  	 user-defined-up user-defined-down)
> -    (if (and need-user-cmp org-agenda-cmp-user-defined
> -	     (functionp org-agenda-cmp-user-defined))
> +    (if (and need-user-cmp (functionp 'org-agenda-cmp-user-defined))
>  	(setq user-defined-up
> -	      (funcall org-agenda-cmp-user-defined a b)
> +	      (funcall 'org-agenda-cmp-user-defined a b)
>  	      user-defined-down (if user-defined-up (- user-defined-up) nil)))
>      (cdr (assoc
>  	  (eval (cons 'or org-agenda-sorting-strategy-selected))

Thank you.

However, I don't understand what your patch is fixing. Could you exhibit
the problem with a simple recipe?

Regards,

-- 
Nicolas Goaziou