Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Bernt Hansen]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
Hi!

With the below org file tags handling behaves in a surprising way.


* TODO Test Parent                                          :PRODUCTION:MISC:
** TODO foo                                                             :BAR:
** keys to reproduce


1) At beginning of line 2 on TODO foo
2) M-ret to insert a new heading before foo
3) S-ret to get TODO keyword
   - auto fills :PRODUCTION:MISC: tags ?
4) SPC now does not work to insert a space after the TODO so I can type my headline
   I have to use C-f
5) C-c C-q on this line now removes both tags
   I thought this was a bug but it seems to be removing tags that are defined 
   by the parent tasks and maybe that is intentional
6) When I enter a parent tag C-c C-q MISC RET it is displayed and then removed if I do another C-c C-q
   This was surprising to me and I thought tag handling was completely broken
   Until I tried a tag not in a parent task
   try C-c C-q TAB MISC RET
   C-c C-q TAB PRODUCTION RET

Thanks for all your amazing work on org-mode!

Best regards,
Bernt

====== minimal.emacs ==========================================================================
(add-to-list 'load-path "C:/D-Drive/bin/org-mode/lisp/")
(add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
(require 'org)

(global-set-key "\C-cl" 'org-store-link)
(global-set-key "\C-ca" 'org-agenda)
(global-set-key "\C-cb" 'org-iswitchb)
====== test.el-emacs ==========================================================================
(setq org-agenda-tags-todo-honor-ignore-options t)
(setq org-fast-tag-selection-single-key (quote expert))
(setq org-tag-alist (quote ((:startgroup)
			    ("S1" . ?1)
			    ("S2" . ?2)
			    ("S3" . ?3)
			    (:endgroup)
			    ("WAITING" . ?w)
			    ("HOLD" . ?h)
			    ("PERSONAL" . ?P)
			    ("FS" . ?f)
			    ("DEFECT" . ?d)
			    ("DEV" . ?D)
			    ("QA" . ?Q)
			    ("MISC" . ?M)
			    ("crypt" . ?E)
			    ("CANCELLED" . ?c)
			    ("FLAGGED" . ??))))
(setq org-tags-match-list-sublevels t)
(setq org-todo-keyword-faces
      (quote (("TODO" :foreground "red" :weight bold)
	      ("NEXT" :foreground "blue" :weight bold)
	      ("MEETING" :foreground "forest green" :weight bold)
	      ("DONE" :foreground "forest green" :weight bold)
	      ("WAITING" :foreground "orange" :weight bold)
	      ("DELEGATED" :foreground "orange" :weight bold)
	      ("HOLD" :foreground "magenta" :weight bold)
	      ("PASS" :foreground "forest green" :weight bold)
	      ("FAIL" :foreground "red" :weight bold)
	      ("CANCELLED" :foreground "forest green" :weight bold))))
(setq org-todo-keywords
      (quote ((sequence "TODO(t/!)" "NEXT(n/!)" "|" "DONE(d/!)")
	      (sequence "WAITING(w@/!)" "HOLD(h@/!)" "|" "CANCELLED(c@/!)" "MEETING"))))

(setq org-todo-state-tags-triggers
      (quote (("CANCELLED" ("CANCELLED" . t))
	      ("WAITING" ("WAITING" . t))
	      ("HOLD" ("WAITING") ("HOLD" . t))
	      (done ("WAITING") ("HOLD"))
	      ("TODO" ("WAITING") ("CANCELLED") ("HOLD") ("DELEGATED"))
	      ("NEXT" ("WAITING") ("CANCELLED") ("HOLD") ("DELEGATED"))
	      ("DONE" ("WAITING") ("CANCELLED") ("HOLD") ("DELEGATED"))
	      ("DELEGATED" ("DELEGATED" . t) ("WAITING") ("CANCELLED") ("HOLD"))
	      ("PASS" ("WAITING") ("CANCELLED") ("HOLD")))))

Emacs  : GNU Emacs 25.1.1 (x86_64-w64-mingw32)
 of 2016-09-17
Package: Org mode version 9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)

current state:
==============
(setq
 org-agenda-tags-todo-honor-ignore-options t
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
		      org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-activate
			  org-babel-speed-command-activate)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-tab-before-tab-emulation-hook '(org-tempo-complete-tag)
 org-todo-keyword-faces '(("TODO" :foreground "red" :weight bold)
			  ("NEXT" :foreground "blue" :weight bold)
			  ("MEETING" :foreground "forest green" :weight bold)
			  ("DONE" :foreground "forest green" :weight bold)
			  ("WAITING" :foreground "orange" :weight bold)
			  ("DELEGATED" :foreground "orange" :weight bold)
			  ("HOLD" :foreground "magenta" :weight bold)
			  ("PASS" :foreground "forest green" :weight bold)
			  ("FAIL" :foreground "red" :weight bold)
			  ("CANCELLED" :foreground "forest green" :weight bold)
			  )
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
		     org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(org-tempo-setup
		 #[0 "\300\301\302\303\304$\207"
		   [add-hook change-major-mode-hook org-show-all append local]
		   5]
		 #[0 "\300\301\302\303\304$\207"
		   [add-hook change-major-mode-hook org-babel-show-result-all
		    append local]
		   5]
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-bibtex-headline-format-function #[257 "\300\x01\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
 org-todo-state-tags-triggers '(("CANCELLED" ("CANCELLED" . t))
				("WAITING" ("WAITING" . t))
				("HOLD" ("WAITING") ("HOLD" . t))
				(done ("WAITING") ("HOLD"))
				("TODO" ("WAITING") ("CANCELLED") ("HOLD")
				 ("DELEGATED"))
				("NEXT" ("WAITING") ("CANCELLED") ("HOLD")
				 ("DELEGATED"))
				("DONE" ("WAITING") ("CANCELLED") ("HOLD")
				 ("DELEGATED"))
				("DELEGATED" ("DELEGATED" . t) ("WAITING")
				 ("CANCELLED") ("HOLD"))
				("PASS" ("WAITING") ("CANCELLED") ("HOLD")))
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-todo-keywords '((sequence "TODO(t/!)" "NEXT(n/!)" "|" "DONE(d/!)")
		     (sequence "WAITING(w@/!)" "HOLD(h@/!)" "|"
		      "CANCELLED(c@/!)" "MEETING")
		     )
 org-fast-tag-selection-single-key 'expert
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("id" :follow org-id-open)
		       ("eww" :follow eww :store org-eww-store-link)
		       ("rmail" :follow org-rmail-open :store
			org-rmail-store-link)
		       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
		       ("irc" :follow org-irc-visit :store org-irc-store-link
			:export org-irc-export)
		       ("info" :follow org-info-open :export org-info-export
			:store org-info-store-link)
		       ("gnus" :follow org-gnus-open :store
			org-gnus-store-link)
		       ("docview" :follow org-docview-open :export
			org-docview-export :store org-docview-store-link)
		       ("bibtex" :follow org-bibtex-open :store
			org-bibtex-store-link)
		       ("bbdb" :follow org-bbdb-open :export org-bbdb-export
			:complete org-bbdb-complete-link :store
			org-bbdb-store-link)
		       ("w3m" :store org-w3m-store-link) ("file+sys")
		       ("file+emacs") ("doi" :follow org--open-doi-link)
		       ("elisp" :follow org--open-elisp-link)
		       ("file" :complete org-file-complete-link)
		       ("ftp" :follow
			(lambda (path) (browse-url (concat "ftp:" path))))
		       ("help" :follow org--open-help-link)
		       ("http" :follow
			(lambda (path) (browse-url (concat "http:" path))))
		       ("https" :follow
			(lambda (path) (browse-url (concat "https:" path))))
		       ("mailto" :follow
			(lambda (path) (browse-url (concat "mailto:" path))))
		       ("news" :follow
			(lambda (path) (browse-url (concat "news:" path))))
		       ("shell" :follow org--open-shell-link))
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-tag-alist '((:startgroup) ("S1" . 49) ("S2" . 50) ("S3" . 51) (:endgroup)
		 ("WAITING" . 119) ("HOLD" . 104) ("PERSONAL" . 80)
		 ("FS" . 102) ("DEFECT" . 100) ("DEV" . 68) ("QA" . 81)
		 ("MISC" . 77) ("crypt" . 69) ("CANCELLED" . 99)
		 ("FLAGGED" . 63))
 )

Re: Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Bastien]

Hi Bernt,

glad to read you!

Bernt Hansen <bernt@norang.ca> writes:

> With the below org file tags handling behaves in a surprising way.

Thanks for the report - just a quick check, do you have these
issues on the maint branch as well or just on master?

No problem if you cannot check, just thought you might have.

Thanks!

-- 
 Bastien

Re: Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Bernt Hansen]

Bastien <bzg@gnu.org> writes:

> Hi Bernt,
>
> glad to read you!
>

Hi Bastien!  I have been away from this list for far too long -- hoping
to correct that.

> Bernt Hansen <bernt@norang.ca> writes:
>
>> With the below org file tags handling behaves in a surprising way.
>
> Thanks for the report - just a quick check, do you have these
> issues on the maint branch as well or just on master?

master branch only.  maint works fine.
I have been on maint for a week or two and tried master due to the
pending release plans.

Thanks,
Bernt

Re: Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Nicolas Goaziou]

Hello,

Bernt Hansen <bernt@norang.ca> writes:

> With the below org file tags handling behaves in a surprising way.
>
>
> * TODO Test Parent                                          :PRODUCTION:MISC:
> ** TODO foo                                                             :BAR:
> ** keys to reproduce
>
>
> 1) At beginning of line 2 on TODO foo
> 2) M-ret to insert a new heading before foo
> 3) S-ret to get TODO keyword
>    - auto fills :PRODUCTION:MISC: tags ?
> 4) SPC now does not work to insert a space after the TODO so I can type my headline
>    I have to use C-f
> 5) C-c C-q on this line now removes both tags
>    I thought this was a bug but it seems to be removing tags that are defined 
>    by the parent tasks and maybe that is intentional
> 6) When I enter a parent tag C-c C-q MISC RET it is displayed and then removed if I do another C-c C-q
>    This was surprising to me and I thought tag handling was completely broken
>    Until I tried a tag not in a parent task
>    try C-c C-q TAB MISC RET
>    C-c C-q TAB PRODUCTION RET

I think this is now fixed. Could you confirm it?

Thank you!

Regards,

-- 
Nicolas Goaziou

Re: Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Bastien]

Hi Bernt,

Bernt Hansen <bernt@norang.ca> writes:

> Hi Bastien!  I have been away from this list for far too long -- hoping
> to correct that.

I hope too!

As Org keeps moving forward with rewritten and new functionalities,
it's essential to get tests and feedback from long-time power users.

-- 
 Bastien

Re: Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Bastien]

Hi Nicolas,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

>> 4) SPC now does not work to insert a space after the TODO so I can type my headline
>>    I have to use C-f

I still have this issue with current master.

Those lines in `org--align-tags-here' are problematic:

 (skip-chars-backward " \t")
 (delete-region (point) (match-beginning 1))

Because the outer save-excursion in `org-align-tags' is
then ignored.

-- 
 Bastien

Re: Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Nicolas Goaziou]

Hello,

Bastien <bzg@gnu.org> writes:

>>> 4) SPC now does not work to insert a space after the TODO so I can type my headline
>>>    I have to use C-f
>
> I still have this issue with current master.


Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Re: Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Bernt Hansen]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Bastien <bzg@gnu.org> writes:
>
>>>> 4) SPC now does not work to insert a space after the TODO so I can type my headline
>>>>    I have to use C-f
>>
>> I still have this issue with current master.
>
>
> Fixed. Thank you.

Confirmed.  Thanks!!!

I am always amazed at how fast bugs are addressed on this project.
Great job!

Bernt

Re: Bug: Usability for tags in master branch [9.1.12 (release_9.1.12-646-gb08245 @ c:/D-Drive/bin/org-mode/lisp/)]

[Bastien]

Hi Bernt,

Bernt Hansen <bernt@norang.ca> writes:

>> Fixed. Thank you.
>
> Confirmed.  Thanks!!!

Indeed, thanks too!

> I am always amazed at how fast bugs are addressed on this project.

That's because the place we report bugs is also the place we solve
them ;)

-- 
 Bastien