From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Holst Subject: Re: org-capture regression? Date: Thu, 20 Sep 2018 16:01:26 +0200 Message-ID: <87musc46a1@Boerne> References: <87r2ho60xn.fsf@gmx.de> <87sh24gwk0.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2zWQ-0003j9-Be for emacs-orgmode@gnu.org; Thu, 20 Sep 2018 10:01:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2zWN-00011l-6H for emacs-orgmode@gnu.org; Thu, 20 Sep 2018 10:01:34 -0400 Received: from mout.gmx.net ([212.227.15.18]:42789) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2zWM-0000wr-SX for emacs-orgmode@gnu.org; Thu, 20 Sep 2018 10:01:31 -0400 In-Reply-To: <87sh24gwk0.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Thu, 20 Sep 2018 14:53:03 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hello, =B7 Nicolas Goaziou wrote: > Thomas Holst writes: >> [...snip...] >> So here is I patch I came up with to re-enable theese features: > > Thank you. However, I have two issues with it. > > The first one is that I don't like `eval'. See, for example, this > excerpt from the Elisp manual: > > On rare occasions, you may need to write code that evaluates a form > that is computed at run time, such as after reading a form from text > being edited or getting one from a property list. On these > occasions, use the =91eval=92 function. Often =91eval=92 is not neede= d and > something else should be used instead. For example, to get the value > of a variable, while =91eval=92 works, =91symbol-value=92 is preferab= le; or > rather than store expressions in a property list that then need to > go through =91eval=92, it is better to store functions instead that a= re > then passed to =91funcall=92. > > So, I'd rather use `symbol-value' and `funcall' and forbid arbitrary > Sexps. > > Also, this introduces a discrepancy between :table-line-pos and other > parameters, which do not allow variables nor functions. This is another > issue. > > IOW, it may need be to be implemented at a lower level, with proper > tooling. > > WDYT? For me this sounds resonalble. Basically I am an elisp novice. I will try to implement the feature like explaind above in `org-capture-get'. So it can be used for other parameters. When I have questions or a few lines of code I will come back here. Right now I can live with my solution for my personal needs. Since my time for working on this is limited it might take some time. It seems that nobody else is missing this feature. So I will take the oportunity and find my way through elisp. -- Bis neulich ... Thomas