emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: cesar mena <cesar.mena@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: please read: bug when marking tasks done
Date: Tue, 08 Jan 2019 11:24:12 +0100	[thread overview]
Message-ID: <87muobcur7.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <871s5o8pgf.fsf@gnu.org> (cesar mena's message of "Mon, 07 Jan 2019 10:20:00 -0500")

Hello,

cesar mena <cesar.mena@gmail.com> writes:

> as per the documentation for "org-auto-repeat-maybe" only the base date
> of repeating deadline/scheduled time stamps should change. AFAICT the
> patch changes every occurrence of an inactive repeating timestamp that is
> not a comment.

The base date of a time stamp is the part before the repeater. IOW,
every time stamp with a repeater has a base date, therefore
`org-auto-repeat-maybe' changes them all. I see no problem with the
docstring.

>> I think a solution would be to remove the repeater from timestamps
>> inserted upon logging a state change or a re-scheduling.
>
> but that is useful and correct information. it lets me know the state of
> the scheduled timestamp at the time i rescheduled; you are proposing to
> change this to avoid a re-computation for data that i am sure we agree
> should be treated as immutable.

I don't think we agree about the immutable part. At least, the user who
reported the bug solved in af81211fdc01b64449179bcdb77fb1c8ecb3fb94
didn't agree. Inactive time stamps are not immutable.

But the main issue is that I don't understand what useful and correct
information we loose if we drop the repeater part, i.e.:

  - Rescheduled from "[2019-02-05 Tue .+1m]" on [2018-09-29 Sat 18:50]

to

  - Rescheduled from "[2019-02-05 Tue]" on [2018-09-29 Sat 18:50]

> note that the from dates in the "Rescheduled" line is also in quotes
> indicating that it is textual information. no longer in play. changing
> such dates is akin to changing dates in a comment.
>
> what do you think?

I think quotes are not comment syntax in Org, so it means nothing
programatically.

Anyway, I don't really have any other idea besides dropping the repeater
part from automatically inserted inactive time stamps. 

You may want to read the thread in the commit message referenced above
and possibly discuss with the bug reporter to find an acceptable middle
ground.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2019-01-08 10:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-06  0:13 please read: bug when marking tasks done cesar mena
2019-01-06 23:49 ` Nicolas Goaziou
2019-01-07 14:52   ` Bernt Hansen
2019-01-07 15:20   ` cesar mena
2019-01-08 10:24     ` Nicolas Goaziou [this message]
2019-01-08 14:29       ` Bernt Hansen
2019-01-08 20:07       ` cesar mena
2019-01-09 22:50         ` Nicolas Goaziou
2019-01-10 14:15           ` cesar mena
2019-01-12 11:24             ` Nicolas Goaziou
2019-01-12 14:23               ` cesar mena
2019-01-12 19:37                 ` Samuel Wales
2019-01-12 21:02                   ` Samuel Wales
2019-01-13 15:00                   ` Nicolas Goaziou
2019-01-13 20:16                 ` Nicolas Goaziou
2019-01-13 21:52                   ` Samuel Wales
2019-01-15 14:24                     ` Bernt Hansen
2019-01-15 16:43                   ` cesar mena
2019-01-15 23:11                     ` Samuel Wales
2019-01-15 23:18                       ` Samuel Wales
2019-01-27 21:08                       ` Nicolas Goaziou
2019-01-29 14:58                         ` Robert Horn
2019-01-30 12:22                         ` cesar mena
2019-01-30 21:52                           ` Nicolas Goaziou
2019-01-31 10:25                             ` cesar mena
2019-01-31 23:17                               ` Samuel Wales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87muobcur7.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=cesar.mena@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).