From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface Date: Fri, 14 Feb 2020 13:14:39 +0800 Message-ID: <87mu9lrbr4.fsf@gmail.com> References: <20180422205003.87836-1-roberthambrock@gmail.com> <20180422205003.87836-3-roberthambrock@gmail.com> <87v9ocuesg.fsf@gmail.com> <87imkb7mwj.fsf@gnu.org> <87y2t6fqwj.fsf@gmail.com> <87pnei8oe0.fsf@bzg.fr> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:51755) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2TJY-00048h-EE for emacs-orgmode@gnu.org; Fri, 14 Feb 2020 00:14:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2TJX-0007oB-8s for emacs-orgmode@gnu.org; Fri, 14 Feb 2020 00:14:56 -0500 Received: from [112.17.238.48] (port=55301 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2TJW-0007el-NU for emacs-orgmode@gnu.org; Fri, 14 Feb 2020 00:14:55 -0500 In-reply-to: <87pnei8oe0.fsf@bzg.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Bastien Cc: roberthambrock@gmail.com, emacs-orgmode@gnu.org =2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Bastien writes: > Hi, > > stardiviner writes: > >> And patches in attachments. > > Applied, thanks. Great! > > I made some minor modifications: > > - I added the TINYCHANGE cookie in both messages > - I replaced "ob-clojure.el: (...)" by "ob-clojure.el (...):" > > In general, try `C-x 4 a' on a change, either from magit or from > the modified buffer: this will format a correct changelog entry. A good advice tip. I will use it. Thanks. > > Also, users may need to figure out that ClojureScript src blocks > need a proper environment to execute src blocks. I.e. we should > recommend users to have their .org file within a ClojureScript > project -- I added something along these lines in the ORG-NEWS > entry. > > If you want to contribute further, you'd need to sign the FSF > papers: https://orgmode.org/request-assign-future.txt > I've already signed FSF papers before. Actually I contributed some patches = already. :) > Thanks! =2D --=20 [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 =20=20=20=20=20=20 =2D----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5GLL8UHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsOS7wf/XjDmlqgD0Us1RgDtarIXAfJDgIjy +S8tEgeSHJSmPFSpifDyYSxAKwRGE1b5v/uUHcxECCana9k8iQ/T7VwFb6vY8XNY NzpM1ZAErSNaOcFWOVH4yEoA8d6V/2Jir7p/SEblZid9HOC9zNpOzw4PxYr81/r5 Mof4/cQnwj1W6Z5MUqVj4rSotx3pBy1TqxCleGXj4EFsRBnJ6RMgvH+x3BYnLBAT 6zhle6hFrJtQGdiaH6YRHJ2ln52LTlozqnLCE2ROsp+ZDnS4lS5gp+2RIDnYPxq1 rszeDHWhAJcwmhPEikMzbmOGvy6X+nljVbLFJOzkFfsSkqFcam+onkLMzw=3D=3D =3DT3Qi =2D----END PGP SIGNATURE-----