From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YCu8ITmVOGDaVQAA0tVLHw (envelope-from ) for ; Fri, 26 Feb 2021 06:29:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2Np1HTmVOGAnJAAAB5/wlQ (envelope-from ) for ; Fri, 26 Feb 2021 06:29:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D76D326D19 for ; Fri, 26 Feb 2021 07:29:12 +0100 (CET) Received: from localhost ([::1]:54310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFWch-00046n-Gm for larch@yhetil.org; Fri, 26 Feb 2021 01:29:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFWcI-00046J-5E for emacs-orgmode@gnu.org; Fri, 26 Feb 2021 01:28:46 -0500 Received: from out0.migadu.com ([2001:41d0:2:267::]:44334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFWbr-0005s1-N8 for emacs-orgmode@gnu.org; Fri, 26 Feb 2021 01:28:45 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1614320895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7YI2SDAiSXqLCs2CenJC2hFxItPX6bX2UYlG0QqKbK4=; b=haOvT5ubBT6Qpt3TZtR/mI4s1FsS5wJwzA45neHdZofRleb562yZMNkzMX8MYxEkto5vks 7k+OVk+6+k4ZtsDWTNL47PtW0bW7xC2IztyYPFaw74SAmBziDRmx5GeivxPs5guJhhK5E2 21688TiIK69o2+iAMfa1IGcn1U3iyrbKLC3Cg3ExnptSAjIGUVttIUf1tYZi4z/2rezSme 4DkMSmdav2uesOOgRpx2rkyUFXNr6DRIWs/DQx5MVdM7BASTR/1Sv5REYrqwkzTNYyMQyG crmbMi50yS8o/2fXJ3q48SgiJmMQGPn32d4LXCEEIFu3bl2T/BYhr4WBB+Az1w== From: Kyle Meyer To: Michael Heerdegen Subject: Re: org-read-date: selecting date with mouse-2 in calendar In-Reply-To: <87mtvr5wi3.fsf@web.de> References: <87tuqfnyzz.fsf@web.de> <87mtvr5wi3.fsf@web.de> Date: Fri, 26 Feb 2021 01:28:14 -0500 Message-ID: <87mtvre41t.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614320952; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7YI2SDAiSXqLCs2CenJC2hFxItPX6bX2UYlG0QqKbK4=; b=Oks4W4WoSg6N5ektRD8a9VG4KOdO2AX/aoLMBbQNnpr89Bz2gTu6rKmkHb8dTSgM0iegFj 3GqZr6nDSCsU5cHrEboy3bYRGDabII9gwRoo6TDbhZzpzZ+c1flMWu+iSFJU78Ixk/HCwE 119AIlP9PEKy66PrwGfrkw6EYi3wD1LvZ0eviephXGQc4AA9Jy+0Owy5TYVcAJaw9lb8oG evQVQ7vH6lctHDIvzhGdpruTGic+Oi6yzkpaKL8a6d2bqOGMKysCQj04sh1B8fmCUzGfbf O6SkginJwxDvFYADoOXZ3mklxMpCmMJEnwd975ufXkTCSEuTfzNbTeojFd7vsw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614320952; a=rsa-sha256; cv=none; b=stAXR0WehLDrwbSg/tmFviDD2TkGd/2y9GASOKh3yRUcXmDr84fvrHhYoqp8mX7wOY1Yj7 YJJtwQ2sT24r6aygKLOMgAq/4OlQMrV8b+JlqRVxQw61sefi5zB+F+8kcNgPzYJ6/S6akp VsNnjMk/otmUkMDcM9QUe8I4g60qCf/Lk8LKEGmCnufRgVI+gtrKD8SdKzICtpnVJs82ob jRgn9OeJwwODBznN07Zk6qKK1+ClhhDjZZezRXtbXMhyOZggrYhtfmj9ipyE5NulvXkfND jlv/+OfmBuDO//qV+3a3OC7N6PAVMsAVQQN7keOGSFtkZxgYaeSYgGjPjoWRuw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=haOvT5ub; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.57 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=haOvT5ub; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D76D326D19 X-Spam-Score: -2.57 X-Migadu-Scanner: scn1.migadu.com X-TUID: DuzzsUXZcNzQ Michael Heerdegen writes: > Hello again, > >> selecting a date from within `org-read-date' from the calendar works >> with mouse-1, but not with mouse-2 (with latest Emacs master and my >> settings loaded at least). >> >> The code seems to intend that it also works with mouse-2, but it fails. >> >> Why it doesn't work? Oh, that's because calendar already binds >> down-mouse-2 to pop-up a menu (see definition of `calendar-mode-map'). >> So when we would add the following line to `org-read-date' (it's obvious >> to where and I'm too lazy to create a patch now): >> >> + (org-defkey map [down-mouse-2] nil) > > No comments on this (hope it wasn't too confused...)? I don't know anything about these mouse things and have to review the manual whenever they come up. Please provide a patch with a proper commit message, and I'll review it this weekend if nobody else gets to it sooner. > Should I just commit the fix to the Emacs master branch? No, I'd appreciate if you did not.