From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id TsQ0ELqCn2CoLgEAgWs5BA (envelope-from ) for ; Sat, 15 May 2021 10:13:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AG9nC7qCn2DEcQAA1q6Kng (envelope-from ) for ; Sat, 15 May 2021 08:13:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 82E241EFCD for ; Sat, 15 May 2021 10:13:45 +0200 (CEST) Received: from localhost ([::1]:45958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhpQd-0000ig-Mw for larch@yhetil.org; Sat, 15 May 2021 04:13:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhpPq-0000eQ-OC for emacs-orgmode@gnu.org; Sat, 15 May 2021 04:12:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37338) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhpPq-0003hG-HM; Sat, 15 May 2021 04:12:54 -0400 Received: from [78.194.183.21] (port=48676 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhpPq-0004oA-1c; Sat, 15 May 2021 04:12:54 -0400 Received: by guerry (Postfix, from userid 1000) id 9D7A61A60E7F; Sat, 15 May 2021 10:12:51 +0200 (CEST) From: Bastien To: Samim Pezeshki Subject: Re: [PATCH] org-agenda: Skip formatting if format string is "" In-Reply-To: (Samim Pezeshki's message of "Sat, 8 May 2021 20:25:19 +0430") Organization: GNU References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sat, 15 May 2021 10:12:51 +0200 Message-ID: <87mtswct4s.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621066425; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=l2KN3njqJ6d5Lv8cjNoRMNEt5S0si7ItXLV35Y/f5lw=; b=fMhf3PcK2ZMYWROaMOR+zWjXnCvTl3q+rQCPkOy78HyvX+pPdXQBEIRoQjN79ih5gxsLRp lHEwZqeUPZefSRNtNrZ3iUZfIPxlC5Ft+H3tKOUnYrVzRZdtJPaDHIPYdICNF4lKDf6Zv5 eoMzRVVpKc3wh3y908jwUfnT+2JCZWe7AZHIAi68jQBkdUzTl0qR0gQ6AQflbakLz9XZAY vzUvHcgs2qQwTdm37OWo4pz2BL/w47UNM8jqE9kyhyz26aRGMvOoxpWs39AHGmqIfQTcM4 gheAXl2pA4Exbgi/3JcmLXl/f+5PgqI7nhlb/CeTg4/k6BTvLCiFlw1a2Vcgpw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621066425; a=rsa-sha256; cv=none; b=quzDgGNecdWrv9sX4vtfKr0P7PHQEAZp98i0aQ8i9ECY8T7HbR494f8NStb/wVZ1lwWX24 KCswm7JEggQYJc0f4vezmDoE77kKi0x00erFIZO/PrVwyJV8wx1mdpq2XslGEJCUm1yjqB D/4bhIPwDXET8BAC8ksnbndVCr5f8a1blI8Pec0Iy1RL129pkwg2iyj7vS8gjBaEVTiZk7 /Dt4w7NQ2V83vFEx0wxwMCnCuiwY1ckFQHjNpOG3UMZkutmh+7tloHTSJXhLQPrbYWVZLi mHXuBhJjO8JBR6wNsAjmHFjIs0DbVueL3g55uPxozboJraRSiwXVU+jyppj4EQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 82E241EFCD X-Spam-Score: -2.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: etw4jULFXkBf Hi Samim, Samim Pezeshki writes: > This is my first patch. Thank you! > The patch skips formatting TODO item in org-agenda when the format > string is "".=C2=A0 > When the format string was "" the extra space would still be inserted > which was not needed when there is no TODO keyword. Applied in the maint branch as 06c064e97 with some minor modifications and a proper changelog entry in the commit message. See https://orgmode.org/worg/org-contribute.html#commit-messages Thanks, --=20 Bastien