From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2LZMEEn3lmPPUQAAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 10:41:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kAYYEEn3lmPYawEAauVa8A (envelope-from ) for ; Mon, 12 Dec 2022 10:41:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B201AD98 for ; Mon, 12 Dec 2022 10:41:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4fIn-00019n-RB; Mon, 12 Dec 2022 04:40:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fIh-00018k-Rs for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 04:40:44 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fIf-0007Eb-TH for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 04:40:43 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8F882240027 for ; Mon, 12 Dec 2022 10:40:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670838038; bh=/k77VMxzv49a9oV70FIpwgKDAWzPT3x2alk5gHUZsvw=; h=From:To:Cc:Subject:Date:From; b=hJb57Sn1GLt89jsmwo9KWmj1K1omsoQMs6547tdVfPrYZ1VdPkvKC3GrDtmmowsxq IvTO6Ara0d07WYjPAtDVfhNt6dFK/cuDje5tw6LsvR6gfv1Bduy6uSFA45b8rCTRT9 8M8HLQBfL6eRlxo2gXwn9O1OxIf95Fh4jHB9gfQjDnhPBYzv5Xe3xzR853gYB4zEd9 o9piQs0KnKrk0eKRdurDpuLjUTsw4wH/XZetk4ZMSj5MEO31S/NSVDFiDeQVGHrq+h HCAySvfERJYDaKB0zi3hzsSBKCKnNKWe1GEsHSJHjYbzMd/fF7AQucqWP2zHw6GeN1 4kTrFWIMsuVDw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NVxSh6fHMz9rxB; Mon, 12 Dec 2022 10:40:36 +0100 (CET) From: Ihor Radchenko To: Tom Gillespie Cc: emacs-orgmode Subject: Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats In-Reply-To: References: <87leni86l5.fsf@localhost> <87wn6yl2hj.fsf@localhost> Date: Mon, 12 Dec 2022 09:40:36 +0000 Message-ID: <87mt7thsdn.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670838089; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=b4/KW2dVGMNKuPLWqLX4KRuXyeuXIbdrEYPj1QLnHow=; b=sLvlpUqUbeLISWPnFmZRM834czlhddeLdGDFVJUEX8QqYwDWVklISX+QFase9PF5YKvUvv U6UQvpdl7HmHY+BNd96P6fiaBogoCLGkocVktzCgpqvlyTf6s6iOTPnUBr35nyyG/AnRLU ZaUo1LPVRQRenFAda6IbPUhgevS/PZJCncMZGLGAUwZGNMpNULObj6erMNefIp89ZqZs0l G1Iunvc+DWqoY57KsQjczblssa4w21zvP7elw6reeuNnMtAdxJBGmQyZG5W8RcOcvK8yDX wUNLqHb0YTNm7Q6wfzi5+9tcrwAA8sLKI+G+H8q6FYbdgvyjMzzi4YsMC0x2wA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hJb57Sn1; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670838089; a=rsa-sha256; cv=none; b=LcCRyuKyqbsYcLilq3QZkAYHY86oAMkwbJs86hA2vj+Badzjy9p+0HvA+Ops7ByScnaM+p 67l1WDQTXZeINQWHBDXAxDnCob4AdtOk5nXbW2GtDKKFtZSv/YOHBCBUiaDcJUATa9TFgY gLvTMK2ekht9OgAoFZGr7lm96IEdpbtcgS+SGv63QoWOxdBPdx09h5pDo/KASYXPA+ddNO ouBpPjQiIMTQi6favtCI+/r47cmY44K++mOjEbe226LjUK3uVCaOZ0vFSRMTvLyEkSn/Yh miRvnsGNoOE/BbhARix1ITPXhCTY2c1bn8YnKkLMJmEi8HphlMpnsq+JRht2Iw== X-Migadu-Spam-Score: -11.05 X-Spam-Score: -11.05 X-Migadu-Queue-Id: 1B201AD98 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=hJb57Sn1; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: aJ5kJk0WFRiD Tom Gillespie writes: > Looks like string-replace doesn't support that notation, > so both too aggressive and without sufficient control. > I've switched to replace-regexp-in-string which does > what we want. > > Here's the updated patch. Thanks! Note that your patch does not apply onto master. There is another recent patch attempting the same fix, but in less general way. I can apply your patch if you adjust it to the current master as your patch is going to be compatible with older Org as well. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at