From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id RgwsLuH9omNxTQAAbAwnHQ (envelope-from ) for ; Wed, 21 Dec 2022 13:36:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sKhWLeH9omNNugAA9RJhRA (envelope-from ) for ; Wed, 21 Dec 2022 13:36:49 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9294DDBDF for ; Wed, 21 Dec 2022 13:36:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7yKo-00019x-Ju; Wed, 21 Dec 2022 07:36:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7yKk-00016h-O5 for emacs-orgmode@gnu.org; Wed, 21 Dec 2022 07:36:31 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7yKe-0007Qg-0l for emacs-orgmode@gnu.org; Wed, 21 Dec 2022 07:36:27 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9EECE240103 for ; Wed, 21 Dec 2022 13:36:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671626181; bh=HxRivuSDk6WhAO5BakD3NCpGswo+0xdiPuC5DezQxo0=; h=From:To:Cc:Subject:Date:From; b=DAXQLdLFPuBuvsFcOMp/JC/Iexc5Jxc6Ydno5gpbV0dE5X7EvQ14YWT043ktML2w1 LOdVKIuEUhSHSdSAo42o1iQ68GdRCnooAljVJgNA6NcUiPkuDmaLZFdssgJ937W/sA wX0CEd5k+NALq2sCBv8s+P4oEtoOxp7h4WNkT4ScnYPK+18si8/nNICtLIxB2JyPlM F6jBgc6wt/QBXyyg+7x41NpqWvgKDXpzTaGpcgT2lsPKy4xcdb3IgVR+MxSR0Q7TCy YL1U3Tn0u/z/G1DjQ3YghGxs8IWmy85bp763oIdzKqyitj6iZTIxVcObJwscdoBJ8g GmrZ7Ew0TX+1A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NcXxJ6Mhrz9rxB; Wed, 21 Dec 2022 13:36:20 +0100 (CET) From: Ihor Radchenko To: Brian Powell Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] commit 7048876f broke Figure link with caption [9.6 (release_9.6 @ /Users/powellb/src/org-mode/lisp/)] In-Reply-To: References: Date: Wed, 21 Dec 2022 12:36:12 +0000 Message-ID: <87mt7hvsqr.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671626209; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Mj0XukXICiqyZAvUcQz1BXfprSFQX9FuaApmXnXCIjM=; b=IE3TSYCmCM28zfmn0HqyLniGNnOQ1znJEGapRDJklIbSDrUhInWZEXmc6OpfaXr1kqoaZ6 IzGqyGubh6EFndkdZygtgBIeObIMZ5z5lnqtVoAgc3sX0HB0JhLLoKHJAuLC3m6523ufra 8av8lsfRBx0hSgZiEWTI9119WTTHdzrJegerdOnkQylfkydnnN7W7vtGZT9k3O+m+ICVaR g5aCELpqRQlcfI+nUMJkQ4unvTnZFF58NwN6VpJ7m/4utGYy/8ZlVnKeK/JZs7lbVmmQZn FX8+vKl1Xndt0DhBzkJ+btUVjC+EHUb4e8ahX0/vmQ/TwnIl+gSJ4f4BvH7S6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DAXQLdLF; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671626209; a=rsa-sha256; cv=none; b=WPx5DhmGv7Nc4Oto4k3bJWVWjAXyl2KVXVaQEiB+21BYdlR2PoPzAPwFsNqnCA+F3QgbaV nUTT0gCeLrIHRJwvWlujiTaoe/I0khC4qhfQIXWSKwjOdasLxRvaoYTAu02RTiQrrY2bGp NZb3gjhhnCrsCKLVzjN84FHk++M6K9YRlTSd4iKDGVv40iZn/ABNvJ4gpnGmlABvVGa3Ut GaXNqBU7lAmjKSSQOZqJ4NTSVDwXEsT4vlkFDlA42CUdCciZyyjiapajKBULP4LoSeqtnH 8KKZpGu5G3xvFsxbuTXsnPH5thDLNbsP3IkDwctRGB6dkzqef0rx6YvEUkiwCA== X-Spam-Score: -5.92 X-Migadu-Queue-Id: 9294DDBDF Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DAXQLdLF; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -5.92 X-TUID: r7CWlbl4S7QA Brian Powell writes: > It seems that the following commit broke the ability to link to a figure > with a caption. > > commit 7048876f6fa519513763c83bc5baa791420cddab > Author: Ihor Radchenko > Date: Tue Dec 13 11:44:22 2022 +0300 > > org-export-get-ordinal: Do not ignore ELEMENT type when TYPES is given > > * lisp/ox.el (org-export-get-ordinal): Append ELEMENT type to TYPES, > when TYPES is non-nil. > > I have a simple file with a figure and image link. The figure has a > #+name and #+caption. If I add a link to the figure name in the > document, then exporting to HTML fails. Prior commits did not have any issue. Thanks for reporting! I was unable to reproduce the problem with the given recipe, but I do see what is wrong looking at the backtrace. Fixed on bugfix now. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=db34a7d83 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at