From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id qNmjIPAvYmSfIwEASxT56A (envelope-from ) for ; Mon, 15 May 2023 15:13:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yGOaIPAvYmQb9gAA9RJhRA (envelope-from ) for ; Mon, 15 May 2023 15:13:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 00473102FA for ; Mon, 15 May 2023 15:13:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyXyg-00010u-Ng; Mon, 15 May 2023 09:11:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyXyb-0000nS-Od for emacs-orgmode@gnu.org; Mon, 15 May 2023 09:10:58 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyXyX-0002jR-Tf for emacs-orgmode@gnu.org; Mon, 15 May 2023 09:10:57 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7FCC4240104 for ; Mon, 15 May 2023 15:10:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684156251; bh=nRzRnXR182wK5sjzl88cE7AIX6mS/JLBYU2VIZiKQkc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=DLut1bnoyU2FfXygqMbEE4KROPFISdEG9RYM1zsS8fRP/3lpwXIGSIHCHnFPlEJIo 01JUTZCwLyNm6UZdIFQTgZmVUsOGhBsY+HQM0G6mQ6SoO+VeRtZG2smvqtNMJhRP93 2BeJ/umrekc9pG/kcRCcZPh17N+383ZkK2YX0SjLYglEP4un6pi6AEcDQ+jSnaVwlW nElDRSqliPuU87NjrgTnd9zS/2M6M/bR9sUxDUhdIe8jqCa20yyYsLLqDpZxVfMBNb V6Ga3muQBHbHk3e8cqxQn5GQpEUO8fdAWtt1K980nox4njbbQFfuIJpLqNAnQOIpJw CRXqLL8y+b82w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QKfrC19c0z6tv5; Mon, 15 May 2023 15:10:51 +0200 (CEST) From: Ihor Radchenko To: "Christopher M. Miles" Cc: Org-mode Subject: Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist` In-Reply-To: <64622bd7.a70a0220.d2249.62a1@mx.google.com> References: <878rds1xta.fsf@localhost> <87a5y8iiak.fsf@localhost> <645fc094.170a0220.4d545.38e1@mx.google.com> <87wn1cgjij.fsf@localhost> <64604168.170a0220.99926.5b4f@mx.google.com> <87lehrgwqn.fsf@localhost> <6460f5e3.630a0220.b9085.17d2@mx.google.com> <87ilcvdknx.fsf@localhost> <64611586.a70a0220.53db4.4151@mx.google.com> <871qjiiziz.fsf@localhost> <64612e34.170a0220.28faa.5dcb@mx.google.com> <87v8gthnc9.fsf@localhost> <64622bd7.a70a0220.d2249.62a1@mx.google.com> Date: Mon, 15 May 2023 13:14:17 +0000 Message-ID: <87mt25hh3q.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684156400; a=rsa-sha256; cv=none; b=UW9dkOSqeSVRFEIsu9hCPYB5XBqgNgV3ld/84PiHHIUQzBM2eZTynHmAy1oFNaLGYc/qXK ZqY731hoP/YO2IpnugqwT+KUh53VCf2Y1HkMpVdBJvht0xP/+j5ri6cH9LSQE4TIsHNBwB nqLbFDH3buHpuoL/Sm9GuCD5/O7GssdhunMg6ggH9YMjTefJwM7U+IOrH95en99Eq7koyF s4jkR6SOBeO6XJmOV8gWw9J+JlWInYjZXRfAW9RI54xTzJyVdHnSxRUUReMnYGB/V/HweG YaHGVccv2C3ufbskzODEUgA5ex+FtcOqaBEcLCV7Ha/s3HoNY/8SB+shytiQGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DLut1bno; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684156400; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uRq8u8uaHsT4R8ecBtQpHsV1go5+8MYsC/OghweOWNc=; b=OirrkCq3OmLM2n7m6SlnHP2wpvLBigUqMF3FuXF0xWhpYs5XHH7mEyn4VJWaQZQEON6a2+ QJPOD7OicshDT8ueVRtkITNhEW214o45tyhu3qYTW7mo+UreXdSLmRS52dSzLSBosbwXK/ oIUAO/eSKtYv/+C2XwxNacfHtb/b3dH7SzyuiBO0xCMfAntI8etSe11ZwGHm+56O85sdrx /egrRnO+cECfT/jjdyYaJxXUV8bRcRh2GTUKNyUMk87Gbxsm/tN0uQZ/IkIzobsGsucr63 SfHMYyXAJxuvo0+Lw2bkxAtJtOuWV+C5BM2v2yckGTio8+Rhw+g9o5By+gnUig== X-Migadu-Spam-Score: -6.47 X-Spam-Score: -6.47 X-Migadu-Queue-Id: 00473102FA X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DLut1bno; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: J5niPTw0Z30y "Christopher M. Miles" writes: >> I do not think that we need to care about the value of >> `org-use-fast-tag-selection'. Instead, just >> >> 1. If the total number of tags does not exceed >> `org-fast-tag-selection-maximum-tags', display them all. >> 2. If the total number of tags is larger, just display all the bound >> tags + any extra tags, up to `org-fast-tag-selection-maximum-tags', >> and add a note in the tag selection buffer that more tags are not >> displayed. > > I think we should consider the option `org-use-fast-tag-selection'. > Because it controls the behavior that whether auto assign short-key to > tags. Make condition decision based on this option is needed. I hope you > can reconsider this. We probably have a misunderstanding about the role of `org-use-fast-tag-selection'. `org-use-fast-tag-selection' _currently_ determines whether to display the tag selection window at all: Non-nil means use fast tag selection scheme. This is a special interface to select and deselect tags with single keys. When nil, fast selection is never used. When the symbol auto, fast selection is used if and only if selection characters for tags have been configured, either through the variable org-tag-alist or through a #+TAGS line in the buffer. When t, fast selection is always used and selection keys are assigned automatically if necessary. Even when the value is t, not 'auto, the user bindings for tags are honored. `org-fast-tag-selection' never checks the value of `org-use-fast-tag-selection'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at