From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uBifNQjOvGRTrQAASxT56A (envelope-from ) for ; Sun, 23 Jul 2023 08:51:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GN+rNAjOvGRrAwEAG6o9tA (envelope-from ) for ; Sun, 23 Jul 2023 08:51:52 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF38E3A97A for ; Sun, 23 Jul 2023 08:51:47 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Mvkro6Bp; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690095107; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=X4zk4k85wy1Rr/8CR54cYbMqwFUz0UtOQz56CrhNHPU=; b=d00fXzfg1ytzZWbILXa3jkzYbCBHkwbpmDdodudaBXDjktspqX+XzPHVvWAsmAL5n6ozzk 1FwgHmR5HwpM74IiWIn7ip7tdGZ0qCMoVA1ChgtXePYzxyHVPkKNEYmWTs6Nt0nYRqzWUp rPQ72rffB06rkE3l5edbb0RoIfPXhWbKI8xipjVAYuw06FkTJMwR3K3dWzVIU4ioSVfYp8 4nOAFVBD1aK6SIIejDigdYSvsF11NmyPnyfzxbLoxhxoiegw6h+tWlaK9+l3dKDAm5Mghj 7qVUxtMh9vJH2+0oACQ4Fm+sQo2nVdBcCGbh8sjIU1FSoQGDxgVTTh3TGXmQTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690095107; a=rsa-sha256; cv=none; b=ny10kmvb2Slf9uGrzA+BfGUYhpCMU8mh7p/iRsffPuJ4yHemV2Sf1seql8FTbbjrgyZ644 HVfqw0f1sSnRVuAapONIhM232hanhyrRYBaJJs5YwSL5S2yGfUalQtRKvrybJ8bedJoN0o UDKw7tR5I/dxp6NuUoJ1XIpzYS55a5C58U/5Y9u9KYoAv+iaaHEbUqb6MIpnkGAFINCrzH bpYn755M+DrMIJl/yNAnaENZ3YwJCXVPKcH/kgvPjWqkHADYoDu2Xu6QGmSajow5i4m7Rh 3RQet4NFEUT97h1ZhPRlOmc0f8JhoXlF7mWsDYFL83F+PSXuAvPF5ShMjyqBgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Mvkro6Bp; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNSqa-0002YA-Qg; Sun, 23 Jul 2023 02:45:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNSqO-0002Xi-B2 for emacs-orgmode@gnu.org; Sun, 23 Jul 2023 02:45:28 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNSqM-0002Zt-EI for emacs-orgmode@gnu.org; Sun, 23 Jul 2023 02:45:28 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 01006240103 for ; Sun, 23 Jul 2023 08:45:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690094723; bh=S5dIi1bQOf3A8jUNMCNmrgzK4QGUheZKFWpXs8bsfXk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=Mvkro6BpzE/DgCb/eoTXojLhZQehT4yUvEG2fZry4G39hqKrTcBcodHuk8pBLdo1L sZWG3T2Yf2vT80yv03XOpCoKhaIk9muW5CLLRFLWjPcdDoFbidwcSfz6oGPGcP7TkR BSeHtZhIE7i9WbvpMHYDeXFDhprexBgpB0UdNOqsEY0lApKAHmsYR/oI+ISZKJD9Xs q9QdamJoRKbNBEGMmup8RtGeCUujGXrLWv8+tOMimzOwtDfo7VGy2L6gbUNolPODl5 8vX44DubE47yXIKA3YUCtAkbnLv7K6Ouro/BWaOFYouEinVS1ifUEHLuoP57u9UMJH yXhVja3EqdC0A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R7v1Z1Nhcz9rxQ; Sun, 23 Jul 2023 08:45:22 +0200 (CEST) From: Ihor Radchenko To: Eric Abrahamsen Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)] In-Reply-To: <87edkzveks.fsf@ericabrahamsen.net> References: <2fa5914d-2cbf-f41f-8be6-e79e77794140@vodafonemail.de> <87y1j8rrag.fsf@localhost> <1b9fbe38-0572-7861-e433-8f26457302bb@vodafonemail.de> <87edkzveks.fsf@ericabrahamsen.net> Date: Sun, 23 Jul 2023 06:45:32 +0000 Message-ID: <87msznrur7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.35 X-Spam-Score: -6.35 X-Migadu-Queue-Id: AF38E3A97A X-Migadu-Scanner: mx1.migadu.com X-TUID: 7CS3/+ejoERC Eric Abrahamsen writes: > We should definitely be using the paradigm above (using the > gnus-summary-buffer as the current buffer). The article number fetching > only works by accident in the article buffer, and other stuff (like > finding the original nnselect group name) won't work at all. I am convinced then. Ideally, it would be nice to have tests, though I have no clue how to approach writing them. > Later in the function we've got this: > > (save-window-excursion > (save-excursion > (gnus-article-show-summary) > (gnus-summary-article-header))) > > If we're currently in article-mode. The call to > `gnus-article-show-summary' would protect against the case where the > summary buffer has been killed in the meantime, but I agree that's kind > of a pathological case. I'd say that the patch will be an improvement anyway. > Probably it would be enough to wrap the whole containing `let*' in a > (with-current-buffer gnus-summary-buffer ...). If we're already in the > summary buffer, no harm done. I am not sure if it is safe. There is (save-window-excursion (gnus-summary-select-article)) which calls (set-buffer gnus-summary-buffer) `with-current-buffer' will certainly alter how things work (although, switching buffer when capturing link is already fishy). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at