From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mFdzLinwvWTwfgEASxT56A (envelope-from ) for ; Mon, 24 Jul 2023 05:29:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ELqJLinwvWTNgQEAauVa8A (envelope-from ) for ; Mon, 24 Jul 2023 05:29:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2C76A53B3F for ; Mon, 24 Jul 2023 05:29:45 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=runbox.com header.s=selector1 header.b="hp k7AIp"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=runbox.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690169385; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pjApxPnbr0Y7JCiPa1v+b6U8TqaU9RFH/JZC2X7eUiM=; b=F7rk7RDe+gEN0s3h0eSweOy2+kfG4r7zo+iaSTcuYzd/TgREBsCNtMjUjqoPfMwgCsPQPu KY9GV72pj3wytBRS3AHCmJvvJ3iFHlZpRHltw5RyBn1L4z6IXDnzzWG2yoc9EHr9uksfCS m/f3Rt/tRmVKvFxypVDJtGOHHN/yg3tkHs/+yQaeKL+AmlJoOcgWx46VVELJPMhzz06XUO LSfYTzg1g9p3t+/grUHKB0oVL1imsNOeR8ayzAy9B7dTF0Vb0dBiS1f5J1oz1MJUH0FF0K d5kXb7enFxoq6lBEMZh719/vQsK983ExnTcuISugEhxOXN0N6qbStc5JrPwYmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=runbox.com header.s=selector1 header.b="hp k7AIp"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=runbox.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690169385; a=rsa-sha256; cv=none; b=KozNPvcG75Wc9u+FZQkW/XYvU1+/ZFeI5vf7EARe9QOVa5GBmmJryRQK+KYGRJMrp3BXKO UcRcHn2NruJJgmIqAt8dGC7rPDDfjN9/rm11n3PsjCQNSAOYpRPpDKmtPpOuH4hOMuojuV e34O2EVaDEs4LQV9W+3Hq7/I6gFbjz4NYiKoKsQT2SbZ1FYyIXYi0EE6HAmHs5hAthhWJk fKSBsVyjLXYyn8qrmzOPAMBQr4f/3l5TzsPKw+o7WeqiTEu87wQ6bDYC6QcvAjQoZqiG6r Jy3RZhiLTJmIVCuSqa+m6DaU2n8dw/wsOzHAsawJJsvEg+haHOEZhZaQS+iMfQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNmFd-00089B-Kl; Sun, 23 Jul 2023 23:28:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNmFT-00087E-Ts for emacs-orgmode@gnu.org; Sun, 23 Jul 2023 23:28:40 -0400 Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNmFQ-0005ZD-FQ for emacs-orgmode@gnu.org; Sun, 23 Jul 2023 23:28:39 -0400 Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1qNmFJ-00BbRm-FN; Mon, 24 Jul 2023 05:28:29 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject :Cc:To:From:References; bh=pjApxPnbr0Y7JCiPa1v+b6U8TqaU9RFH/JZC2X7eUiM=; b=hp k7AIpQPUz804l8/WznHDHMHikd5w3j4eFm6DnSq8xlsgP9eyjouYPoLy9Izr58f8wfyE7SKG3UmiP 27kbeoQ9lqoRHossoWEThnKsBZATp2CSltBmpzX/wtIV2xaokJpQsHOiPlQYMagERgM+n9VThMVks JwSr6OyChm3Of7oXudpqUaxGpZOTJontqRl4qYQKpeyq+krfldg7ctxpEUFQ4qaTir0Iju/bTSIh3 7lwCvWB1BCxN+29SY34IGzfxnOWj6DbV2GLmO04PpmP8+/bx4ELPtbxXenqxrOBgSfM05WYvOBwdY kmV/gJ+873kBesusTyKpPAE9iP6n9lkQ==; Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1qNmFJ-0003h2-5h; Mon, 24 Jul 2023 05:28:29 +0200 Received: by submission03.runbox with esmtpsa [Authenticated ID (946465)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1qNmFE-0003xs-1t; Mon, 24 Jul 2023 05:28:24 +0200 References: <877cqwbpa2.fsf@runbox.com> <87bkg3hga5.fsf@runbox.com> <87jzurrujq.fsf@localhost> User-agent: mu4e 1.10.4; emacs 29.0.92 From: Gavin Downard To: Ihor Radchenko Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-table.el: Allow named columns on lhs Date: Sun, 23 Jul 2023 20:25:21 -0700 In-reply-to: <87jzurrujq.fsf@localhost> Message-ID: <87mszmgf8r.fsf@runbox.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a0c:5a00:149::26; envelope-from=gavin.downard@runbox.com; helo=mailtransmit05.runbox.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -9.25 X-Migadu-Queue-Id: 2C76A53B3F X-Migadu-Spam-Score: -9.25 X-Migadu-Scanner: mx0.migadu.com X-TUID: cJJxGxb8qTYL Ihor Radchenko writes: > Do we have any tests covering this part of the code? Not that I know of. I can add a test case for this specific instance, but I'm not sure if I should add more comprehensive tests in this patch. What do you think? > In Emacs 26, we will need (require 'subr-x), but otherwise it is not a > problem to use `if-let'. Oh, I didn't realize that. Sorry about that.